3c9b2e28c7
Drop commented out / dead code
2018-05-23 18:53:12 -05:00
a30c3a63e4
Merge pull request #341 from CanonicalLtd/mwhudson/scollbars-as-decoration
...
convert ScrollBarListBox to decoration rather than subclass
2018-05-24 10:39:41 +12:00
0fe1f5145c
sprinkle in some more ".base_widget"s
2018-05-23 13:40:14 +12:00
7441cb6df6
convert ScrollBarListBox to decoration rather than subclass
...
for all the usual reasons why composition is better than inheritance,
but in particular because I want to have a listbox that has a scrollbar
but not our custom tab behaviour in another branch. decoration in urwid
is not as transparent as it sometimes seems it should be but luckily
there's only one view that does much with its listbox and it was due
for some cleanup anyway.
2018-05-23 13:14:00 +12:00
626488e988
Merge pull request #334 from CanonicalLtd/mwhudson/move-excerpt-title-to-view
...
move excerpt, title and footer from controller to view
2018-05-22 22:38:39 +12:00
8d6a966e89
Merge pull request #338 from raharper/fix/subprocess_encoding
...
Fix/subprocess encoding
2018-05-22 10:01:24 +12:00
a84dd2b272
Encoding input when running commands
2018-05-21 13:35:26 -05:00
74ae9b9fde
Drop use of encoding kwarg to subprocess for python3.5 compat
2018-05-21 11:54:34 -05:00
e1a6542d86
run_command returns a CalledProcess object, no 'output' attribute, but 'stdout' instead
2018-05-21 11:29:41 -05:00
79208bc00b
trap a TaskSequence gotcha
2018-05-21 13:09:56 +12:00
4f531724bc
fix identity crash
2018-05-21 12:56:05 +12:00
70ec850aad
Merge pull request #336 from CanonicalLtd/mwhudson/hack-ThreadPoolExecutor
...
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:59:12 +12:00
384dadc5ed
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:58:10 +12:00
381d0bda8e
Merge pull request #335 from CanonicalLtd/mwhudson/move-tasksequence
...
move TaskSequence somewhere more generic
2018-05-21 11:57:23 +12:00
f6f214125f
move TaskSequence somewhere more generic
...
I want to reuse it in my containerizing branch.
Improve API and docs a bit while I am looking at it.
2018-05-21 11:52:06 +12:00
feda622ed2
hack setup.py to avoid needing to import subiquitycore
...
or else build_i18n fails!
2018-05-21 10:30:17 +12:00
cbd5afe2c0
move imports of i18n higher so _ is always installed before tests are imported
2018-05-21 10:14:34 +12:00
ac875751fb
fix installprogress
2018-05-18 16:27:05 +12:00
ba0625bd6b
convert identity
2018-05-18 16:18:27 +12:00
9ef2c4d7a2
convert filesystem views
...
impatient to get on with rewriting these as part of the raid work...
2018-05-18 16:14:10 +12:00
f36525b740
convert proxy
2018-05-18 15:58:34 +12:00
11708703c9
move titles, footers, excerpts from controller to view
...
read title and footer from the view instance, make views respsonsible for rendering
the excerpt
adapts infrastructure, welcome, keyboard, network views
2018-05-18 15:55:49 +12:00
bdf2bd35a7
Merge pull request #329 from CanonicalLtd/mwhudson/proxy-tweaks
...
configure proxy for apt and snapd in installed system
2018-05-18 14:01:23 +12:00
ff0af44ee7
Merge pull request #328 from CanonicalLtd/mwhudson/fetch-ssh-keys-earlier
...
have subiquity fetch ssh keys rather than cloud-init
2018-05-18 14:00:08 +12:00
80f99deee8
use new, improved subprocess wrapper
2018-05-18 13:53:51 +12:00
8e288537cd
lint
2018-05-18 13:53:51 +12:00
368c3a9ddb
more refactoring
2018-05-18 13:53:51 +12:00
1309b68bdd
make control flow a bit more comprehensible
2018-05-18 13:53:51 +12:00
a06e07d5dd
a bit more
2018-05-18 13:53:51 +12:00
606573fa86
simplify answers handling
2018-05-18 13:53:51 +12:00
80fffc723c
some self review
2018-05-18 13:53:51 +12:00
eb0fc05682
report ssh-import-id failure, but it turns out ssh-import-id sucks
2018-05-18 13:53:51 +12:00
1033f2041f
answers support
2018-05-18 13:53:51 +12:00
9b4b86baac
show the user the key and let them accept/cancel it
2018-05-18 13:53:51 +12:00
8a63cc8506
support canceling the key fetch
2018-05-18 13:53:51 +12:00
7df7a4c1fa
fetch ssh keys in the identity screen, all a bit happy path though
2018-05-18 13:53:51 +12:00
bdf3861e5c
some simplifications
2018-05-18 13:53:51 +12:00
3d5efcaf9c
actually pass new defaults to run, oops
2018-05-18 13:53:25 +12:00
1dff40700e
Merge pull request #333 from CanonicalLtd/mwhudson/process-tweaks
...
make the wrapper we have around subprocess functions thinner
2018-05-18 13:45:30 +12:00
1e4992a5e7
stop testing on xenial, we depend on python 3.6 now
2018-05-18 13:38:13 +12:00
cb61144144
small tweaks
2018-05-18 13:21:38 +12:00
488802fc8b
update users of run_command (i thought there was more than this)
2018-05-18 13:11:15 +12:00
c6468982ae
Thin the wrappers around subprocess functions
...
Some of this stuff is not needed with modern Python.
Breaks everything of course, updates to follow.
2018-05-18 13:00:43 +12:00
0e921be3be
Merge pull request #332 from CanonicalLtd/mwhudson/run_in_bg-callback
...
run_in_bg tweaks
2018-05-18 12:39:10 +12:00
35c08f1d6f
up thread pool limit
...
otherwise we can only do one thing at once! many of the things
we do in the background do not really require an OS thread but oh well
2018-05-18 12:33:25 +12:00
ad9f10a9ac
try to ensure that functions run in the background have "_bg_" in their name
2018-05-18 12:29:42 +12:00
1efa265fc5
remove calls to set_alarm_in that were only there so that exceptions raised would be propagated
2018-05-18 12:25:47 +12:00
03392a208d
stop swallowing exceptions raised by the callback passed to run_in_bg
...
it is just more confusing that it is worth, especially when doing
development
2018-05-18 12:17:18 +12:00
bc017701f3
Merge pull request #331 from FooBarQuaxx/patch-2
...
set right name for log object
2018-05-18 10:54:53 +12:00
ad16727634
set right name for log object
2018-05-18 00:29:38 +02:00
Ryan Harper