- With 'prefill' working, calling Powershell to find Windows locale
is not required anymore.
- Since `f21986be` subiquity's default locale controller respects
mode.selected_language initialization.
- Init method changed to accept that data, which could be None.
- If valid, user Identity and Locale are prepopulated.
- Server parses the YAML and send valid info (or None) to the Model.
- This is just a preparation for a feature which affects system_setup.
- The proposed change enables locale controller to respect the model
selected_language if initialized before LocaleController.start().
- This will be used in the feature which will allow prefilling
installation UI screens during WSL installation with information
acquired from Windows environment.
Fix several warnings of the form:
subiquity/common/errorreport.py:83
DeprecationWarning: The usage of `cmp` is deprecated and will be
removed on or after 2021-06-01.
Please use `eq` and `order` instead.
See https://www.attrs.org/en/stable/changelog.html?highlight=cmp#id76
Minimum version needed for this is 19.2.0 of attrs, and focal has 19.3.
Fix warning:
subiquity/common/api/tests/test_server.py:45
PytestCollectionWarning: cannot collect test class
'TestControllerBase' because it has a __init__ constructor
Fix warning:
subiquitycore/tests/test_view.py:24
subiquity/subiquitycore/tests/test_view.py:24:
PytestCollectionWarning: cannot collect test class 'TestStretchy'
because it has a __init__ constructor
If no disk found was large enough for guided autoinstall, catch that
case and report it. Without this, we get a rather unhelpful error:
FAIL: 'NoneType' object has no attribute 'grub_device'
Leave current grub_device on Partiton and change nothing about it.
Add boot as an intended replacement for grub_device usage which is an
all-in-one check for the partition being the correct type of boot
partition, of which grub_device is just one scenario.
As reported in https://bugs.launchpad.net/snapd/+bug/1946656,
not-quite idle connections between subiquity and snapd are piling up and
causing issues when trying to restart subiquity. I don't really
understand why, but using a fresh session for each API access makes the
problem go away.
Moving the socket to a tempdir solves several problems
* helps enable parallel testing
* doesn't conflict with locally running real server instance
* a test won't connect by accident to an old server instance