During an input error the text field will be set
with the error of the validation performed.
When a user places the cursor anywhere on that error
and begins typing it will zero out the error and let
you type without having to do any previous deleting,
backspacing, etc.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
Allow user to specify a probert machine configuration file to be
used during the installer. If presented with the config file
no probing of the host will occur.
In the case that disks don't have a size in the data collected then
they'll be marked as USED.
Add a few example machines and update the README on how to specify.
Signed-off-by: Ryan Harper <ryan.harper@canonical.com>
Using parted required root privileges since it opened the underlying device.
Instead create our own Disk model and use sysfs interface for extracting
size information.
This also clears the way for providing device data via probert input. This
means we can feed subiquity a probert dump and have it present that to
the installer UI even if we're running on a different system.
Signed-off-by: Ryan Harper <ryan.harper@canonical.com>
- Ensure we don't explode on input for partition size
- Don't append error messages to input fields as it
can DOS the input boxes.
Signed-off-by: Ryan Harper <ryan.harper@canonical.com>
Provide streaming updates to the UI during non blocking
commands. For the progress controller specifically this
is the output from curtin_wrap and subsequent curtin
execs.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
This provides us with several additional features the builtin
select() loop does not, such as:
- Chainable async actions via coroutines
- asyncio bridge
This will keep the code simpler and read more like a synchronous
application.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
Non-virtio nics get persistent names which require a 2 minute timeout
which slows the installer down. Use net.ifnames=0 in grub config to
handle non virtio nics getting persistent names until a fix arrives.
Signed-off-by: Ryan Harper <ryan.harper@canonical.com>
Don't let user pass the same mount twice. TODO is to
include an error message widget and place the error
there instead of in the mountpoint widget value.
Signed-off-by: Ryan Harper <ryan.harper@canonical.com>
- Remove the (1-4) since GPT partition doesn't have a limit
- Calculate the lastpartition value and handle the case where
we don't have any at first
Signed-off-by: Ryan Harper <ryan.harper@canonical.com>
- Remove the error when converting sizes between input and initial value
there is a rounding error in the floating point convertion when
passing values between humanize() and dehumanize().
- Fix the error when using the full size of the disk as the first
partition and not accounting for the GPT bios size
- Implement percentage used in Filesystem Views
- Consolidate on unit keywords (single char only)
- use humanize() to append the correct unit size, remove all
hard-coded sizes when fetching size
- fix bug in calculating total disk size by only asking for the
largest available partition from parted.
Signed-off-by: Ryan Harper <ryan.harper@canonical.com>
- storage config is now a dict, with "version: 1" and "config: <storage
config>"
- switched curtin branch to use to lp:curtin, because custom storage features
are now available there
Facility for non blocking async calls that provide a clean
way of handling exceptions/errors in threads without us
having to define a bunch of global exception handlers.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
The previous organization was in place to reduce the number of open
files when working on getting the demo into shape. Since we've completed
the demo revert back to our MVC model incorporating the latest changes
that were made during that time leading up to the demo.
Signed-off-by: Adam Stokes <adam.stokes@ubuntu.com>
- added apt-get update before installing packages
- install all packages at once instead of looping over them
- check for error from apt-get install
- don't try to chroot if copying resolv.conf fails
Adam Stokes