Commit Graph

2439 Commits

Author SHA1 Message Date
Michael Hudson-Doyle 7ba5bf332d add a function for iterating over dependencies of an action 2019-05-02 13:15:21 +12:00
Michael Hudson-Doyle 27c2d718c9 reword a comment that has long been out of date 2019-05-02 13:13:12 +12:00
Michael Hudson-Doyle d6ccebf9bb have answers-lvm-dmcrypt.yaml edit the vg's encryptedness off and on again 2019-05-02 13:00:42 +12:00
Michael Hudson-Doyle de515f1c1b move special handling of DM_Crypt actions from model to controller
subiquity only supports encrypting LVM vgs, which implicity wraps each
PV in a DM_Crypt action. Currently these DM_Crypt actions are created
only when the curtin config is rendered but this makes a bunch of model
code less regular. My general philosophy is that the model objects
should reflect "reality" as much as possible and the controller should
handle any lies we tell, so moving the creation/deletion of DM_Crypt
actions there feels better to me.
2019-05-02 13:00:03 +12:00
Michael Hudson-Doyle 62a7f5fbad
Merge pull request #472 from mwhudson/flag-interpretation
Flags that do not indicate a bootloader partition are ok_for_raid
2019-05-02 11:13:50 +12:00
Michael Hudson-Doyle 0873225ad6 Flags that do not indicate a bootloader partition are ok_for_raid
Existing partitions can turn up with flags like "linux" and these are
fine to put into a RAID. I also checked all the other places we inspect
flag to check they weren't being over strict and they seem fine.
2019-05-02 10:45:57 +12:00
Dimitri John Ledkov a229c6fbac
Merge pull request #471 from mwhudson/use-mdadms-names-for-raid-levels
Use the names mdadm uses for the raid levels in mdadm --detail --export
2019-05-01 13:29:27 +01:00
Michael Hudson-Doyle f79ad9f74e Use the names mdadm uses for the raid levels in mdadm --detail --export
These names are what end up in udev as MD_LEVEL and so in the probert
output and so will end up in the regenerated curtin config for a system
with an existing RAID. It makes life a little bit easier for subiquity
to use the same names too.
2019-05-01 16:17:48 +12:00
Dimitri John Ledkov 7c87c9c0d3
Merge pull request #470 from mwhudson/reorg-storage-probing
reorganize storage probing
2019-04-30 13:54:52 +01:00
Michael Hudson-Doyle 1c216ddd30 improve error text very slightly 2019-04-30 11:33:29 +12:00
Michael Hudson-Doyle 1fefbe1c74 do not show a block device scan failure until we get to filesystem screen anyway
want people to be offered the snap update
2019-04-30 11:18:53 +12:00
Dimitri John Ledkov aa3e3528db
Merge pull request #469 from mwhudson/update-probert
update probert to current tip
2019-04-29 11:26:33 +01:00
Michael Hudson-Doyle 15e54321e1 fix lint 2019-04-29 15:59:23 +12:00
Michael Hudson-Doyle 0ffcca67d5 time out an unrestricted storage probe after 5 seconds 2019-04-29 15:59:13 +12:00
Michael Hudson-Doyle 6a72b229b1 try probing for blockdev only if probing fails; report failure to user 2019-04-29 15:58:19 +12:00
Michael Hudson-Doyle e8423acd28 do storage probing in the background 2019-04-29 15:54:47 +12:00
Michael Hudson-Doyle 4be9b41a0f move storage probing from model to controller 2019-04-29 14:28:33 +12:00
Dimitri John Ledkov 89415fd810
Merge pull request #468 from mwhudson/lp-1825576
copy /cdrom/.disk/info to /var/log/installer/media-info
2019-04-26 14:39:22 +01:00
Michael Hudson-Doyle 85af470cec update probert to current tip 2019-04-26 16:31:01 +12:00
Michael Hudson-Doyle 443d0f3231 copy /cdrom/.disk/info to /var/log/installer/media-info
for https://bugs.launchpad.net/bugs/1825576
2019-04-26 12:38:29 +12:00
Dimitri John Ledkov 9347bb3ae7
Merge pull request #464 from mwhudson/add-design-doc
start a design document
2019-04-26 00:18:12 +01:00
Michael Hudson-Doyle e1981ecaeb a few updates 2019-04-26 10:40:04 +12:00
Dimitri John Ledkov 1b88e7d193
Merge pull request #467 from paride/ssh-install-server
SSHController: the keyword to install openssh-server is install_server
2019-04-23 10:52:24 +01:00
Paride Legovini 099e1a6c07 SSHController: the keyword to install openssh-server is install_server
LP: #1825165
2019-04-18 10:59:23 +02:00
Michael Hudson-Doyle 01653c6d18
Merge pull request #466 from mwhudson/dont-call-RefreshController.done-twice
fix race in refresh view that can lead to done being called twice
2019-04-18 13:12:13 +12:00
Michael Hudson-Doyle 9bbb6536b8 fix race in refresh view that can lead to done being called twice
The symptom of this is that the post install steps don't get run.

If you get to the refresh screen before the check for a snap update is
completed, you are shown a screen that indicates this. If the check
completes and shows no update, you are moved onto the next screen. The
problem is, this happens even if the user has already clicked the
"Continue without updating" button! This means (if the timing works out)
that the SSH screen gets skipped without its done method being called
and the postinstall steps never start because they are endlessly waiting
for the ssh config to be decided on.

Fortunately the fix is much simpler than the diagnosis: don't hang on to
the view after we stop showing it, so that when the check completes we
don't call methods on the view that can call back into the controller's
done method.

This isn't a CI only race, it could happen to a user, especially if they
require a proxy to talk to the snap store :/
2019-04-18 12:54:40 +12:00
Michael Hudson-Doyle 63fe970515
Merge pull request #465 from mwhudson/moar-next-screen-logging
add some logging around moving between screens
2019-04-18 10:28:35 +12:00
Michael Hudson-Doyle 3e8bc81190 add some logging around moving between screens
my best guess at why CI is currently hanging sometimes is that the
'next-screen' signal is being sent too often / too early.  add some
logging around this so that we will be able to confirm / deny this by
reading the logs.
2019-04-18 10:22:05 +12:00
Michael Hudson-Doyle 77139697d6 start a design document 2019-04-17 20:05:35 +12:00
Dimitri John Ledkov aacd9d5aad
Merge pull request #463 from xnox/fix-maas-region-install
MAAS Region install fails to open shared memory segment.
2019-04-16 14:04:24 +01:00
Dimitri John Ledkov ca32f07b2a
Unmount /dev/shm too. 2019-04-16 13:40:29 +01:00
Dimitri John Ledkov 9f78f379e4
MAAS Region install fails to open shared memory segment. 2019-04-16 12:49:43 +01:00
Michael Hudson-Doyle 8177657276
Merge pull request #462 from mwhudson/step_done-logging
add some logging to _step_done
2019-04-16 23:42:40 +12:00
Michael Hudson-Doyle d179fbb5bc add some logging to _step_done 2019-04-16 22:55:23 +12:00
Michael Hudson-Doyle 8be843c2a8
Merge pull request #461 from mwhudson/hostname-ffs
write hostname/hosts/machine-id earlier
2019-04-16 11:34:59 +12:00
Michael Hudson-Doyle 496c3dcb2e write hostname/hosts/machine-id earlier
cloud-init may end up writing them too late
2019-04-16 11:27:09 +12:00
Dimitri John Ledkov f1061785d2
Merge pull request #460 from xnox/machine-id
Copy machine-id into target, for it to stay the same machine.
2019-04-15 20:55:01 +01:00
Dimitri John Ledkov 5f9948f2bf
Copy machine-id into target, for it to stay the same machine. 2019-04-15 16:25:07 +01:00
Michael Hudson-Doyle 35e5ce47c9
Merge pull request #459 from mwhudson/preserve_hostname
tell cloud-init to leave /etc/hostname alone
2019-04-15 15:05:09 +12:00
Michael Hudson-Doyle bea97b4b18
Merge pull request #458 from mwhudson/copy-logs-later
copy logs to target system right at the end
2019-04-15 15:03:33 +12:00
Michael Hudson-Doyle 696f6fb929 tell cloud-init to leave /etc/hostname alone 2019-04-15 14:56:11 +12:00
Michael Hudson-Doyle d8396ea2d7 copy logs to target system right at the end 2019-04-15 14:55:41 +12:00
Michael Hudson-Doyle 861d9bc97a
Merge pull request #457 from mwhudson/mount-action-ordering
enforce that actions for mounting a parent of a path are emitted first
2019-04-15 14:12:07 +12:00
Michael Hudson-Doyle 0558265d77 enforce that actions for mounting a parent of a path are emitted first 2019-04-15 14:06:01 +12:00
Michael Hudson-Doyle 2a9cd3590b
Merge pull request #456 from mwhudson/reboot-button-tweaks
Reboot button tweaks
2019-04-15 12:44:46 +12:00
Michael Hudson-Doyle 62957efc07 fix clicking reboot when curtin itself errors 2019-04-15 12:12:10 +12:00
Michael Hudson-Doyle fd00caea10 change label of reboot button while upgrade is running
also clean up how buttons are handled on final view in general
2019-04-15 12:10:15 +12:00
Michael Hudson-Doyle 7eacef3fbb
Merge pull request #455 from xnox/lock-answers
Lock answers file.
2019-04-15 10:16:36 +12:00
Michael Hudson-Doyle 17bc6a9b36
Merge pull request #453 from mwhudson/no-snaplist-oops
emit snap-config-done signal when skipping snap list
2019-04-15 10:15:00 +12:00
Michael Hudson-Doyle ee920eb496 fix lint 2019-04-15 10:07:59 +12:00