9854d5ccce
Merge remote-tracking branch 'origin/master' into mwhudson/ipv4-validation
2017-02-08 16:10:36 +13:00
f0eb2cdf70
make Color.button etc apply the corresponding focus map
...
about 1e6 times more readable
2017-02-08 15:37:18 +13:00
ebddb50483
better validation for manual network view
2017-02-08 13:18:20 +13:00
0627bfe9f4
start to add validation to manual network view
2017-02-08 13:18:20 +13:00
50b927fcc2
the start of an excessively general way of validating input
2017-02-07 14:02:07 +13:00
1a9f0dc5dd
make the mount point editing stuff into a single widget
...
and use it on "format entire disk" page
2017-02-07 10:28:56 +13:00
d372f0e306
respect _command_map
2017-02-06 22:12:38 +13:00
9b94b567d6
refactor TabCyclingListBox to resemble TabCyclingMixin
2017-02-06 22:11:04 +13:00
abbc21c5fa
simplify TabCyclingMixin a whole bunch
2017-02-06 22:05:16 +13:00
c8c468ff8e
make some names less cryptic, add license info, docstrings
2017-02-06 21:38:19 +13:00
3c5ac3140f
use new containers everywhere
2017-02-03 14:21:39 +13:00
3d2d2c79ea
custom versions of urwid containers that support tab-cycling
2017-02-03 14:19:37 +13:00
0aae936d63
remove previous tab "support"
2017-02-03 14:15:54 +13:00
6426369fcb
allow Selector to have disabled entries
2017-02-02 14:34:59 +13:00
2408dda6c7
remove references to firstboot (an old name for console-conf?)
2017-01-26 11:18:03 +13:00
8524e2bfe9
recommend some common mount points per spec
2017-01-25 16:39:28 +13:00
f00b60342c
tweak Selector to be more ascii and close on escape
2017-01-25 16:20:46 +13:00
78ca3c610f
make disable_subiquity work again
...
this makes selecting "quit installer" at the end of installation work
2017-01-25 14:38:03 +13:00
58af7dbb3b
add some arrows to dropdown widget
2017-01-20 13:19:16 +13:00
a4d6682478
simpler api for doing stuff in a background thread
2017-01-18 12:03:56 +13:00
fa95fb55ad
make callfromthread functionality more available, use it in installprogress
2017-01-18 12:02:34 +13:00
8ede2d730c
and with that, we no longer depend on tornado
2017-01-18 12:02:34 +13:00
d75cbabb61
move subiquity welcome stuff out of subiquitycore
2017-01-17 12:04:15 +13:00
e50ccb9c76
stop sharing WelcomeController
2017-01-17 11:34:32 +13:00
4e726495c3
move BaseIdentityController to become subiquity's IdentityController
2017-01-17 11:34:32 +13:00
b80145a99c
simplify some generic view code
2017-01-13 15:08:31 +13:00
9cb0c00271
remove some unused code from utils.py
2017-01-13 15:08:31 +13:00
ac7e7cd08b
remove BaseModel as it no longer does anything
2017-01-13 15:08:31 +13:00
bfba9f21b5
remove unused stuff from log.py
2017-01-13 15:08:31 +13:00
6febf16d22
clean up some silly stuff in core.py
2017-01-13 15:08:31 +13:00
17b943209e
remove subiquitycore/async.py
...
it was just a glorified global variable.
2017-01-13 15:08:31 +13:00
5c40c0eb19
remove meta.py, contains no code
2017-01-13 15:08:31 +13:00
60c6037a8a
move curtin.py from subiquitycore to subiquity
2017-01-13 15:08:31 +13:00
0caf13181e
Do not say a netdev is not configured when there is no configuration
2017-01-11 15:42:16 +13:00
ae05b66a47
rewrite Selector to work like an HTML <select> widget
...
This was way way harder than it seemed like it should be, but it seems a lot
nicer to me.
For https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1654387
2017-01-09 16:11:32 +13:00
b9a990171c
identity: don't quit after subiquity/subiquitycore identity controller, it should be able to continue to the next screen.
2016-12-22 22:16:15 -05:00
87b8dc3ccc
Support conditional 'shell=True' calls, required for top's redirection, and not supported in curtin...
2016-12-22 22:15:02 -05:00
862684efbc
Fix stop calls for subiquity service.
2016-12-22 22:12:03 -05:00
d9f60688fc
Adapt curtin_install_cmd and run_command_sync calls to API changes in run_command()...
2016-12-22 08:52:21 -05:00
df800bf8b3
fix header of WIFI config screen
...
See https://bugs.launchpad.net/bugs/1651119
2016-12-22 12:16:39 +13:00
09b8235b07
Fix displaying IPs for login view in subiquitycore.
2016-12-21 17:18:08 -05:00
87eb961586
Re-add get_configured_interfaces() for subiquity.
2016-12-20 15:42:37 -05:00
449688f9a1
Fix controller ordering and disable step for subiquity
2016-12-20 15:42:04 -05:00
01c42205f0
Fix identity controller for subiquity; correctly process done signal and displaying local user info.
2016-12-20 15:40:28 -05:00
21d3f78c9c
use a IPv6 example address on manual ipv6 screen
2016-12-15 14:17:49 +13:00
38c600528b
remove some of the ip-version-in-method-name methods
2016-12-12 15:58:41 +13:00
4de99bd41e
use the ip version as a parameter a bunch more
2016-12-12 15:54:33 +13:00
2a716df0ad
add and use NetworkConfigureIPv6InterfaceView
2016-12-12 15:45:45 +13:00
8582e2bc02
network_configure_manual_interface.py -> network_configure_ipv4_interface.py
2016-12-12 15:41:30 +13:00
be69509efa
parameterize NetworkConfigureIPv4InterfaceView
2016-12-12 15:40:07 +13:00
1efaed7648
add network model interfaces that take ip version as a parameter
2016-12-12 15:34:59 +13:00
15bb9afcc2
move identityview to subiquity
...
subiquity and console-conf do not share any view code any more
2016-11-23 09:54:36 +13:00
65daafde05
fix run_command of a non-existent command
2016-11-22 21:31:51 +13:00
bd9046ae9c
squash some more trivial uses of signals
...
And move the @view decorator and associated methods used by the network
stuff somewhere more general.
2016-11-22 16:09:51 +13:00
9ba1c8feff
get subiquity to the point where it at least starts
2016-11-21 13:32:58 +13:00
7c90a9e4da
Fix crash when an interface has more than one IP address of the same family.
2016-11-11 11:29:57 +13:00
7bef718e18
re-work logic, including having console-conf generate the file to show
2016-11-09 14:33:58 +13:00
19081d53bc
reparse netplan configs after writing config
...
'netplan apply' can re-plug network interfaces, so it looked like we
forgot how an interface had been configured
2016-11-09 12:21:06 +13:00
344b177f16
validate user input a lot more thoroughly in the static ipv4 view
2016-11-08 11:07:20 +13:00
a7bfef3646
show error message from netplan generate when it fails
2016-11-08 10:39:54 +13:00
8a44befe2a
remove UI for customizing default route, not supported by netplan
...
Yet, anyway.
2016-11-08 10:39:05 +13:00
31b21799b7
remove dependency on netifaces
2016-11-07 16:56:36 +13:00
c4fdf5cb72
allow choosing from visible networks when configuring wifi
2016-11-07 16:56:36 +13:00
cacd456a6a
Adapt to netlink event driven version of probert.
2016-11-07 16:56:32 +13:00
82b11dbd69
reorganize the network model and make the UI a bit more consistent
...
The main change here is to separate the state a network device is in and the
state we want it to be in. So it now parses the netplan config on a system as
well as probing the state of via probert.
The UI is changed to make this distintion too, and be IMO a bit more
consistent. Somewhere in this I've removed the display of whether the
probed address was found via DHCP or not, possibly that should be put
back if it doesn't make things too cluttered.
In dry-run mode, we now still write the config and feed it to netplan, but
in a way that doesn't affect the system we are running it on.
2016-11-07 15:15:46 +13:00
d48a70973e
restore escape key behaviour
2016-11-02 12:44:04 +13:00
f9de0818a8
fix C-x
2016-11-02 12:24:06 +13:00
6b99559819
oops
2016-11-02 12:14:01 +13:00
91e42e37bd
Merge branch 'master' into mwhudson/kill-some-signals
2016-11-02 12:00:47 +13:00
019b5c4b3e
make properly sure that the wifi password does not get logged
...
Two of these were properly stupid :(
LP: #1636421 (again)
2016-10-28 13:14:05 +13:00
74be6a382a
launchpad allows = in emails too
2016-10-27 09:28:52 +13:00
ef0da85568
allow + in email addresses
2016-10-27 09:24:21 +13:00
47af1de57e
remove setting of umask, redact wifi password from log file
...
The setting of umask was breaking configuring wifi :(
2016-10-26 11:02:23 +13:00
6318de27cf
make sure selecting dhcp after manual configuration clears out gateway & nameserver config
2016-10-21 08:59:34 +13:00
6d93221a43
do not add empty strings to nameservers or search_domains
2016-10-21 08:59:09 +13:00
0ef1ec679b
models/network: move nameservers rendering to the interface rather than being global
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-10-20 15:18:19 -04:00
7edcf3bcb7
UI for entering name servers/domains
2016-10-20 22:31:10 +13:00
67f2ee4cda
include nameservers in device config
2016-10-20 21:59:34 +13:00
262a7a4806
Merge pull request #172 from CanonicalLtd/mwhudson/render-gateway
...
render gateway4/gateway6 in network config
2016-10-20 13:22:25 +13:00
d594b77f28
do not write the netplan config so the world can see it
2016-10-20 12:37:19 +13:00
baf05ac5ad
render gateway4/gateway6 in network config
...
See https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1634540
2016-10-20 11:04:18 +13:00
f603207d94
remove most trivial use of signals from console-conf's flow
2016-10-11 12:48:28 +13:00
e348207597
Remove most use of signals from welcome and network views.
2016-10-10 16:47:42 +13:00
23ff9fe1e8
controllers can have signals without models now.
2016-09-29 14:52:11 +13:00
8020dd38c7
address review comments
2016-09-29 14:06:09 +13:00
0bd33b7074
fix subiquity side again
2016-09-29 12:29:21 +13:00
2f8c1aa5cf
move logic from identity/login views into identity controller
...
This was what I wanted to do before I got distracted by the other things.
2016-09-27 21:56:48 +13:00
d9095336e5
do not have controllers (or view code!!) know the order of the screens
2016-09-27 21:35:47 +13:00
2373837269
make fake network actions in dry-run mode a lot quicker
2016-09-27 20:53:17 +13:00
dad0e10912
completely separate menu -> signal and signal -> method mappings
...
and put the signal -> method mapping into the controller
this breaks the subiquity part even more than before, but it's pretty broken
already.
2016-09-27 20:53:17 +13:00
ba51edff75
models/network: don't render wifi devices that have no addresses and no DHCP.
...
Otherwise netplan, seeing the device half-rendered, also expects to set a
SSID we haven't set.
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-09-23 15:21:32 -04:00
cd2758cc90
do not override datefmt so we get seconds (and even microseconds) in the logs
2016-09-21 11:56:04 +12:00
e765538c95
address some UI comments from Mark
2016-09-20 14:13:31 +12:00
cbc6e97af7
use is_connected from probert
2016-09-19 11:27:12 +12:00
f78cae64bd
Show if a link is not connected.
...
At least as well as ip(8) does it.
2016-09-16 14:28:40 +12:00
682c81c289
Really probe (i.e. call into probert) every time we load the network screen.
...
Connected-ness of a link is something that can plausibly change over short
timescales.
2016-09-16 14:27:37 +12:00
6161967459
Merge pull request #159 from CanonicalLtd/mwhudson/lp-1623756
...
Do not write any config for a wlan device that has not been given a ESSID
2016-09-16 09:59:31 +12:00
fdd99e21f0
be more careful in BackgroundProcess.cancel
...
Someone sent me a traceback where cancel() was called before .proc was set. I
don't really understand how this happens, but there's no harm in being careful.
2016-09-15 21:35:48 +12:00
36967e2309
Do not write any config for a wlan device that has not been given a ESSID
...
See https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1623756
2016-09-15 21:30:41 +12:00
e608362b34
Merge pull request #154 from CanonicalLtd/mwhudson/wifi-ui
...
Add a basic UI for entering wifi config details.
2016-09-09 15:33:48 -04:00
d882666e2e
Merge pull request #155 from CanonicalLtd/mwhudson/fix-columns
...
fix scrolling with many interfaces
2016-09-09 14:52:43 -04:00
bfbb876855
version from PPA
2016-09-05 21:21:05 +12:00
bf827db28d
fix scrolling with many interfaces
2016-09-05 21:07:56 +12:00
313b4d86db
add a word
2016-09-05 20:17:05 +12:00
97171f6b71
improve UI a bit
2016-09-05 16:55:09 +12:00
60b4262b07
remove gratuitous delta a bit
2016-09-05 16:39:58 +12:00
f58d2aa7c0
refactor a bit
2016-09-05 16:38:26 +12:00
9451d69076
actually do something with the inputted data
2016-09-05 16:25:45 +12:00
f9668b8802
more low quality UI work
2016-09-05 15:36:59 +12:00
bf3384596e
a start a configure-wifi ui
2016-09-05 12:03:06 +12:00
0e56b0cba0
Clean up systemd jobs.
...
The main visible effect of this is that if console-conf crashes or is killed
it restarts instantly rather than 90 seconds later. It also removes the flicker
where a getty gets started and then instantly killed during startup.
2016-09-01 22:33:00 +12:00
98d5d1b8a3
Merge branch 'master' into mwhudson/config-location
2016-08-31 11:27:58 +12:00
c6b17fdf43
Overwrite the netplan config that snap firstboot creates.
2016-08-31 11:22:23 +12:00
0214912151
hide bonding UI
...
As the version of netplan we are currently using does not support it.
2016-08-31 11:16:36 +12:00
d6cf8e1bcf
prevent C-c / C-x from exiting console conf
...
I've left C-x as a way to get out in dry-run mode as that's useful for
debugging.
2016-08-31 10:58:26 +12:00
fedcb10560
add WaitForDefaultRouteTask, use it instead of networkd-wait-online
...
It polls though, sorry Mathieu!
2016-08-30 15:08:05 +12:00
fe8f99fbec
an example of how to implement a task as python
2016-08-30 14:15:46 +12:00
549c00279d
refactor network application code so that it does not assume all steps are subprocesses
2016-08-30 14:14:08 +12:00
f79c82a367
use os.makedirs with exist_ok to create log directory
...
Should fix LP: #1617236
2016-08-30 10:50:20 +12:00
806e3fb86d
do not crash when enabling DHCP on an interface with an address
...
Fixes #141
2016-08-23 13:48:47 +12:00
0a2546b3bd
do not probe network on returning from network sub-screen
...
otherwise we overwrite our settings with the probed data!
2016-08-23 12:47:55 +12:00
045f1e5159
Merge pull request #144 from CanonicalLtd/mwhudson/network-model-simplify
...
simplify network model code a bit
2016-08-23 09:48:47 +12:00
9ce7116f36
a touch more logging
2016-08-22 17:02:42 +12:00
a734e84980
refactor a bit
2016-08-22 17:02:42 +12:00
efa8ef43d2
allow configuration to be canceled
2016-08-22 17:02:42 +12:00
c658da012d
factor some stuff out into an object
...
separation of concerns still pretty strange for now
2016-08-22 17:02:42 +12:00
ef01c7d291
break run_command in two
...
and use the two halves when applying network config (to allow cancellation)
2016-08-22 17:02:42 +12:00
24347f1843
use run_command_async
2016-08-22 17:02:42 +12:00
e0a7aded85
update UI while apply network steps are running
...
as a special hack, the first time you apply changes in dry run mode it will
fail
2016-08-22 17:02:42 +12:00
7679296653
split NETDEV_IGNORED_IFACES into NETDEV_IGNORED_IFACE_NAMES and NETDEV_IGNORED_IFACE_TYPES
2016-08-22 16:06:35 +12:00
aef546b8f0
make Networkdev devices eagerly
...
the flow is that get_all_interface_names is always called immediately after
probe_network, so being lazy does not save anything.
2016-08-19 11:34:46 +12:00
f8db1314ad
simplify get_all_interfaces
2016-08-19 11:21:19 +12:00
bcfce74a12
kill off NetworkModel.network_devices
...
it is redundant with .info
2016-08-19 11:18:08 +12:00
e02a4c8d55
Use netplan apply instead of restarting networkd ourselves.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-08-18 16:17:22 -04:00
958ab1a339
Show decent error messages on failure.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-08-18 16:15:28 -04:00
9751b1a6b3
be more careful about checking exit statuses
2016-08-17 20:44:59 +12:00
ade3c8b93d
Only render dhcp if set to True
2016-08-16 22:23:39 -04:00
0c8deeece4
Update padding sizes for prettier output; account for future translations.
2016-08-16 22:15:41 -04:00
0e93ab3e61
Check we're online, display network error otherwise.
2016-08-16 15:25:58 -04:00
0e92883a83
Make it a little more obvious where labels are in fact buttons or menus
2016-08-16 15:01:51 -04:00
410ddf74d7
Drop 'match' for yaml rendering: it's unnecessary while we don't provide a way to rename interfaces.
2016-08-16 14:32:23 -04:00
10d06a73e4
Allow clearing IP configuration
2016-08-16 14:14:25 -04:00
682181ae62
We shouldn't render empty bits; also add rendering for IPv6 default route
2016-08-16 12:59:52 -04:00
11782ced12
Improve handling of the default routes.
2016-08-16 12:59:19 -04:00
df5e0fcb4c
Try to do something sane to set a default gateway
2016-08-16 01:09:28 -04:00
cac89c30e9
Do bonding, dhcp toggle, and segregate IPv4 and IPv6 again.
2016-08-16 00:48:15 -04:00
0f82a12208
Allow setting IPs and rendering as yaml
2016-08-15 17:05:19 -04:00
18c7e93cc2
WIP: Remove actions, port to an approximation of network yaml v2.
2016-08-13 00:13:22 -04:00
1980c4e483
fake-merge mwhudson/network
2016-08-12 22:31:31 -04:00
d73ef34774
Display IPv6 addresses.
2016-08-12 17:55:03 -04:00
6754a15c93
Allow more than one IPv4 address on an interface, and leave room for IPv6.
2016-08-09 15:11:02 -04:00
377bb841be
move netconfig into console_conf
2016-08-09 11:03:10 +12:00
5e3f808b36
some kind of NetworkConfig.from_probe_data
...
it's mostly lies but it'll do for now.
2016-08-09 11:03:10 +12:00
553cb3b8da
sketches
2016-08-09 11:03:10 +12:00
070a96bcc4
Write stamp file and logs to somewhere more sensible.
2016-08-05 14:41:50 +12:00
046d3774ba
Revert "Temporary unbreak, but nerf the user logins with email address."
...
This reverts commit 89c9e70501
2016-07-28 20:51:48 -04:00
89c9e70501
Temporary unbreak, but nerf the user logins with email address.
2016-07-28 20:40:14 -04:00
e4d5c7fa85
stuff
2016-07-28 11:13:19 +12:00
95dc9664e5
Start at a login view.
2016-07-28 10:30:27 +12:00
1c7fbac977
Update paths to /writable for snappy
2016-07-27 22:16:26 +12:00
ec5f94bf7d
entirely custom identity view for console-conf
2016-07-27 22:15:22 +12:00
ac06f25abd
Refactor identity stuff to avoid dep on curtin in console-conf case.
...
A bit verbose perhaps, but works. Now console-conf only depends on curtin for
the network stuff.
2016-07-27 16:05:47 +12:00
bf1e280276
Make create_user resilient to e.g. spaces in the password.
2016-07-27 15:24:44 +12:00
dc11c6a27c
Move function for creating a user to its own file.
2016-07-27 14:52:16 +12:00
d9f596c994
Move disk and install things from subiquitycore to subiquity.
2016-07-26 16:00:36 +12:00
2c749d944c
Have console-conf and subiquity check differing environments.
...
This means that console-conf no longer needs to have hdparm installed.
I'm not sure console-conf needs to call this at all TBH.
2016-07-26 15:09:44 +12:00
04a6d88ffe
rename ViewPolicy to BaseView
2016-07-26 14:21:24 +12:00
809034728c
rename ModelPolicy to BaseModel
2016-07-26 14:20:10 +12:00
f027382877
rename ControllerPolicy to BaseController
2016-07-26 14:17:30 +12:00
264f698299
Fix flake8 warnings in subiquitycore.
...
Except for line length warnings, because life is too short of that.
A few of these are real bugs.
2016-07-25 14:44:51 +12:00
e95daf25ba
Re-introduce 'subiquity' package for installer specific things.
...
Only move the Application object for now.
2016-07-25 12:51:39 +12:00
173fdcb77f
rename subiquitycore.core.Controller to Application
...
Also CoreControllerError -> ApplicationError
2016-07-25 12:38:19 +12:00
8e6ff11fb7
curtin: note the need for --extrausers on snappy.
2016-07-09 13:07:52 -04:00
6235ae789e
Revert "XXX: adduser with extrausers database"
...
This is more meant for console-conf on snappy; doesn't quite apply
to standard subiquity.
This reverts commit 4695735d79
2016-07-09 13:05:26 -04:00
4695735d79
XXX: adduser with extrausers database
2016-07-09 13:04:42 -04:00
1d8c5b3cdb
Deal with the fact there may be no default route for an IP family.
2016-07-06 18:30:43 -04:00
0205423133
Do a slightly better job at showing default gateways.
2016-07-06 18:14:13 -04:00
73d73dff94
NetworkView: rework layout for network info based on review.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 17:24:31 -04:00
be0457f9ea
Don't filter logs at all.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 14:51:46 -04:00
f6bb666c4d
Simplify defining core with only the general flow.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 14:50:21 -04:00
e85859fa62
WelcomeView: update UI to Mark's review: welcome string and button caption
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 14:35:19 -04:00
848ccabc7d
console_conf: start initial console-conf tree with a custom controller story
...
And a custom Welcome screen to boot; to show the overriding of settings.
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 14:18:54 -04:00
e1970b6477
Rename subiquity to subiquitycore -- will serve as base classes for everything
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 14:17:01 -04:00
Michael Hudson-Doyle