Commit Graph

7 Commits

Author SHA1 Message Date
Jinming Wu, Patrick d217db86a2 Revert "system_setup: identity tui validation fix"
This reverts commit 2f3dc90b7e.
2021-08-31 15:52:03 +02:00
Jinming Wu, Patrick aff93e5cda system_setup: PEP8 linting fixes 2021-08-31 15:52:03 +02:00
Didier Roche 1e52ab6374 Use inheritance for IdentityForm
The previous composition version had some flaws due to multiple
instances of a given Field with different addresses when reinstalled in
the parent class. This caused the field validation validate_ to not work
as it was not taken the expected referenced values.

Instead of duplicating the code, we use an inherited version, taking and
overriding only our desired fields.

We still need to derive WSLIdentityView from the base class instead of
IdentityView, as this is what is instantiating the form.
(WSLIdentityForm instead of IdentityForm).

Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
2021-08-31 15:52:03 +02:00
Didier Roche 74e5c47c25 Revert "system_setup: identity tui validation fix"
This reverts commit 2f3dc90b7e.
2021-08-31 15:52:03 +02:00
Jinming Wu, Patrick 9745fcc05f system_setup: identity tui validation fix 2021-08-31 15:52:03 +02:00
Jinming Wu, Patrick 6cbe3e8a36 Generic Fixes 2021-08-31 15:52:03 +02:00
Didier Roche d8e0026df5 WSL identity controller and view
This controller and view inherits from the subiquity identity, but
remove the "hostname" field. We are using composition over inheritance
for identityController as the UI builder is basing on the order of
declared elements as class variable and we can’t override that in the
metaclass when inheriting.
2021-08-31 15:52:03 +02:00