Michael Hudson-Doyle
47af1de57e
remove setting of umask, redact wifi password from log file
...
The setting of umask was breaking configuring wifi :(
2016-10-26 11:02:23 +13:00
Michael Hudson-Doyle
6318de27cf
make sure selecting dhcp after manual configuration clears out gateway & nameserver config
2016-10-21 08:59:34 +13:00
Michael Hudson-Doyle
6d93221a43
do not add empty strings to nameservers or search_domains
2016-10-21 08:59:09 +13:00
Mathieu Trudel-Lapierre
0ef1ec679b
models/network: move nameservers rendering to the interface rather than being global
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-10-20 15:18:19 -04:00
Michael Hudson-Doyle
7edcf3bcb7
UI for entering name servers/domains
2016-10-20 22:31:10 +13:00
Michael Hudson-Doyle
67f2ee4cda
include nameservers in device config
2016-10-20 21:59:34 +13:00
Michael Hudson-Doyle
262a7a4806
Merge pull request #172 from CanonicalLtd/mwhudson/render-gateway
...
render gateway4/gateway6 in network config
2016-10-20 13:22:25 +13:00
Michael Hudson-Doyle
d594b77f28
do not write the netplan config so the world can see it
2016-10-20 12:37:19 +13:00
Michael Hudson-Doyle
baf05ac5ad
render gateway4/gateway6 in network config
...
See https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1634540
2016-10-20 11:04:18 +13:00
Michael Hudson-Doyle
f603207d94
remove most trivial use of signals from console-conf's flow
2016-10-11 12:48:28 +13:00
Michael Hudson-Doyle
e348207597
Remove most use of signals from welcome and network views.
2016-10-10 16:47:42 +13:00
Michael Hudson-Doyle
23ff9fe1e8
controllers can have signals without models now.
2016-09-29 14:52:11 +13:00
Michael Hudson-Doyle
8020dd38c7
address review comments
2016-09-29 14:06:09 +13:00
Michael Hudson-Doyle
0bd33b7074
fix subiquity side again
2016-09-29 12:29:21 +13:00
Michael Hudson-Doyle
2f8c1aa5cf
move logic from identity/login views into identity controller
...
This was what I wanted to do before I got distracted by the other things.
2016-09-27 21:56:48 +13:00
Michael Hudson-Doyle
d9095336e5
do not have controllers (or view code!!) know the order of the screens
2016-09-27 21:35:47 +13:00
Michael Hudson-Doyle
2373837269
make fake network actions in dry-run mode a lot quicker
2016-09-27 20:53:17 +13:00
Michael Hudson-Doyle
dad0e10912
completely separate menu -> signal and signal -> method mappings
...
and put the signal -> method mapping into the controller
this breaks the subiquity part even more than before, but it's pretty broken
already.
2016-09-27 20:53:17 +13:00
Mathieu Trudel-Lapierre
ba51edff75
models/network: don't render wifi devices that have no addresses and no DHCP.
...
Otherwise netplan, seeing the device half-rendered, also expects to set a
SSID we haven't set.
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-09-23 15:21:32 -04:00
Michael Hudson-Doyle
cd2758cc90
do not override datefmt so we get seconds (and even microseconds) in the logs
2016-09-21 11:56:04 +12:00
Michael Hudson-Doyle
e765538c95
address some UI comments from Mark
2016-09-20 14:13:31 +12:00
Michael Hudson-Doyle
cbc6e97af7
use is_connected from probert
2016-09-19 11:27:12 +12:00
Michael Hudson-Doyle
f78cae64bd
Show if a link is not connected.
...
At least as well as ip(8) does it.
2016-09-16 14:28:40 +12:00
Michael Hudson-Doyle
682c81c289
Really probe (i.e. call into probert) every time we load the network screen.
...
Connected-ness of a link is something that can plausibly change over short
timescales.
2016-09-16 14:27:37 +12:00
Michael Hudson-Doyle
6161967459
Merge pull request #159 from CanonicalLtd/mwhudson/lp-1623756
...
Do not write any config for a wlan device that has not been given a ESSID
2016-09-16 09:59:31 +12:00
Michael Hudson-Doyle
fdd99e21f0
be more careful in BackgroundProcess.cancel
...
Someone sent me a traceback where cancel() was called before .proc was set. I
don't really understand how this happens, but there's no harm in being careful.
2016-09-15 21:35:48 +12:00
Michael Hudson-Doyle
36967e2309
Do not write any config for a wlan device that has not been given a ESSID
...
See https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1623756
2016-09-15 21:30:41 +12:00
Mathieu Trudel-Lapierre
e608362b34
Merge pull request #154 from CanonicalLtd/mwhudson/wifi-ui
...
Add a basic UI for entering wifi config details.
2016-09-09 15:33:48 -04:00
Mathieu Trudel-Lapierre
d882666e2e
Merge pull request #155 from CanonicalLtd/mwhudson/fix-columns
...
fix scrolling with many interfaces
2016-09-09 14:52:43 -04:00
Michael Hudson-Doyle
bfbb876855
version from PPA
2016-09-05 21:21:05 +12:00
Michael Hudson-Doyle
bf827db28d
fix scrolling with many interfaces
2016-09-05 21:07:56 +12:00
Michael Hudson-Doyle
313b4d86db
add a word
2016-09-05 20:17:05 +12:00
Michael Hudson-Doyle
97171f6b71
improve UI a bit
2016-09-05 16:55:09 +12:00
Michael Hudson-Doyle
60b4262b07
remove gratuitous delta a bit
2016-09-05 16:39:58 +12:00
Michael Hudson-Doyle
f58d2aa7c0
refactor a bit
2016-09-05 16:38:26 +12:00
Michael Hudson-Doyle
9451d69076
actually do something with the inputted data
2016-09-05 16:25:45 +12:00
Michael Hudson-Doyle
f9668b8802
more low quality UI work
2016-09-05 15:36:59 +12:00
Michael Hudson-Doyle
bf3384596e
a start a configure-wifi ui
2016-09-05 12:03:06 +12:00
Michael Hudson-Doyle
0e56b0cba0
Clean up systemd jobs.
...
The main visible effect of this is that if console-conf crashes or is killed
it restarts instantly rather than 90 seconds later. It also removes the flicker
where a getty gets started and then instantly killed during startup.
2016-09-01 22:33:00 +12:00
Michael Hudson-Doyle
98d5d1b8a3
Merge branch 'master' into mwhudson/config-location
2016-08-31 11:27:58 +12:00
Michael Hudson-Doyle
c6b17fdf43
Overwrite the netplan config that snap firstboot creates.
2016-08-31 11:22:23 +12:00
Michael Hudson-Doyle
0214912151
hide bonding UI
...
As the version of netplan we are currently using does not support it.
2016-08-31 11:16:36 +12:00
Michael Hudson-Doyle
d6cf8e1bcf
prevent C-c / C-x from exiting console conf
...
I've left C-x as a way to get out in dry-run mode as that's useful for
debugging.
2016-08-31 10:58:26 +12:00
Michael Hudson-Doyle
fedcb10560
add WaitForDefaultRouteTask, use it instead of networkd-wait-online
...
It polls though, sorry Mathieu!
2016-08-30 15:08:05 +12:00
Michael Hudson-Doyle
fe8f99fbec
an example of how to implement a task as python
2016-08-30 14:15:46 +12:00
Michael Hudson-Doyle
549c00279d
refactor network application code so that it does not assume all steps are subprocesses
2016-08-30 14:14:08 +12:00
Michael Hudson-Doyle
f79c82a367
use os.makedirs with exist_ok to create log directory
...
Should fix LP: #1617236
2016-08-30 10:50:20 +12:00
Michael Hudson-Doyle
806e3fb86d
do not crash when enabling DHCP on an interface with an address
...
Fixes #141
2016-08-23 13:48:47 +12:00
Michael Hudson-Doyle
0a2546b3bd
do not probe network on returning from network sub-screen
...
otherwise we overwrite our settings with the probed data!
2016-08-23 12:47:55 +12:00
Michael Hudson-Doyle
045f1e5159
Merge pull request #144 from CanonicalLtd/mwhudson/network-model-simplify
...
simplify network model code a bit
2016-08-23 09:48:47 +12:00
Michael Hudson-Doyle
9ce7116f36
a touch more logging
2016-08-22 17:02:42 +12:00
Michael Hudson-Doyle
a734e84980
refactor a bit
2016-08-22 17:02:42 +12:00
Michael Hudson-Doyle
efa8ef43d2
allow configuration to be canceled
2016-08-22 17:02:42 +12:00
Michael Hudson-Doyle
c658da012d
factor some stuff out into an object
...
separation of concerns still pretty strange for now
2016-08-22 17:02:42 +12:00
Michael Hudson-Doyle
ef01c7d291
break run_command in two
...
and use the two halves when applying network config (to allow cancellation)
2016-08-22 17:02:42 +12:00
Michael Hudson-Doyle
24347f1843
use run_command_async
2016-08-22 17:02:42 +12:00
Michael Hudson-Doyle
e0a7aded85
update UI while apply network steps are running
...
as a special hack, the first time you apply changes in dry run mode it will
fail
2016-08-22 17:02:42 +12:00
Michael Hudson-Doyle
7679296653
split NETDEV_IGNORED_IFACES into NETDEV_IGNORED_IFACE_NAMES and NETDEV_IGNORED_IFACE_TYPES
2016-08-22 16:06:35 +12:00
Michael Hudson-Doyle
aef546b8f0
make Networkdev devices eagerly
...
the flow is that get_all_interface_names is always called immediately after
probe_network, so being lazy does not save anything.
2016-08-19 11:34:46 +12:00
Michael Hudson-Doyle
f8db1314ad
simplify get_all_interfaces
2016-08-19 11:21:19 +12:00
Michael Hudson-Doyle
bcfce74a12
kill off NetworkModel.network_devices
...
it is redundant with .info
2016-08-19 11:18:08 +12:00
Mathieu Trudel-Lapierre
e02a4c8d55
Use netplan apply instead of restarting networkd ourselves.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-08-18 16:17:22 -04:00
Mathieu Trudel-Lapierre
958ab1a339
Show decent error messages on failure.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-08-18 16:15:28 -04:00
Michael Hudson-Doyle
9751b1a6b3
be more careful about checking exit statuses
2016-08-17 20:44:59 +12:00
Mathieu Trudel-Lapierre
ade3c8b93d
Only render dhcp if set to True
2016-08-16 22:23:39 -04:00
Mathieu Trudel-Lapierre
0c8deeece4
Update padding sizes for prettier output; account for future translations.
2016-08-16 22:15:41 -04:00
Mathieu Trudel-Lapierre
0e93ab3e61
Check we're online, display network error otherwise.
2016-08-16 15:25:58 -04:00
Mathieu Trudel-Lapierre
0e92883a83
Make it a little more obvious where labels are in fact buttons or menus
2016-08-16 15:01:51 -04:00
Mathieu Trudel-Lapierre
410ddf74d7
Drop 'match' for yaml rendering: it's unnecessary while we don't provide a way to rename interfaces.
2016-08-16 14:32:23 -04:00
Mathieu Trudel-Lapierre
10d06a73e4
Allow clearing IP configuration
2016-08-16 14:14:25 -04:00
Mathieu Trudel-Lapierre
682181ae62
We shouldn't render empty bits; also add rendering for IPv6 default route
2016-08-16 12:59:52 -04:00
Mathieu Trudel-Lapierre
11782ced12
Improve handling of the default routes.
2016-08-16 12:59:19 -04:00
Mathieu Trudel-Lapierre
df5e0fcb4c
Try to do something sane to set a default gateway
2016-08-16 01:09:28 -04:00
Mathieu Trudel-Lapierre
cac89c30e9
Do bonding, dhcp toggle, and segregate IPv4 and IPv6 again.
2016-08-16 00:48:15 -04:00
Mathieu Trudel-Lapierre
0f82a12208
Allow setting IPs and rendering as yaml
2016-08-15 17:05:19 -04:00
Mathieu Trudel-Lapierre
18c7e93cc2
WIP: Remove actions, port to an approximation of network yaml v2.
2016-08-13 00:13:22 -04:00
Mathieu Trudel-Lapierre
1980c4e483
fake-merge mwhudson/network
2016-08-12 22:31:31 -04:00
Mathieu Trudel-Lapierre
d73ef34774
Display IPv6 addresses.
2016-08-12 17:55:03 -04:00
Mathieu Trudel-Lapierre
6754a15c93
Allow more than one IPv4 address on an interface, and leave room for IPv6.
2016-08-09 15:11:02 -04:00
Michael Hudson-Doyle
377bb841be
move netconfig into console_conf
2016-08-09 11:03:10 +12:00
Michael Hudson-Doyle
5e3f808b36
some kind of NetworkConfig.from_probe_data
...
it's mostly lies but it'll do for now.
2016-08-09 11:03:10 +12:00
Michael Hudson-Doyle
553cb3b8da
sketches
2016-08-09 11:03:10 +12:00
Michael Hudson-Doyle
070a96bcc4
Write stamp file and logs to somewhere more sensible.
2016-08-05 14:41:50 +12:00
Mathieu Trudel-Lapierre
046d3774ba
Revert "Temporary unbreak, but nerf the user logins with email address."
...
This reverts commit 89c9e70501
.
2016-07-28 20:51:48 -04:00
Mathieu Trudel-Lapierre
89c9e70501
Temporary unbreak, but nerf the user logins with email address.
2016-07-28 20:40:14 -04:00
Michael Hudson-Doyle
e4d5c7fa85
stuff
2016-07-28 11:13:19 +12:00
Michael Hudson-Doyle
95dc9664e5
Start at a login view.
2016-07-28 10:30:27 +12:00
Mathieu Trudel-Lapierre
1c7fbac977
Update paths to /writable for snappy
2016-07-27 22:16:26 +12:00
Michael Hudson-Doyle
ec5f94bf7d
entirely custom identity view for console-conf
2016-07-27 22:15:22 +12:00
Michael Hudson-Doyle
ac06f25abd
Refactor identity stuff to avoid dep on curtin in console-conf case.
...
A bit verbose perhaps, but works. Now console-conf only depends on curtin for
the network stuff.
2016-07-27 16:05:47 +12:00
Michael Hudson-Doyle
bf1e280276
Make create_user resilient to e.g. spaces in the password.
2016-07-27 15:24:44 +12:00
Michael Hudson-Doyle
dc11c6a27c
Move function for creating a user to its own file.
2016-07-27 14:52:16 +12:00
Michael Hudson-Doyle
d9f596c994
Move disk and install things from subiquitycore to subiquity.
2016-07-26 16:00:36 +12:00
Michael Hudson-Doyle
2c749d944c
Have console-conf and subiquity check differing environments.
...
This means that console-conf no longer needs to have hdparm installed.
I'm not sure console-conf needs to call this at all TBH.
2016-07-26 15:09:44 +12:00
Michael Hudson-Doyle
04a6d88ffe
rename ViewPolicy to BaseView
2016-07-26 14:21:24 +12:00
Michael Hudson-Doyle
809034728c
rename ModelPolicy to BaseModel
2016-07-26 14:20:10 +12:00
Michael Hudson-Doyle
f027382877
rename ControllerPolicy to BaseController
2016-07-26 14:17:30 +12:00
Michael Hudson-Doyle
264f698299
Fix flake8 warnings in subiquitycore.
...
Except for line length warnings, because life is too short of that.
A few of these are real bugs.
2016-07-25 14:44:51 +12:00
Michael Hudson-Doyle
e95daf25ba
Re-introduce 'subiquity' package for installer specific things.
...
Only move the Application object for now.
2016-07-25 12:51:39 +12:00
Michael Hudson-Doyle
173fdcb77f
rename subiquitycore.core.Controller to Application
...
Also CoreControllerError -> ApplicationError
2016-07-25 12:38:19 +12:00