Commit Graph

4260 Commits

Author SHA1 Message Date
Michael Hudson-Doyle 8c83ad05cc simple client side ui for source selection 2021-09-13 13:23:16 +12:00
Michael Hudson-Doyle a6270cbaa1 server side implementation of source selection 2021-09-13 13:23:09 +12:00
Michael Hudson-Doyle 1c5cf3adf8
Merge pull request #1048 from dbungert/disable-autoinstall
autoinstall: skip autoinstall on empty arg
2021-09-13 12:11:24 +12:00
Michael Hudson-Doyle 93e157904e
Merge pull request #1034 from mwhudson/curtin-update
update curtin
2021-09-13 12:09:31 +12:00
Dan Bungert 0257e90052 autoinstall: skip autoinstall on empty arg
If autoinstall is set on the command line, don't override that with a
pre-baked file or from cloud-init.  The intent here is to allow
ubuntu-desktop-installer to temporarily say --autoinstall="" to disable
autoinstall until UI support for autoinstall is in place.
2021-09-10 10:40:01 -06:00
Dan Bungert 6b1700bd47 actions: +accept-existing-contributors for CLA
Canonical employees who have not signed the CLA, and sign commits with
their ubuntu.com alias, fall into a weird gap where their commits are
covered (as employees) but there is no great way for the CLA check to
determine that.
https://github.com/canonical/subiquity/pull/1044#issuecomment-916764603
2021-09-10 07:44:06 -06:00
Didier Roche 2b3d163aa7
Merge pull request #1045 from canonical/system_setup_duplicated_fields
DE-97 - system-setup: finished removing duplicated fields
2021-09-10 12:16:11 +02:00
Jean-Baptiste Lallement 717cb5b541 system-setup: finished removing duplicated fields
There was some remaining duplicated fields in the controllers and models
between base and advanced configuration, which made the code crash.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-10 12:07:55 +02:00
Michael Hudson-Doyle 1f49f0285e
Merge pull request #1043 from dbungert/cla
actions: add cla-check
2021-09-10 12:00:45 +12:00
Dan Bungert f563ab0839 actions: add cla-check 2021-09-09 17:14:05 -06:00
Patrick Wu e661b08905 system_setup: no longer inherits 2021-09-09 16:23:47 -06:00
Patrick Wu 43497a99cb system setup: reduce WSLConfigurationAdvanced size
by inheriting WSLConfigurationBase
2021-09-09 16:23:47 -06:00
Dan Bungert 9c47505ae0 types: create server/types for InstallerChannels 2021-09-08 18:33:57 -06:00
Dan Bungert a005418cde pubsub: split channels into two classes 2021-09-08 18:33:57 -06:00
Dan Bungert bc8fda47f6 EventCallback: remove 2021-09-08 18:33:57 -06:00
Dan Bungert 3a69683128 geoip: switch to MessageHub 2021-09-08 18:33:57 -06:00
Dan Bungert 44a68062d0 mirror: prep for conversion from Event -> Message
MessageHub isn't sending a changed value, so lookup the value another
way.  Helps to prep for removing the usage of EventCallback.
2021-09-08 18:33:57 -06:00
Dan Bungert fc95c72f35 pubsub: Add unit test for MessageHub
Also minor cleanup on the soon-to-be-removed EventCallback test to help
demonostrate that some of this code isn't needed.
2021-09-08 18:33:57 -06:00
Dan Bungert 0ea8139f32 MessageHub: Switch to using enum constants 2021-09-08 18:33:57 -06:00
Michael Hudson-Doyle 221f7f98f0
Merge pull request #1038 from canonical/wsl_oobe
OOBE and configuration for WSL
2021-09-06 20:23:14 +12:00
Jean-Baptiste Lallement b47362ea2a Fixed linting
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 10:18:18 +02:00
Jean-Baptiste Lallement 2585ab0ce2 Remove uneeded controller unloading
This was a leftover from where we were loading them unconditionally

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 10:11:35 +02:00
Jean-Baptiste Lallement 0a590e2c10 Helper for timedatectl detection
This is done now at running time.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 10:02:23 +02:00
Jean-Baptiste Lallement 46eb52c9cb Split system_identity controller from subiquity one
There is little inherited from it, let’s split them.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 09:52:23 +02:00
Jean-Baptiste Lallement 039201949d Remove uneeded confirmation handling in system_setup
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 09:52:08 +02:00
Jean-Baptiste Lallement ea29709573 Fix typo and punctuation
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 09:45:37 +02:00
Jean-Baptiste Lallement 3cdaf76153 Mark as TODO adding a helper for future refactoring
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 09:44:51 +02:00
Jean-Baptiste Lallement 2a36e30812 Remove set conversion and explicitely init it
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 09:39:32 +02:00
Jean-Baptiste Lallement 4c83e4afde Remove duplication in server execution code
Make command line and dry-run command line a class member.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 09:38:50 +02:00
Jean-Baptiste Lallement ef9d387b4f Removed unused function
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-03 09:08:44 +02:00
Jean-Baptiste Lallement ab161250e1 Removed the progress view.
On non systemd systems (ie WSL) the progress view is always empty. Thus
this view is removed and the summary (formerly overview) view becomes
the last page of the setup with the reboot button. This button is
displayed dynamically when setup is complete.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 19:06:50 +02:00
Jean-Baptiste Lallement 15664d9016 Do not log to journald on non-systemd systems.
Some systems like WSL do not support systemd and we cannot rely on
journald for logging. Thus we remove the progress controller that would
always be blank.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 19:03:52 +02:00
Jean-Baptiste Lallement dadbb55fd2 Fix controller removal
Properly remove unsupported controllers.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 19:02:55 +02:00
Jean-Baptiste Lallement 5b2e78a8a1 Ensure we always exit the server
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 17:42:19 +02:00
Jean-Baptiste Lallement 805a84ab76 Linter fixes
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 11:02:25 +02:00
Jean-Baptiste Lallement 5d318b2fbb Rebase on new subiquity model.
Variants are set at the application level and impact the models.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 10:55:06 +02:00
Jean-Baptiste Lallement 3eb5231fca Only proceed for installation when ready.
Wait for models to be configured before proceeding with installation.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 10:48:44 +02:00
Jean-Baptiste Lallement a60da3e589 Support empty post_install model list
The signal telling postinstall was configured was never sent.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 10:47:24 +02:00
Jean-Baptiste Lallement 1f4a9ab6f3 Support empty default model names
When the list of model names is empty it was implicitly casted to a dict
but a set() was required for concatenation.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 10:45:32 +02:00
Jean-Baptiste Lallement da5c83d4f1 Set supported and current variant for WSL
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 10:44:37 +02:00
Jean-Baptiste Lallement 1556163d87 Make variants configurable
Current variant and supported one were hardcoded and not extensible.
This makes it configurable per application.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-01 10:43:51 +02:00
Jean-Baptiste Lallement 9b67591335 More linting fixes
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-08-31 15:56:08 +02:00
Jean-Baptiste Lallement 3044a1fc11 Update answer file with renamed controllers
WSL configuration controllers have been renamed, the answer file must be
updated accordingly

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-08-31 15:52:03 +02:00
Jean-Baptiste Lallement dcab9c2e6e Removal of --reconfigure for server
Load all the server controller independently whether it is in first
configuration or reconfiguration mode.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-08-31 15:52:03 +02:00
Jean-Baptiste Lallement 518cff3d3b Fixed linting 2021-08-31 15:52:03 +02:00
Jean-Baptiste Lallement ba6ce20d64 Do not use a file to share user name
Instead retrieve it from the server and store it in memory.
2021-08-31 15:52:03 +02:00
Jean-Baptiste Lallement 41945cb84c Renamed configuration pages
In order to make naming more explicit renamed wslconf1 to wslconfbase
and wslconf2 to wslconfadvanced.
2021-08-31 15:52:03 +02:00
Jean-Baptiste Lallement 57a2212c7b List of TODOs
This is the list of identified TODOs for the OOBE.
2021-08-31 15:52:03 +02:00
Jean-Baptiste Lallement b0299f255f Added integration test for WSL
This tests covers the configuration of WSL on first boot.
2021-08-31 15:52:03 +02:00
Jean-Baptiste Lallement f41f44e9d6 Misc cleanups
* Rename/add debug with correct naming
* Remove uneeded and unused hostname in identity
* Add automatic answer support to overview
2021-08-31 15:52:03 +02:00