Commit Graph

4720 Commits

Author SHA1 Message Date
Olivier Gayot 2f9c7399ca Compare the snaps versions to avoid suggesting a downgrade
In specific scenarios, the version of the snap as returned by snapd is
older than the version currently running. When that happens, we were
suggesting the user to update. This action would effectively result in a
downgrade.

We now attempt to determine if the snapd version is greater than the one
currently running. If we can't the behavior is unaffected.

Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
2021-12-01 20:01:09 +01:00
Dan Bungert b0167af6e7 make: api depend on gitdeps 2021-12-01 11:55:44 -07:00
Carlos Nihelton 22a8219cb3 Dryrun won't stop configure controller due C-L-S
- Also noticed a possible unbound var in IOError handler.
2021-11-24 11:35:31 -03:00
Dan Bungert cde7150446
Merge pull request #1058 from dbungert/fr-1187-apt-components-v2
apt: disable_components
2021-11-23 11:12:24 -07:00
Dan Bungert 1b74779aef api: add free_only 2021-11-23 10:57:47 -07:00
Dan Bungert e32b7f28ac mirror: add disable_components API 2021-11-23 10:56:43 -07:00
Dan Bungert c332d62e40
Merge pull request #1130 from dbungert/curtin-rev-lsblk
snapcraft: pickup curtin lsblk fix
2021-11-22 16:55:34 -07:00
Dan Bungert dc87d8075e
Merge pull request #1126 from dbungert/apitest-less-flaky
Make api tests less flaky
2021-11-22 16:55:14 -07:00
Dan Bungert e1e5013ad5 mirror: s/is_default/mirror_is_default
Clarify that the mirror is the default, as there are other things under
mirror that are not relevant to this determination.
2021-11-22 15:07:39 -07:00
Carlos Nihelton a88fcdb8b3 Explicit case for c-l-s failure by returning None 2021-11-22 13:42:45 -03:00
Carlos Nihelton 37758047f2 Improved control over lang packs on integration
- Dryrun should never return empty packages list unless under failure.
- runtests check if the mimic-installed files match the proper language.
2021-11-22 12:16:01 -03:00
Michael Hudson-Doyle 200ceb1d58
Merge pull request #1129 from dbungert/core20-import-ssh
snapcraft: remove python links from snap bin dir
2021-11-22 11:40:57 +13:00
Dan Bungert 00c4f0c0a3 snapcraft: pickup curtin lsblk fix 2021-11-19 16:02:40 -07:00
Dan Bungert cf199fbc4d snapcraft: remove python links from snap bin dir
The python links in the bin dir of the snap were resolving to system
python instead of the python binary found at usr/bin.  This appears to
be the root cause of why python scripts would fail to find their own
resources, such as ssh-import-id and lsb_release.
2021-11-19 15:50:14 -07:00
Carlos Nihelton 1e6c4472a5 Complementary to 1127 on integration side 2021-11-17 13:26:41 -03:00
Dan Bungert 6a970ccd41
Merge pull request #1127 from dbungert/fix-cache-empty-pkg
check-language-support: fix empty pkg list
2021-11-17 07:34:03 -07:00
Dan Bungert 1eefb7a9e5 check-language-support: fix empty pkg list
The check-language-support on my machine was providing a single empty
newline as output, and the length check isn't catching that as the
resulting packages array has a value of [''].
Drop empty values from the list to avoid a "KeyError: ''" exception.
2021-11-17 07:23:16 -07:00
Michael Hudson-Doyle e9892e5032
Merge pull request #1123 from mwhudson/configure-apt-earlier
configure apt before starting install
2021-11-17 14:36:51 +13:00
Dan Bungert 9ef4e929f7 apitests: fix misuse of proc.communicate 2021-11-16 18:08:29 -07:00
Dan Bungert ee48b0990a apitests: try harder to wait for startup
Observe server state and wait longer if in one of the startup states.
2021-11-16 18:08:29 -07:00
Dan Bungert 7920c2e18b apitests: use a timeout multiplier system 2021-11-16 18:08:29 -07:00
Michael Hudson-Doyle f2e05f993d do apt configuration before install starts
via lots of overlays
2021-11-17 12:57:26 +13:00
Michael Hudson-Doyle be57dc9da0 fix offline installs 2021-11-17 11:20:18 +13:00
Michael Hudson-Doyle 996a2125f2 pass install source as an argument to curtin install, not via config 2021-11-17 10:23:32 +13:00
Didier Roche dde0a6d53c
Merge pull request #1116 from CarlosNihelton/ft-wsl-locale-deeng-31
System locale manipulation wired into Subiquity.
2021-11-16 08:43:51 +01:00
Didier Roche 072d2b233a
Merge pull request #1124 from CarlosNihelton/fix-systemsetup-reconfig-post
SystemSetupModel now acks the variant at start.
2021-11-15 09:07:13 +01:00
Didier Roche e4ef11a40e
Merge pull request #1115 from CarlosNihelton/fix-prefill-only-dryrun
Fix prefill only dryrun
2021-11-15 09:06:05 +01:00
Carlos Nihelton 377e880cb5 Style improvements. 2021-11-12 16:04:02 -03:00
Carlos Nihelton 4bb8ee3b3b SystemSetupModel now acks the variant at start.
- Without this change, wsl_configuration variant is not reckon without
  client_variant.POST.
- Issue and suggestions of fixes originally reported by jpnurmi.
2021-11-11 09:22:10 -03:00
Michael Hudson-Doyle 71b410ef4c
Merge pull request #1122 from mwhudson/configure-apt-python
implement the bulk of subiquity-configure-apt in the server process
2021-11-10 14:31:42 +13:00
Michael Hudson-Doyle c7138b783f move apt configuration into a class 2021-11-10 13:48:09 +13:00
Michael Hudson-Doyle d83d0fdce8 write curtin config to a separate location for each invocation 2021-11-10 13:47:50 +13:00
Michael Hudson-Doyle fe9caa4715
Merge pull request #1121 from CarlosNihelton/ft-test-lxd-local
Enables preserving existing container instances.
2021-11-10 12:46:04 +13:00
Carlos Nihelton a1fd0615f8 Slipped on the linter. 2021-11-09 18:34:58 -03:00
Carlos Nihelton d944d48d5a
Less likely to conflict with existing containers.
By renaming the test images with a `subiquity-` prefix.
2021-11-09 18:20:41 -03:00
Carlos Nihelton 7eee081405 Updated runtests to look for locale files 2021-11-09 18:16:10 -03:00
Carlos Nihelton 409ac4157a From weird splits into regex 2021-11-09 18:15:59 -03:00
Carlos Nihelton 63d565b89c Write text files instead of wget 2021-11-09 18:15:20 -03:00
Michael Hudson-Doyle 41664eeec3 move apt configuration to its own file 2021-11-10 09:21:34 +13:00
Michael Hudson-Doyle b951216920 implement the bulk of subiquity-configure-apt in the server process
This uses a kind of crazy approach where the hook script we get curtin
to run makes an API call to the server process to do the actual
configuration. I can't work out if this is genius or insane or both but
anyway it is only a step on to the way to doing the apt configuration
before we start curtin so it won't be around for long.
2021-11-10 09:21:34 +13:00
Michael Hudson-Doyle 71b1261731
Merge pull request #1118 from mwhudson/move-command_runner
refactor curtin invocation some more
2021-11-10 09:21:09 +13:00
Carlos Nihelton e88eb7334f Avoiding grep 2021-11-09 09:42:57 -03:00
Carlos Nihelton 4e050ecddb Style improvements. 2021-11-09 09:36:10 -03:00
Dan Bungert 6542f8629f
Merge pull request #1120 from mwhudson/kvm-test-tweaks
kvm-test: assorted updates
2021-11-08 16:55:52 -07:00
Dan Bungert e31a3c31ac kvm-test: fix slimy invocation
We can't delete the snap file created by quick-test because we don't
have the path to it.  The with statement makes no sense.
2021-11-08 16:44:35 -07:00
Carlos Nihelton 8f4a6927bb Enables preserving existing container instances.
- Useful for develop env.
- Mimics the CI while avoiding downloading images all the time.
- Instance names change from 'tester' to the Ubuntu release adjective.
- lxc will only download if there is no local instance with that name.
- Useful for preserving matrix build instances.
2021-11-08 19:20:44 -03:00
Carlos Nihelton f9d3877feb Corrected list type hint for Python 3.8.
- CI failed on Focal due Python version unable to understand list[str].
2021-11-08 19:03:10 -03:00
Carlos Nihelton eb6bd2d263 Smaller functions, early returns and funny mocking 2021-11-08 13:11:30 -03:00
Carlos Nihelton 6be4aea138 l-s-c as dep on Makefile, avoid raising exceptions
- And clear .subiquity/var/cache
2021-11-05 18:09:15 -03:00
Carlos Nihelton 5f9f2122ce System locale manipulation wired into Subiquity.
- We don't have cloud-init in WSL.
    - Subiquity must perform any actions to support the choosen locale.
    - l-s-c package added as dependency.
2021-11-05 17:29:33 -03:00