Ryan Harper
b7e60f7b91
pep8 fixes for subiquitycore.testing.view_hewlpers
2018-05-24 16:51:51 -05:00
Ryan Harper
40caacaca3
pep8 fixes for subiquitycore.models.network
2018-05-24 16:51:51 -05:00
Ryan Harper
a0bf68f3c4
pyflakes3 fixes
...
Add and enable pyflakes3 on console_conf, subiquity, subiquitycore and tests.
Replace NOQA markers with __all__ declarations for module imports.
Replace some obvious deadcode that voilates flake8, separate pass for removing
dead code rather than commenting will be handled later.
2018-05-24 16:51:51 -05:00
Michael Hudson-Doyle
bd48ed9b1d
remove SimpleList
...
and the Body widget, both utterly trivial
2018-05-25 09:35:25 +12:00
Ryan Harper
3c9b2e28c7
Drop commented out / dead code
2018-05-23 18:53:12 -05:00
Michael Hudson-Doyle
0fe1f5145c
sprinkle in some more ".base_widget"s
2018-05-23 13:40:14 +12:00
Michael Hudson-Doyle
7441cb6df6
convert ScrollBarListBox to decoration rather than subclass
...
for all the usual reasons why composition is better than inheritance,
but in particular because I want to have a listbox that has a scrollbar
but not our custom tab behaviour in another branch. decoration in urwid
is not as transparent as it sometimes seems it should be but luckily
there's only one view that does much with its listbox and it was due
for some cleanup anyway.
2018-05-23 13:14:00 +12:00
Michael Hudson-Doyle
626488e988
Merge pull request #334 from CanonicalLtd/mwhudson/move-excerpt-title-to-view
...
move excerpt, title and footer from controller to view
2018-05-22 22:38:39 +12:00
Ryan Harper
a84dd2b272
Encoding input when running commands
2018-05-21 13:35:26 -05:00
Ryan Harper
74ae9b9fde
Drop use of encoding kwarg to subprocess for python3.5 compat
2018-05-21 11:54:34 -05:00
Michael Hudson-Doyle
79208bc00b
trap a TaskSequence gotcha
2018-05-21 13:09:56 +12:00
Michael Hudson-Doyle
70ec850aad
Merge pull request #336 from CanonicalLtd/mwhudson/hack-ThreadPoolExecutor
...
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:59:12 +12:00
Michael Hudson-Doyle
384dadc5ed
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:58:10 +12:00
Michael Hudson-Doyle
f6f214125f
move TaskSequence somewhere more generic
...
I want to reuse it in my containerizing branch.
Improve API and docs a bit while I am looking at it.
2018-05-21 11:52:06 +12:00
Michael Hudson-Doyle
cbd5afe2c0
move imports of i18n higher so _ is always installed before tests are imported
2018-05-21 10:14:34 +12:00
Michael Hudson-Doyle
ac875751fb
fix installprogress
2018-05-18 16:27:05 +12:00
Michael Hudson-Doyle
11708703c9
move titles, footers, excerpts from controller to view
...
read title and footer from the view instance, make views respsonsible for rendering
the excerpt
adapts infrastructure, welcome, keyboard, network views
2018-05-18 15:55:49 +12:00
Michael Hudson-Doyle
80fffc723c
some self review
2018-05-18 13:53:51 +12:00
Michael Hudson-Doyle
7df7a4c1fa
fetch ssh keys in the identity screen, all a bit happy path though
2018-05-18 13:53:51 +12:00
Michael Hudson-Doyle
bdf3861e5c
some simplifications
2018-05-18 13:53:51 +12:00
Michael Hudson-Doyle
3d5efcaf9c
actually pass new defaults to run, oops
2018-05-18 13:53:25 +12:00
Michael Hudson-Doyle
1e4992a5e7
stop testing on xenial, we depend on python 3.6 now
2018-05-18 13:38:13 +12:00
Michael Hudson-Doyle
cb61144144
small tweaks
2018-05-18 13:21:38 +12:00
Michael Hudson-Doyle
488802fc8b
update users of run_command (i thought there was more than this)
2018-05-18 13:11:15 +12:00
Michael Hudson-Doyle
c6468982ae
Thin the wrappers around subprocess functions
...
Some of this stuff is not needed with modern Python.
Breaks everything of course, updates to follow.
2018-05-18 13:00:43 +12:00
Michael Hudson-Doyle
35c08f1d6f
up thread pool limit
...
otherwise we can only do one thing at once! many of the things
we do in the background do not really require an OS thread but oh well
2018-05-18 12:33:25 +12:00
Michael Hudson-Doyle
ad9f10a9ac
try to ensure that functions run in the background have "_bg_" in their name
2018-05-18 12:29:42 +12:00
Michael Hudson-Doyle
1efa265fc5
remove calls to set_alarm_in that were only there so that exceptions raised would be propagated
2018-05-18 12:25:47 +12:00
Michael Hudson-Doyle
03392a208d
stop swallowing exceptions raised by the callback passed to run_in_bg
...
it is just more confusing that it is worth, especially when doing
development
2018-05-18 12:17:18 +12:00
Michael Hudson-Doyle
13d7f13c42
fixes for stretchy where stretchy widget is selectable
2018-05-14 10:28:33 +12:00
Michael Hudson-Doyle
960f51ca91
remove view argument to Form.as_rows and friends
2018-05-07 10:57:35 +12:00
Michael Hudson-Doyle
0a0af0842b
fix stupid crash
2018-05-04 10:31:36 +12:00
Michael Hudson-Doyle
fa8f8d32f5
down all network links that have changed config before applying it
...
this means that if you enter a broken config, it breaks as it should
2018-05-03 12:14:06 +12:00
Michael Hudson-Doyle
92457e5724
Merge pull request #324 from CanonicalLtd/mwhudson/click-helper
...
add --click, --script arguments to subiquity-tui
2018-05-03 11:35:35 +12:00
Michael Hudson-Doyle
1ed27f1848
Merge pull request #322 from CanonicalLtd/mwhudson/no-create-user
...
stop creating the user in the live session
2018-05-01 13:01:08 +12:00
Michael Hudson-Doyle
5a6d0ac90f
a docstring
2018-05-01 13:00:27 +12:00
Michael Hudson-Doyle
acdd3bdec7
refactor a bit
2018-05-01 12:57:03 +12:00
Michael Hudson-Doyle
58d64eb419
over engineered way to delay command-line supplied script invocation
...
use this to allow click helper to wait for a button to appear
2018-05-01 12:49:39 +12:00
Michael Hudson-Doyle
db4d8a537e
add a way to specify actions to take in the UI on the command line
...
--script takes a little python snippet to run in a helpful namespace
--click is a wrapper around --script to click a button
2018-05-01 12:29:29 +12:00
Michael Hudson-Doyle
07438a1049
add support for Frames to find_with_pred in view_helpers
2018-05-01 12:17:53 +12:00
Michael Hudson-Doyle
fe671d8d9b
fix rendering of nic info if dhcp failed but has addresses of other family
...
This bug has been here forever! Oh well.
2018-04-27 14:56:30 +12:00
Michael Hudson-Doyle
dc17fcae4f
stop creating the user in the live session
...
there is no real reason to do this, and it lets me delete some code.
i also cleaned some other stuff up in the area
2018-04-27 14:16:37 +12:00
Michael Hudson-Doyle
7d704f83f0
mark even more strings as translatable
2018-04-19 13:09:00 +12:00
Michael Hudson-Doyle
78e6fea854
work around strange behaviour of _("")
2018-04-19 10:29:08 +12:00
Michael Hudson-Doyle
688a270c17
a round of marking strings as translatable and ensuring translations are actually displayed in the UI
2018-04-19 10:29:08 +12:00
Michael Hudson-Doyle
fdd3fae45a
fix crash on escape key
2018-04-19 09:57:11 +12:00
Michael Hudson-Doyle
2d3d500e34
a couple of tweaks to make more translated strings appear
2018-04-18 20:18:15 +12:00
Michael Hudson-Doyle
6396025964
Merge pull request #315 from CanonicalLtd/mwhudson/scollbar-focus
...
change scrollbar color if focused
2018-04-17 12:57:22 +12:00
Michael Hudson-Doyle
ba041718dc
Merge pull request #316 from CanonicalLtd/mwhudson/stretchy-overlay
...
add an overlay that has nicer resizing behaviour
2018-04-17 12:57:15 +12:00
Michael Hudson-Doyle
7eafa420fb
add show_stretch_overlay, simplify show_overlay
2018-04-17 12:23:11 +12:00