Commit Graph

1548 Commits

Author SHA1 Message Date
Michael Hudson-Doyle 62ac91429f give the choosing toggle dialog a title 2018-03-27 12:13:40 +13:00
Michael Hudson-Doyle c82b92dfb2 a better fix for reading complex config from files 2018-03-27 12:05:04 +13:00
Michael Hudson-Doyle 0ea6c10553 some refactoring 2018-03-27 11:55:50 +13:00
Michael Hudson-Doyle c8a15e5533 fix rendering of curtin config 2018-03-27 11:41:59 +13:00
Michael Hudson-Doyle a56ded794b read more complex settings from existing config 2018-03-27 11:31:34 +13:00
Michael Hudson-Doyle e154c93a41 create a KeyboardSetting class to contain layout, variant and any other options
and finally write the toggle choice to the config
2018-03-27 10:37:56 +13:00
Michael Hudson-Doyle 9d9c233dc4 bludgeon urwid into some kind of submissoin 2018-03-26 23:49:04 +13:00
Michael Hudson-Doyle b1ec1aa43d the rest of the UI for selecting a toggle key
the toggle key is not written to the config yet though
2018-03-26 23:13:48 +13:00
Michael Hudson-Doyle f106464169 start to address selection of non-latin layouts
1) port code from console-setup to detect a non-latin layout
2) pop up a dialog if the user chooses a non-latin layout

does not actually allow the user to configure how to switch
the layouts yet
2018-03-26 21:57:32 +13:00
Michael Hudson-Doyle 8dbb1dcda5 if there is not enough space for the boot partition, shrink the largest partition to make it fit 2018-03-26 13:43:09 +13:00
Michael Hudson-Doyle 8ced5c74f3 make partitioning form wider to allow more space for explanations
and also consistency with other views
2018-03-26 13:39:26 +13:00
Michael Hudson-Doyle 2d886ee72c be more precise when showing small amounts of disk free 2018-03-26 13:07:12 +13:00
Michael Hudson-Doyle d33f8acf1f implement moving of boot partitions between devices 2018-03-26 13:06:52 +13:00
Michael Hudson-Doyle 304267550e skeleton of a "make this disk the boot disk" ui 2018-03-26 12:57:38 +13:00
Michael Hudson-Doyle fe057166c5 move "show disk info" button closer to other inputs 2018-03-26 12:46:13 +13:00
Michael Hudson-Doyle 76467a08d8 only reduce size of initial partition if adding the boot partition means the requested size no longer fits 2018-03-26 12:25:07 +13:00
Michael Hudson-Doyle e028ca0360 add some explanatory text to the view of the boot/bios_grub partition 2018-03-26 12:22:07 +13:00
Michael Hudson-Doyle a544a66622 do not allow editing the size of the bios_grub partition 2018-03-26 12:21:50 +13:00
Michael Hudson-Doyle 9ed5de40b2
Merge pull request #302 from CanonicalLtd/mwhudson/no-partnum-in-ui
remove ability to supply partition number from the UI
2018-03-26 11:54:00 +13:00
Michael Hudson-Doyle dadfddc6a0 remove ability to supply partition number from the UI
also remove it from the curtin config.
2018-03-26 11:01:43 +13:00
Michael Hudson-Doyle 229c8880bc
Merge pull request #301 from CanonicalLtd/mwhudson/part-sizing
adjust details of partition sizing
2018-03-23 09:44:11 +13:00
Michael Hudson-Doyle b691f5548e
Merge pull request #300 from CanonicalLtd/mwhudson/swap-fun
adjust curtin config so swap partitions are actually used
2018-03-23 09:11:48 +13:00
Michael Hudson-Doyle d2a9f84b18 fix tests with slightly more realistic sizes 2018-03-22 14:27:06 +13:00
Michael Hudson-Doyle 753a7c67b3 special case the user entering the displayed "max size" string to mean the actual max size
rounding can make these marginally different
2018-03-22 14:18:00 +13:00
Michael Hudson-Doyle ef5229d037 round up partition size on edit
and complain here if the size is too big
2018-03-22 14:17:06 +13:00
Michael Hudson-Doyle e914919c61 round user input for partition sizes up to 1MiB boundaries 2018-03-22 14:16:39 +13:00
Michael Hudson-Doyle d1c431af01 round displayed hd sizes down to the nearest MiB
do not know if this makes a real difference but no real cost to being defensive
2018-03-22 14:15:36 +13:00
Michael Hudson-Doyle af67c7074c have humanize_size round down rather than up
rounding up can end up showing a free size for a disk that is larger than the
actual free size...
2018-03-22 14:14:03 +13:00
Michael Hudson-Doyle 7c6bd753af suppress the swapfile if there is an explcit swap partition 2018-03-21 23:39:20 +13:00
Michael Hudson-Doyle 0651023365 add a mount for anything formatted as swap 2018-03-21 23:27:58 +13:00
Michael Hudson-Doyle 91ba2d0602 set swap flag on a partition too 2018-03-21 23:27:51 +13:00
Michael Hudson-Doyle e61eb454cf
Merge pull request #299 from CanonicalLtd/mwhudson/disable-wifi-server
do not show wlan interfaces in server installer
2018-03-21 15:44:55 +13:00
Michael Hudson-Doyle 366d27713b remove crufty line that has a typoed variable name 2018-03-21 15:43:51 +13:00
Michael Hudson-Doyle d0da487895 avoid a strange apparmor bug/issue by invoking subiquity entrypoint directly
see https://forum.snapcraft.io/t/snapd-2-32-breaks-live-server-installer/4597 for more details
2018-03-21 15:42:55 +13:00
Michael Hudson-Doyle 56c582a0d0 the way subiquity works it is better do consider a Pile selectable if any of its elements are selectable
Without this, if a non-selectable thing ends up focused, the net effect is that
all further input is ignored, which is bad.
2018-03-21 11:18:56 +13:00
Michael Hudson-Doyle 0c071f7b0d form fields should not be validated on entry 2018-03-21 10:39:32 +13:00
Michael Hudson-Doyle b3da7266b9 do not show wlan interfaces in server installer 2018-03-21 09:35:21 +13:00
Michael Hudson-Doyle 8287d695dc fix live updates of network screen 2018-03-16 15:30:14 +13:00
Michael Hudson-Doyle 5ab28c9b98 bump version in debian/changelog 2018-03-16 15:30:08 +13:00
Michael Hudson-Doyle d9091b12dc add __init__.py to console_conf/models/ 2018-03-16 15:29:50 +13:00
Michael Hudson-Doyle a35723089d a simple script to put the edge subiquity snap into a new iso 2018-03-14 15:25:53 +13:00
Michael Hudson-Doyle dfc6627801
Merge pull request #298 from CanonicalLtd/mwhudson/design-feedback
address feedback from sprint
2018-03-14 15:00:02 +13:00
Michael Hudson-Doyle 1f937090c0 update help text for address 2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle 59a500c9e5 add more space between form rows, align help to the left 2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle 16f8bc07d0
Merge pull request #294 from CanonicalLtd/mwhudson/better-scrolling
improve scrolling experience
2018-03-14 14:58:36 +13:00
Michael Hudson-Doyle 2a1e0f1ffa
Merge pull request #297 from CanonicalLtd/mwhudson/ssh-import-rework
change how ssh import field works
2018-03-14 14:58:25 +13:00
Michael Hudson-Doyle ca953ea01f improve scrolling experience
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).

The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.

As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
Michael Hudson-Doyle 5a81c397b9
Merge pull request #295 from CanonicalLtd/mwhudson/no-swapfile-for-btrfs-root
prevent creation of a swapfile when / is btrfs
2018-03-14 14:27:01 +13:00
Michael Hudson-Doyle c57f0057f3 simplifications 2018-03-14 14:20:53 +13:00
Michael Hudson-Doyle 9ba11aedb5 change how ssh import field works
This is the only place in subiquity today where we have selectable fields side
by side, which contradicts the goal to be able to navigate subiquity with up,
down and enter keys only. Replace the existing fancy widget with two fields,
one to select the import source and one to enter the username.

Also remove the "Ubuntu SSO" option as that has never worked.
2018-03-14 14:07:03 +13:00