Michael Hudson-Doyle
a723d25a4c
create a helper to create a common screen layout
2018-04-09 14:30:59 +12:00
Michael Hudson-Doyle
0fc83c4bc1
simplify a bunch of views
...
i am slowly getting better at urwid...
2018-04-09 14:10:36 +12:00
Michael Hudson-Doyle
9d9c233dc4
bludgeon urwid into some kind of submissoin
2018-03-26 23:49:04 +13:00
Michael Hudson-Doyle
e61eb454cf
Merge pull request #299 from CanonicalLtd/mwhudson/disable-wifi-server
...
do not show wlan interfaces in server installer
2018-03-21 15:44:55 +13:00
Michael Hudson-Doyle
56c582a0d0
the way subiquity works it is better do consider a Pile selectable if any of its elements are selectable
...
Without this, if a non-selectable thing ends up focused, the net effect is that
all further input is ignored, which is bad.
2018-03-21 11:18:56 +13:00
Michael Hudson-Doyle
0c071f7b0d
form fields should not be validated on entry
2018-03-21 10:39:32 +13:00
Michael Hudson-Doyle
b3da7266b9
do not show wlan interfaces in server installer
2018-03-21 09:35:21 +13:00
Michael Hudson-Doyle
8287d695dc
fix live updates of network screen
2018-03-16 15:30:14 +13:00
Michael Hudson-Doyle
1f937090c0
update help text for address
2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle
59a500c9e5
add more space between form rows, align help to the left
2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle
ca953ea01f
improve scrolling experience
...
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).
The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.
As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
Michael Hudson-Doyle
c57f0057f3
simplifications
2018-03-14 14:20:53 +13:00
Michael Hudson-Doyle
9ba11aedb5
change how ssh import field works
...
This is the only place in subiquity today where we have selectable fields side
by side, which contradicts the goal to be able to navigate subiquity with up,
down and enter keys only. Replace the existing fancy widget with two fields,
one to select the import source and one to enter the username.
Also remove the "Ubuntu SSO" option as that has never worked.
2018-03-14 14:07:03 +13:00
Michael Hudson-Doyle
f77a861c38
pop up a little dialog while the keyboard config is applying
2018-03-13 20:58:33 +13:00
Michael Hudson-Doyle
0656d2b2bc
add a border to all overlays to make them more readable
2018-03-12 14:25:27 +13:00
Michael Hudson-Doyle
d15565bdf1
console_conf does not pass a hostname here
2018-03-08 18:06:34 +13:00
Michael Hudson-Doyle
8d8071de8d
nicer install progress reporting in the footer to start with
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
b215ceaf7d
do not log wifi password when an interface appears
...
This can happen in particular when netplan re-plugs an interface.
2018-02-26 22:29:41 +13:00
Michael Hudson-Doyle
4a5e3b3815
stop showing >s on network config choices that do not lead to a new screen
2018-02-20 10:32:51 +13:00
Michael Hudson-Doyle
306978ee79
cursor positioning nerdery on network config screen
2018-02-20 10:29:24 +13:00
Michael Hudson-Doyle
a14b8debda
try different process for exit to shell
2018-02-13 15:38:55 +13:00
Michael Hudson-Doyle
1794ed53dd
implement keyboard selection ( #276 )
...
A new screen immediately after language.
2018-02-08 10:37:22 +13:00
Michael Hudson-Doyle
923df8d0b2
allow forms to override name of cancel button
2018-01-12 12:56:24 +13:00
Michael Hudson-Doyle
124b4e7f20
make the contents of a selector pop up dialog a listbox
...
the one for keyboard layout will need to scroll!
2018-01-12 10:27:44 +13:00
Michael Hudson-Doyle
c9f3bd3ae0
fix behaviour of "up" on views that have done initially focused
...
before this, if you press up on e.g. the network view, focus would go to the first nic
not the last as you might expect. this is pretty obscure but oh well. such is urwid.
2018-01-11 11:50:08 +13:00
Michael Hudson-Doyle
f972119126
beef up partition view tests a bit
2017-12-21 14:41:05 +13:00
Michael Hudson-Doyle
ad9c527b51
touch /run/casper-no-prompt if answers are supplied
2017-12-21 11:40:51 +13:00
Michael Hudson-Doyle
d77b4148ef
expand NetworkConfigureIPv4InterfaceView tests a bit
2017-12-11 09:52:36 +13:00
Michael Hudson-Doyle
67611165df
fix network manual view and add super simple test of it
2017-12-08 09:41:51 +13:00
Michael Hudson-Doyle
956342478a
move subiquity.ui.views.tests.helpers to subiquitycore.testing.view_helpers
2017-12-08 09:28:48 +13:00
Michael Hudson-Doyle
c60d37f275
some testing ideas
2017-11-27 21:51:39 +13:00
Michael Hudson-Doyle
94b4f550e3
update config to match probert changes
2017-11-27 09:54:11 +13:00
Michael Hudson-Doyle
ad95cdd4d7
Merge pull request #255 from CanonicalLtd/vorlon/fix-up-tests
...
fix tests slightly
2017-11-27 09:09:08 +13:00
Michael Hudson-Doyle
54a52015d6
tone down log spam a bit
2017-11-24 12:50:37 +13:00
Michael Hudson-Doyle
c5692c38f4
Merge pull request #271 from CanonicalLtd/mwhudson/colors
...
implement new color scheme from design
2017-11-24 12:13:03 +13:00
Michael Hudson-Doyle
fadd568323
Merge pull request #268 from CanonicalLtd/mwhudson/reorg-config-rendering
...
move curtin config rendering to a method on SubiquityModel
2017-11-24 12:12:37 +13:00
Michael Hudson-Doyle
b5c07497e8
make language and disk selection buttons use the done style
2017-11-24 11:19:01 +13:00
Michael Hudson-Doyle
ba8056768e
update to use colors from design
2017-11-22 14:10:03 +13:00
Michael Hudson-Doyle
c85602527e
stop any of the *_btn functions defining a label by default
2017-11-22 13:53:35 +13:00
Michael Hudson-Doyle
e211f67b72
permit myself one bit of clever code
2017-11-22 12:16:09 +13:00
Michael Hudson-Doyle
ab9e382387
remove some more leftover bits
2017-11-22 12:05:30 +13:00
Michael Hudson-Doyle
20d4e04efd
streamline a bit, add comments
2017-11-22 11:49:20 +13:00
Michael Hudson-Doyle
225a7637ca
move color scaffolding into core
2017-11-22 11:37:49 +13:00
Michael Hudson-Doyle
918a1979b3
stop modifying the xterm palette at all and use ISO 8613 3 codes instead
2017-11-22 11:26:47 +13:00
Michael Hudson-Doyle
cfbc4ffc0c
more precise color rendering in xterm-like terminals
2017-11-21 15:24:07 +13:00
Michael Hudson-Doyle
484239c060
do not move on from network screen inside callback
...
things get super confusing when there is an exception
2017-11-21 11:27:26 +13:00
Michael Hudson-Doyle
36bcc539c3
move curtin config rendering to a method on SubiquityModel
...
this moves to curtin's native netplan support as a side effect
2017-11-20 13:45:58 +13:00
Michael Hudson-Doyle
6919e5ce68
minimal implementation of canned answers
...
this allows automation of the enter-enter-enter flow, not much more than that
2017-11-17 13:25:16 +13:00
Michael Hudson-Doyle
e7afa9b0b3
correct _data_ready call when udev is not settled
2017-11-17 13:24:30 +13:00
Michael Hudson-Doyle
8086d5df81
move to a unified model instance
...
and stop having the controllers construct each model instance for itself
2017-11-16 12:48:20 +13:00