Michael Hudson-Doyle
59a500c9e5
add more space between form rows, align help to the left
2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle
16f8bc07d0
Merge pull request #294 from CanonicalLtd/mwhudson/better-scrolling
...
improve scrolling experience
2018-03-14 14:58:36 +13:00
Michael Hudson-Doyle
2a1e0f1ffa
Merge pull request #297 from CanonicalLtd/mwhudson/ssh-import-rework
...
change how ssh import field works
2018-03-14 14:58:25 +13:00
Michael Hudson-Doyle
ca953ea01f
improve scrolling experience
...
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).
The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.
As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
Michael Hudson-Doyle
5a81c397b9
Merge pull request #295 from CanonicalLtd/mwhudson/no-swapfile-for-btrfs-root
...
prevent creation of a swapfile when / is btrfs
2018-03-14 14:27:01 +13:00
Michael Hudson-Doyle
c57f0057f3
simplifications
2018-03-14 14:20:53 +13:00
Michael Hudson-Doyle
9ba11aedb5
change how ssh import field works
...
This is the only place in subiquity today where we have selectable fields side
by side, which contradicts the goal to be able to navigate subiquity with up,
down and enter keys only. Replace the existing fancy widget with two fields,
one to select the import source and one to enter the username.
Also remove the "Ubuntu SSO" option as that has never worked.
2018-03-14 14:07:03 +13:00
Michael Hudson-Doyle
e1bc2eb45d
Merge pull request #296 from CanonicalLtd/mwhudson/shift-tab-fixery
...
keyboard fixes: show dialog while applying, re-setup shift tab afterwards
2018-03-14 10:04:35 +13:00
Michael Hudson-Doyle
bafef44750
/snap/bin is apparently not on PATH for subiquity...
2018-03-13 21:28:58 +13:00
Michael Hudson-Doyle
067b63b79d
run subiquity-loadkeys after setupcon to restore shift tab behaviour
2018-03-13 20:58:36 +13:00
Michael Hudson-Doyle
f77a861c38
pop up a little dialog while the keyboard config is applying
2018-03-13 20:58:33 +13:00
Michael Hudson-Doyle
cb45a4b7df
prevent creation of a swapfile when / is btrfs
...
https://bugs.launchpad.net/subiquity/+bug/1750657
2018-03-13 20:19:37 +13:00
Michael Hudson-Doyle
599eea3e2c
Merge pull request #292 from CanonicalLtd/mwhudson/overlay-border
...
add a border to all overlays to make them more readable
2018-03-13 16:59:49 +13:00
Michael Hudson-Doyle
80a8ce5260
Merge pull request #293 from CanonicalLtd/mwhudson/red-red
...
change danger color to be #ff0000
2018-03-13 16:59:23 +13:00
Michael Hudson-Doyle
6dd6299a6e
fix a crash
2018-03-13 14:42:47 +13:00
Michael Hudson-Doyle
c31183ff13
change danger color to be #ff0000
2018-03-12 14:28:34 +13:00
Michael Hudson-Doyle
0656d2b2bc
add a border to all overlays to make them more readable
2018-03-12 14:25:27 +13:00
Michael Hudson-Doyle
23dc099933
Merge pull request #291 from CanonicalLtd/resurrect-console-conf
...
Resurrect console conf
2018-03-08 21:52:38 +13:00
Michael Hudson-Doyle
6f4a87101b
flakes--
2018-03-08 19:05:51 +13:00
Michael Hudson-Doyle
0273a3d110
"modernize" console-conf views
2018-03-08 18:51:39 +13:00
Michael Hudson-Doyle
d15565bdf1
console_conf does not pass a hostname here
2018-03-08 18:06:34 +13:00
Michael Hudson-Doyle
1d4d5021ec
fix button creation
2018-03-08 18:06:07 +13:00
Michael Hudson-Doyle
1d4fa36dee
give console_conf its own palette definition
2018-03-08 18:03:51 +13:00
Michael Hudson-Doyle
386d44ee14
add ConsoleConf model and some other bits to get to point of starting the UI up
2018-03-08 16:39:03 +13:00
Michael Hudson-Doyle
68c15176ac
some trivial stuff
2018-03-08 16:34:25 +13:00
Michael Hudson-Doyle
6b156766bb
change replay-curtin-log to give a more realistic experience in dry-run mode
2018-02-28 15:57:35 +13:00
Michael Hudson-Doyle
b83e2779bc
Merge pull request #289 from CanonicalLtd/mwhudson/curtin-output-2
...
do not show full curtin log output by default
2018-02-28 13:58:12 +13:00
Michael Hudson-Doyle
4f08c72102
add view full log option
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
3753ac02bb
simplify things a bit more, fix test
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
bc4fe51e30
create ProgressView when install starts, allows some simplification of logic
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
94b09dda42
start to prepare for full log view
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
993ed4c6f2
store curtin output in journal (still not visible in UI)
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
911bed340e
do not pack description, otherwise wrapping does not work?
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
5827abb12c
do not stop reading journal events as soon as curtin finishes, or we miss last few events
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
6eaa92553c
some better logging
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
673ac39e5f
display journal events in installprogress view
...
just need to put the full log view as an option back
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
ef0632175b
use a different syslog identifier for each subiquity process
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
8d8071de8d
nicer install progress reporting in the footer to start with
2018-02-28 13:49:24 +13:00
Michael Hudson-Doyle
c7537d90ba
Merge pull request #290 from CanonicalLtd/mwhudson/test-in-lxd
...
move to running tests in lxd rather than docker
2018-02-28 13:48:18 +13:00
Michael Hudson-Doyle
f7a93e6d1b
move to running tests in lxd rather than docker
...
other work requires having systemd running
2018-02-28 13:42:47 +13:00
Michael Hudson-Doyle
57c8160ffb
fix build with newer snapcraft
2018-02-27 13:38:14 +13:00
Michael Hudson-Doyle
ad07625329
prevent editing/deleting the bios_grub partition
2018-02-27 11:41:56 +13:00
Michael Hudson-Doyle
6836e4bc19
make the path choices in the installpath view forward_btns
2018-02-26 22:31:12 +13:00
Michael Hudson-Doyle
b215ceaf7d
do not log wifi password when an interface appears
...
This can happen in particular when netplan re-plugs an interface.
2018-02-26 22:29:41 +13:00
Michael Hudson-Doyle
092083d483
Merge pull request #287 from CanonicalLtd/mwhudson/network-right-angle-brackets
...
stop showing >s on network config choices that do not lead to a new screen
2018-02-22 13:54:02 +13:00
Michael Hudson-Doyle
23400b6bbb
Merge pull request #288 from CanonicalLtd/mwhudson/guided-wording
...
use better wording on guided screen
2018-02-22 13:53:50 +13:00
Michael Hudson-Doyle
c0e4af0d0f
fix some versions of the partition view
2018-02-21 19:19:44 +13:00
Michael Hudson-Doyle
37d93a1954
Merge pull request #275 from CanonicalLtd/maas-option
...
Re-add installpath controller, with added MAAS views.
2018-02-21 12:24:08 +13:00
Michael Hudson-Doyle
4a5e3b3815
stop showing >s on network config choices that do not lead to a new screen
2018-02-20 10:32:51 +13:00
Michael Hudson-Doyle
306978ee79
cursor positioning nerdery on network config screen
2018-02-20 10:29:24 +13:00