94de7dc522
Merge remote-tracking branch 'origin/pull/500/head'
...
Merge using existing partitions. Revert to using archive
curtin/deps/etc.
Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>
2019-07-02 13:18:46 +01:00
dac6f12c0f
Basic zdev view
2019-06-06 16:15:15 +01:00
628758811e
support for editing existing partitions
2019-05-30 15:10:54 +12:00
3bdca52ed4
Tweak the adjustment of table columns widths for cells with colspan > 1
...
When allocating space for a cell colspan > 1, preferentially
allocate space to columns that have no colspan = 1 cells. If you
have content like this (content padded to 10 and 20 chars to make
calculations easier):
[[(2, "longer content567890"), "shorter890"],
["shorter890", (2, "longer content567890")]]
Taking only colspan = 1 cells into account, the widths of the
columns are (10, 0, 10).
To fit the first longer content in, the current algorithm expands
the first two columns equally, so the widths become (15, 5, 10).
Then to fit the second longer content in, the second two columns
are widened equally (or nearly so), resulting in final widths
of (15, 8, 12) and a table layout like this:
+-------------------------+--------------+
| longer content567890 | shorter890 |
+-----------------+-------+--------------+
| shorter890 | longer content567890 |
+-----------------+----------------------+
which is bizarrely asymmetrical given the input and wider than it
needs to be.
If instead we preferentially widen columns that have no width
from colspan = 1 columns, we get this layout:
+----------------------+------------+
| longer content567890 | shorter890 |
+------------+---------+------------+
| shorter890 | longer content567890 |
+------------+----------------------+
Which is much more in line with my expectations.
2019-05-30 15:10:34 +12:00
e46de5def8
Drop Installpath
2019-05-14 15:09:55 +02:00
bdf33a2adf
make SubiquityModel objects easier to construct
...
So I can write a unittest more easily.
This involves shuffling around how locale changes are done but as my new
design document says the "controller also manages the relationship
between the outside world and the model and views" this does make things
more consistent.
2019-05-10 09:44:01 +12:00
fee6fe6947
netplan.Config().config should initialize to a dict
...
Normally netplan.Config().config is a dict as produced by
yaml.safe_load(). However, on systems without any netplan configs that
is not true. The subiquity code that calls into this function expects
.config to be a dictionary. When it's not
subiquitycore/models/network.py produces traceback that "list does not
have get method" when trying to get 'network' key.
2019-05-02 15:22:23 +01:00
6a72b229b1
try probing for blockdev only if probing fails; report failure to user
2019-04-29 15:58:19 +12:00
e8423acd28
do storage probing in the background
2019-04-29 15:54:47 +12:00
3e8bc81190
add some logging around moving between screens
...
my best guess at why CI is currently hanging sometimes is that the
'next-screen' signal is being sent too often / too early. add some
logging around this so that we will be able to confirm / deny this by
reading the logs.
2019-04-18 10:22:05 +12:00
488f6fd2c0
Lock answers file.
2019-04-12 17:36:12 +01:00
7cc56a8b58
trying to debug edge ci failures
...
* add a bit more logging
* wait for initial network apply to finish before moving on from
network screen
2019-04-04 12:06:41 +13:00
ec15929d60
Update to probert tip
...
The minimum required: it still only looks at the "blockdev" key in the
probe data, none of the exciting new stuff.
2019-04-02 13:43:09 +13:00
3384eb5c84
small fixes
2019-03-26 11:32:02 +13:00
b485cf487b
make the re-dhcp on entry to the network screen a little more discreet
2019-03-26 10:59:50 +13:00
099e658670
make applying changes less jarring for virtual devices
2019-03-26 10:59:50 +13:00
23488a6f2e
some fixes found in testing
2019-03-26 10:59:50 +13:00
b571b3d1a9
track and display DHCP status
...
Mark all devices with DHCP enabled as pending when the config is
applied, and mark them as timed out ten seconds later if they have not
received any addresses.
2019-03-26 10:57:36 +13:00
eae2497d41
auto disable inactive NICs
...
This disables any NIC that does not have a global address by the first
time the network screen is shown
2019-03-26 10:57:36 +13:00
3bb9268974
apply network changes immediately, rather than when the "Done" is pressed
...
diff makes this change look more involved than really necessary :(
2019-03-26 10:57:33 +13:00
594db86618
have DownNetworkDevices do its work in a background thread
...
not that it should block, but no reason not to
2019-03-26 10:57:13 +13:00
ff59de4a9c
change "Done" button to "Continue without network" if there is no default route
2019-03-26 10:57:13 +13:00
680da7d299
rename/redefine default route waiter to watcher
...
the callbacks now get called whenever the set of default routes changes,
not just when one appears
2019-03-26 10:57:13 +13:00
c0f4a90179
refactor network view
...
The visible impact of this is that the addresses for a NIC are now
displayed underneath its name and a long "info line" (i.e. mac / model /
vendor) for a nic no longer distorts its table.
This lays the groundwork for better handling of NICs that fail to dhcp
and things like that.
2019-03-25 09:25:53 +13:00
d2349b0507
move spinner to subiquitycore
2019-03-21 14:48:48 +13:00
bc1a1e7fe6
fix Signal.register to accommodate strange urwid behaviour
2019-03-14 09:55:03 +13:00
b169d35316
display any error received when checking for updates
2019-03-12 11:49:03 +13:00
b91c961165
implement screens up to the point of offering the update
...
don't display anything about check failures yet, or actually allow the
user to start the update
2019-03-12 11:49:03 +13:00
9aea579027
support a controller being shown more than once
2019-03-12 11:48:58 +13:00
a888ed222c
kick off snap list when a default route appears, not at startup
...
of course in the common case these are more or less the same time. but
this is conceptually nicer
2019-03-07 15:46:40 +13:00
a51f04b02c
start network probing after all signals have been connected
2019-03-07 15:31:39 +13:00
6e077ef457
move code for configuring snapd proxy out of snaplist controller
2019-03-07 15:18:34 +13:00
1c5ce7c07a
remove no-longer-used code for stacking signals
2019-03-07 14:22:50 +13:00
756d923424
remove long disabled views for setting default route
...
as and when we add route configuration to subiquity, we will need new
views anyway.
2019-03-07 14:13:37 +13:00
d0c41469a7
remove login model/controller/view from subiquitycore
...
long ago subsumed into other code
2019-03-07 14:01:52 +13:00
9937ebe6e1
add a more systematic way for controllers to record their state
...
so we can return the point where the user left off on update
2019-03-06 15:55:15 +13:00
98bf6a4254
add a way for a controller to be skipped
...
will need this for the refresh screen if there is no update
2019-03-06 15:32:31 +13:00
53d1006a06
Make the code for talking to snapd more generic
...
In preparation for the self-refresh and snap enterprise proxy work, both
of which will require talking to the snapd API.
This also makes the "snaps-from-examples" fakery happen at a lower level.
2019-03-04 16:18:57 +13:00
3b4d7a4266
move snap title into header
2019-02-27 15:56:02 +13:00
2587b6dd02
fix some dodgy algebra in scrollbars
2019-02-27 14:28:05 +13:00
b77aa9499e
make sure all delays during replaying answers repsect SUBIQUITY_REPLAY_TIMESCALE
2019-02-21 11:07:54 +01:00
bc755cc953
fix a race condition in network answers support
2019-02-21 09:32:45 +01:00
c571f58dcc
fix saving static network data with search domains
2019-02-21 08:35:19 +01:00
f25bb21c08
fix netdev info dialog
2019-02-19 14:40:19 +01:00
f4cf947b0a
center the list of disks
2019-02-04 17:41:11 +13:00
fae9be9103
make the network view slightly less of a snowflake
2019-02-04 17:25:31 +13:00
0b3d44f911
oops
2019-02-04 16:17:58 +13:00
4e0af495df
more
2019-02-04 14:47:00 +13:00
a553246a30
add a min_width of 96 to the content area of the "standard" view
2019-02-04 14:43:19 +13:00
aebb0b2e2e
fill identity fields if you go back to that form
2018-12-13 14:49:55 +13:00
2eb9420a75
move ssh key fetching over to ssh view
2018-12-13 14:15:43 +13:00
16a853107e
add form fields to ssh view
2018-12-13 14:15:43 +13:00
0d35fa613c
core: special case s390x vt220 console on /dev/ttysclp0, as it supports colors.
2018-11-23 01:24:34 +00:00
bee1109a2d
Much more fine grained answers support for networking.
2018-10-31 09:59:31 +13:00
5f8e3dc2a4
do not call next-screen from a background thread
2018-10-31 09:58:58 +13:00
09bbe3ff19
Do not call the default route waiter repeatedly.
...
This can crash when multiple interfaces get routes.
2018-10-31 09:58:58 +13:00
15b6bb1114
Major refactor of network model
...
The main thrust of this is to not create virtual interfaces until
applying the config.
This meant that the network model has to change a bit to be able to
represent interfaces that do not yet exist on the system. I did this
by ripping out most of the existing network device code: now a
NetworkDev is really just a wrapper for the config for a device and (if
it exists) the netlink data too. A few places had to adjust to checking
if the netlink info is available before accessing it but all in all it
was not that painful.
There are a few other refactorings in this commit that perhaps should be
split out (how the bond parameters are handled, some stuff about
resizing the table rows when interfaces are edited) but it doesn't
really seem worth it.
2018-10-31 09:58:56 +13:00
7a86603539
prevent bonding of bonds
...
https://bugs.launchpad.net/bugs/1782397
2018-07-23 10:39:14 +12:00
96ee3db409
make example CIDR form address family appropriate
...
https://bugs.launchpad.net/bugs/1782391
2018-07-23 10:38:06 +12:00
7f766e93a1
forbid bonding of vlans
...
https://bugs.launchpad.net/bugs/1782351
2018-07-23 10:34:41 +12:00
42b339605c
make button labels more consistent
...
especially back vs cancel
for https://bugs.launchpad.net/subiquity/+bug/1781457
2018-07-16 22:45:36 +12:00
d95f089a04
add arrows at end of scrollbar
...
for https://bugs.launchpad.net/subiquity/+bug/1781460
2018-07-16 12:44:38 +12:00
53fb81a65b
correctly call wrapped lost_focus in _Validator.lost_focus
...
fixes https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1781429
2018-07-16 12:44:38 +12:00
f19a453e0e
mark interfaces that have dhcp enabled but did not get an address as optional
2018-07-12 14:17:20 +12:00
437f42b599
lint
2018-07-12 11:36:30 +12:00
f3b0d13fbe
a proper multi-nic selector
2018-07-12 10:10:08 +12:00
07ac05b6d3
view improvements
2018-07-11 22:02:52 +12:00
46c0d598ad
first cut at a bond form that handles devices too
2018-07-11 22:02:52 +12:00
5e683dcc1f
add create bond button
2018-07-11 22:02:52 +12:00
2f149a8aac
enable/disable bond options as bonding mode changes
2018-07-11 22:02:52 +12:00
87558f0074
lint
2018-07-11 22:02:52 +12:00
88b64ca7fd
Fix up bond netplan.
2018-07-11 22:02:52 +12:00
87ef3749e6
Finish bond master/slaves.
2018-07-11 22:02:52 +12:00
e0d231f5d7
Create bond
2018-07-11 22:02:52 +12:00
0457985208
fixup tests
2018-07-11 14:55:41 +12:00
535a0f3b04
fix editing an interface
2018-07-11 09:43:58 +12:00
c21cec6fdc
fix logic around waiting for udev to settle to avoid busy loop
2018-07-11 09:41:56 +12:00
e91308e8b9
close any dialog open for an interface that is deleted
2018-07-11 09:36:14 +12:00
c69b89b4df
expand a whinge about urwid's focus behaviour
2018-07-11 09:35:01 +12:00
91def10468
improve message on vlan interfaces
2018-07-10 22:58:47 +12:00
53a14e30ad
make updates to network screen in response to netlink events more finegrained
2018-07-10 13:25:05 +12:00
1701246d12
refactor how device row gets created a bit
2018-07-10 12:34:42 +12:00
b3636cfcd9
refactor how netdev action menu gets populated
2018-07-10 12:30:01 +12:00
db042eafa6
read vlan config from netlink
...
using support i just added to probert
2018-07-08 14:16:22 +12:00
8a0e94ccc7
Pacify flake8
2018-07-06 15:00:27 +01:00
a4daae42d6
Fix crash, after deleting last vlan.
2018-07-06 14:33:34 +01:00
68b6b2a6b1
Implement information screen for the network interfaces.
2018-07-06 14:33:32 +01:00
92c53b29ae
Vlan ui
2018-07-06 14:31:42 +01:00
173eac79a5
models/network: use same NetDev in both dictionaries
...
One can lookup interfaces by ifindex and by name. Ensure, both
dictionaries use the same NetDev object. This way, when config of
NetDev is updated, it is correctly reflected whichever way the NetDev
is accessed.
2018-07-06 14:30:42 +01:00
d5f136c413
improve behaviour when a spanning column makes table want to be wider than view
2018-07-06 15:20:25 +12:00
e3e5c7f760
fix tests
2018-07-06 14:44:19 +12:00
ed09054928
fix lint
2018-07-06 14:17:27 +12:00
29fe577013
delete more unused code
2018-07-06 14:13:30 +12:00
830d89c735
unify "action menu row" creation
2018-07-06 13:57:55 +12:00
7d15727b74
add wlan editing
2018-07-06 13:36:53 +12:00
2e281d00d4
delete gobs of old code
2018-07-06 13:36:53 +12:00
2251cac4ba
trim back to existing functionality
2018-07-06 13:36:53 +12:00
805ad5f495
code motion
2018-07-06 13:36:53 +12:00
79a380f28f
initialize manual form fields
2018-07-06 13:36:53 +12:00
58fd656aed
small tweaks
2018-07-06 13:36:53 +12:00
834b5a1014
a bit better
2018-07-06 13:36:53 +12:00
89a30721a2
copy network manager a bit more directly
2018-07-06 13:36:53 +12:00
0fdd9721ce
tweaks
2018-07-06 13:36:53 +12:00
08de48623f
more
2018-07-06 13:36:53 +12:00
4c9ec9cf5e
more
2018-07-06 13:36:53 +12:00
6eb255c2e0
beginnings of an edit network device dialog
2018-07-06 13:36:53 +12:00
ad8d6c9086
skeleton of new view
2018-07-06 13:36:53 +12:00
7aac188a4b
grey out the background widget when an overlay is showing
2018-07-04 15:53:47 +12:00
e0eeeadd28
enable/disable a Toggleable via a property not methods
2018-07-04 11:47:44 +12:00
38eccb8382
use the new variable table padding on filesystem views
2018-06-29 14:00:22 +12:00
5e621a4780
allow for variable spacing between table columns
2018-06-29 13:40:58 +12:00
dbe07faa5c
fix infinite loop in table width calculations
2018-06-29 09:24:12 +12:00
91247c82c5
Merge pull request #373 from mwhudson/raid-the-fourth
...
Raid the fourth
2018-06-27 11:06:43 +12:00
237290bbb3
fix rendering of long labels on guided disk selection screen
2018-06-26 14:20:41 +12:00
9e4a66b628
add the raid view
2018-06-26 12:22:09 +12:00
edd6769a60
add ReadOnlyField (to be used for the size of a raid)
2018-06-26 12:19:47 +12:00
1895d98ac4
tweak TableRow.selectable
2018-06-26 11:40:02 +12:00
48666547f1
convert focusable things on filesystem view to "[ {stuff} ▸ ]" layout
2018-06-26 11:14:37 +12:00
237611fda6
change " menu >" to "[ menu ▸ ]"
2018-06-26 10:19:57 +12:00
1ae09926ca
change button_pile to use widget_width
2018-06-26 10:12:09 +12:00
8854e7aaaa
move CursorOverride somewhere generic
2018-06-26 10:05:37 +12:00
22ae45e99b
move widget_width() to its own module
...
also allow our widget subclasses to specify their width
2018-06-26 09:59:48 +12:00
5f3ce077ac
Merge pull request #372 from mwhudson/selector-tweaks
...
Selector tweaks
2018-06-26 09:10:46 +12:00
8bb5621947
Merge pull request #371 from mwhudson/action-menu-tweaks
...
do not show > in the context menu for actions that do not open a dialog
2018-06-25 23:50:24 +12:00
4501aee357
rework look of open selector to match
2018-06-25 23:45:21 +12:00
391b70cdf5
rework the look of the selector widget
2018-06-25 23:45:21 +12:00
7ab699716d
make Selector.options a public interface
2018-06-25 23:45:21 +12:00
80bec75871
stop assigning to Selector.value emitting the "select" signal
...
for the avoidance of infinite recursion
2018-06-25 23:45:21 +12:00
f08b6a42e5
make selector a WidgetWrap rather than a decoration
2018-06-25 23:10:39 +12:00
a6f54be22a
fix stupid failure of arithmetic in stretchy
2018-06-25 22:57:57 +12:00
8b9331e5be
do not show > in the context menu for actions that do not open a dialog
2018-06-25 22:52:34 +12:00
90d580a57e
remove DummyView
2018-06-22 09:39:33 +12:00
9cbaac4542
use our custom WidgetWrap everywhere
2018-06-22 09:38:18 +12:00
ea8f97491f
delete old ErrorView
2018-06-22 09:34:02 +12:00
0e2d376ed0
build a form out of tables
2018-06-21 21:07:02 +12:00
7093006711
fix binding more than two tables
2018-06-21 20:48:08 +12:00
88e23fce54
fix distribution of space when widening columns to accommodate a colspan>1 column
2018-06-21 16:07:00 +12:00
f09696862a
add a column option to allow a column to take available space
2018-06-21 16:07:00 +12:00
8eb21bce72
split Table into TablePile and TableListBox
...
and get rid of that confusing container_maker thing
2018-06-21 16:07:00 +12:00
119f40b72d
Merge pull request #369 from mwhudson/form-simplify
...
simplify the way forms are turned into widgets
2018-06-21 16:06:47 +12:00
f037ebd586
add lost_focus/gained_focus to our WidgetWrap
2018-06-21 15:39:14 +12:00
99dd12f870
simplify how forms are built
2018-06-21 15:38:02 +12:00
ed86028dd2
provide a way for a field to opt out of default styling
2018-06-21 15:37:19 +12:00
19d43c19c7
make field an ABC
2018-06-21 15:37:19 +12:00
ba809a9e97
simplify how form widgets get styled
2018-06-21 15:37:19 +12:00
59da0e717b
make Toggleable simpler and more robust
2018-06-21 15:37:15 +12:00
eee758d382
update STYLE_NAMES to match the styles that are currently defined
2018-06-21 12:09:40 +12:00
76835c40ab
sort STYLE_NAMES constructor
2018-06-21 12:09:40 +12:00
8680786da3
make inputs on keyboard and welcome page of consistent width
2018-06-20 09:17:49 +12:00
9e33874a86
Merge pull request #366 from mwhudson/mwhudson/scrollbar-tweaks
...
make scrollbar less intrusive
2018-06-20 08:47:56 +12:00
68c49e5135
add some super basic filesystem tests, fix partition tests
2018-06-19 11:43:59 +12:00
de80a06f47
add actionmenu widget
2018-06-18 21:36:35 +12:00
c0d66f5540
make scrollbar less intrusive
...
also pretty up its implementation a bit while I am here
2018-06-18 21:24:23 +12:00
14ad092b9d
implement _select_first/last_selectable on our Columns
2018-06-15 12:26:02 +12:00
3a59925265
work around a strange behaviour of Pile when contents is changed
2018-06-15 11:51:40 +12:00
66578aff79
account for colspan>1 cells in width computations
...
I ran into that gotcha pretty quickly.
2018-06-15 11:48:19 +12:00
b34ca65aba
a slightly over-engineered table widget
...
that takes column widths from the contens of the cells, unlike
most things in urwid
2018-06-15 11:48:19 +12:00
2f184ce9a6
fix display of install progress in footer
2018-06-13 14:02:40 +12:00
1ab495c0a8
fix refreshing network view on network changes
2018-06-13 13:38:03 +12:00
d315751d60
add our own version of WidgetWrap
...
urwid doesn't know about the _select_first/last_selectable methods our
containers use to make tab-cycling work so its WidgetWrap doesn't
forward them along. So add a WidgetWrap that does, and use it in the one
place that it matters so far (more coming soon!).
2018-06-11 14:13:44 +12:00
3e69673501
Fix writing of netplan configs
...
When user configures network with subiquity, it's rendered
netplan should be wholly definitive. So, we remove the other files
that may have config. This fixes a bug where running in an instance
when running on a system where cloud-init had rendered a 'match' with
'macaddress'.
When writing netplan we keep 'macaddress' match in place but drop
others. The others may just wildcard from the installer environment,
but macaddress are likely by cloud-init or otherwise intentionally
written.
Also add an atomic write in subiquitycore/file_util and move the
netplan code into subiquitycore/netplan.py, and add some unit test
helpers from cloud-init.
2018-06-07 11:46:34 -04:00
270ba0992a
fix selectability in non-scrolling stretchy
2018-06-07 12:50:50 +12:00
51a7169904
tox: Support running tests and flake8 in tox.
...
This puts into place a tox.ini for running unit tests without
a large amount of deps installed into the system. For example,
we did not want to need libnl-route-3-dev or build-essential installed
in the system in order to run unit tests.
In order avoid import errors in the modules due to these missing
dependencies, we have added a 'fake_deps/' directory that provides
mock'd objects of the dependencies that were used.
The only installed packages necessary for this to run should be
tox itself and its dependencies (pip and friends). From a clean new
container we can then do:
apt-get install tox
git clone ...
tox
Also along the way:
* adjust setup.py to only need the DistUtilsExtra during 'build'.
This means tox usage doesn't require python3-distutils-extra.
* drop use of lsb_release in favor of built-in parsing.
This python module wasn't doing much. We can parse /etc/lsb-release
ourselves with less footprint. Also part of the motivation for this
is that lsb_release was not on pypi.
* replace use of StorageInfo in test_partition.py with a FakeStorageInfo
* .gitignore: ignore only the top level 'probert' directory so that
we can track fake_deps/probert.
* fix a couple escape chars, by using raw strings (r'').
* adjust gettext to return un-modified strings rather than '_(string)',
but support old style if FAKE_TRANSLATE=mangle.
2018-06-05 17:59:46 -04:00
eab0f668ff
use general machinery a little more
2018-05-31 10:28:29 +12:00
ed5e1d86b5
fix lint
2018-05-25 10:43:55 +12:00
053a1c249d
pyflakes3 fixes for subiquitycore/__init__.py
2018-05-24 16:59:31 -05:00
d7c8b1111b
pep8 fixes for subiquitycore/core.py
2018-05-24 16:59:31 -05:00
d293c52152
pep8 fixes for subiquitycore/tasksequence.py
2018-05-24 16:59:31 -05:00
4c1b6e6fc9
pep8 fixes for subiquitycore/ui/buttons.py
2018-05-24 16:59:31 -05:00
080ac4c245
pep8 fixes for subiquitycore/ui/form.py
2018-05-24 16:59:31 -05:00
5b666294e5
pep8 fixes for subiquitycore/ui/utils.py
2018-05-24 16:59:31 -05:00
7dba257b3c
Drop mis-merged code from rebase
2018-05-24 16:59:31 -05:00
09d7398ec6
pep8 fixes for subiquitycore/__init__.py
2018-05-24 16:54:02 -05:00
5f233be9b1
pep8 fixes for subiquitycore/ui/views/network.py
2018-05-24 16:54:02 -05:00
c908115ee0
pep8 fixes for subiquitycore/ui/views/network_configure_manual_interface.py
2018-05-24 16:54:02 -05:00
c4c614860a
pep8 fix drop commented code in subiquitycore/controllers/network.py
2018-05-24 16:54:02 -05:00
5660d72cf1
pep8 fixes for subiquitycore/controller.py
2018-05-24 16:51:51 -05:00
9159cd0003
pep8 fixes for subiquitycore/core.py
2018-05-24 16:51:51 -05:00
dcc0cbc240
pep8 fixes for subiquitycore/i18n.py
2018-05-24 16:51:51 -05:00
02cbd2948c
pep8 fixes for subiquitycore/prober.py
2018-05-24 16:51:51 -05:00
bad0e9761f
pep8 fixes for subiquitycore/tasksequence.py
2018-05-24 16:51:51 -05:00
b328c3deed
pep8 fixes for subiquitycore/utils.py
2018-05-24 16:51:51 -05:00
cfc2c9d227
pep8 fixes for subiquitycore/view.py
2018-05-24 16:51:51 -05:00
69331754d9
pep8 fixes for subiquitycore/ui/anchors.py
2018-05-24 16:51:51 -05:00
df5ff9d48e
pep8 fixes for subiquitycore/ui/buttons.py
2018-05-24 16:51:51 -05:00
860edbc7b5
pep8 fixes for subiquitycore/ui/container.py
2018-05-24 16:51:51 -05:00
2d6cca8281
pep8 fixes for subiquitycore/ui/frame.py
2018-05-24 16:51:51 -05:00
7cbf8c2b69
pep8 fixes for subiquitycore/ui/form.py
2018-05-24 16:51:51 -05:00
4890d306fc
pep8 fixes subiquitycore/ui/selector.py
2018-05-24 16:51:51 -05:00
762f5f3008
pep8 fixes for subiquitycore/ui/stretchy.py
2018-05-24 16:51:51 -05:00
18406b70ef
pep8 fixes for subiquitycore/ui/utils.py
2018-05-24 16:51:51 -05:00
c99941f3c5
pep8 fixes for subiquitycore/ui/views/login.py
2018-05-24 16:51:51 -05:00
62ea440b3d
pep8 fixes for subiquitycore/ui/views/network.py
2018-05-24 16:51:51 -05:00
0fa5dcab28
pep8 fixes
2018-05-24 16:51:51 -05:00
c8d4c51ddd
pep8 fixes
2018-05-24 16:51:51 -05:00
ae9412159d
Don't use __name__ in getLogger
2018-05-24 16:51:51 -05:00
13ca352291
pep8 fixes for subiquitycore/ui/views/network_configure_wlan_interface.py
2018-05-24 16:51:51 -05:00
591be4ecbc
pep8 fixes for subiquitycore.ui.views.network_default_route
2018-05-24 16:51:51 -05:00
45fabd78f2
pep8 fixes for subiquitycore.ui.views.tests.test_network_configure_manual_interface
2018-05-24 16:51:51 -05:00
f2715a4735
pep8 fixes for subiquitycore.controllers.network
2018-05-24 16:51:51 -05:00
b7e60f7b91
pep8 fixes for subiquitycore.testing.view_hewlpers
2018-05-24 16:51:51 -05:00
40caacaca3
pep8 fixes for subiquitycore.models.network
2018-05-24 16:51:51 -05:00
a0bf68f3c4
pyflakes3 fixes
...
Add and enable pyflakes3 on console_conf, subiquity, subiquitycore and tests.
Replace NOQA markers with __all__ declarations for module imports.
Replace some obvious deadcode that voilates flake8, separate pass for removing
dead code rather than commenting will be handled later.
2018-05-24 16:51:51 -05:00
bd48ed9b1d
remove SimpleList
...
and the Body widget, both utterly trivial
2018-05-25 09:35:25 +12:00
3c9b2e28c7
Drop commented out / dead code
2018-05-23 18:53:12 -05:00
0fe1f5145c
sprinkle in some more ".base_widget"s
2018-05-23 13:40:14 +12:00
7441cb6df6
convert ScrollBarListBox to decoration rather than subclass
...
for all the usual reasons why composition is better than inheritance,
but in particular because I want to have a listbox that has a scrollbar
but not our custom tab behaviour in another branch. decoration in urwid
is not as transparent as it sometimes seems it should be but luckily
there's only one view that does much with its listbox and it was due
for some cleanup anyway.
2018-05-23 13:14:00 +12:00
626488e988
Merge pull request #334 from CanonicalLtd/mwhudson/move-excerpt-title-to-view
...
move excerpt, title and footer from controller to view
2018-05-22 22:38:39 +12:00
a84dd2b272
Encoding input when running commands
2018-05-21 13:35:26 -05:00
74ae9b9fde
Drop use of encoding kwarg to subprocess for python3.5 compat
2018-05-21 11:54:34 -05:00
79208bc00b
trap a TaskSequence gotcha
2018-05-21 13:09:56 +12:00
70ec850aad
Merge pull request #336 from CanonicalLtd/mwhudson/hack-ThreadPoolExecutor
...
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:59:12 +12:00
384dadc5ed
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:58:10 +12:00
f6f214125f
move TaskSequence somewhere more generic
...
I want to reuse it in my containerizing branch.
Improve API and docs a bit while I am looking at it.
2018-05-21 11:52:06 +12:00
cbd5afe2c0
move imports of i18n higher so _ is always installed before tests are imported
2018-05-21 10:14:34 +12:00
ac875751fb
fix installprogress
2018-05-18 16:27:05 +12:00
11708703c9
move titles, footers, excerpts from controller to view
...
read title and footer from the view instance, make views respsonsible for rendering
the excerpt
adapts infrastructure, welcome, keyboard, network views
2018-05-18 15:55:49 +12:00
80fffc723c
some self review
2018-05-18 13:53:51 +12:00
7df7a4c1fa
fetch ssh keys in the identity screen, all a bit happy path though
2018-05-18 13:53:51 +12:00
bdf3861e5c
some simplifications
2018-05-18 13:53:51 +12:00
3d5efcaf9c
actually pass new defaults to run, oops
2018-05-18 13:53:25 +12:00
1e4992a5e7
stop testing on xenial, we depend on python 3.6 now
2018-05-18 13:38:13 +12:00
cb61144144
small tweaks
2018-05-18 13:21:38 +12:00
488802fc8b
update users of run_command (i thought there was more than this)
2018-05-18 13:11:15 +12:00
c6468982ae
Thin the wrappers around subprocess functions
...
Some of this stuff is not needed with modern Python.
Breaks everything of course, updates to follow.
2018-05-18 13:00:43 +12:00
35c08f1d6f
up thread pool limit
...
otherwise we can only do one thing at once! many of the things
we do in the background do not really require an OS thread but oh well
2018-05-18 12:33:25 +12:00
ad9f10a9ac
try to ensure that functions run in the background have "_bg_" in their name
2018-05-18 12:29:42 +12:00
1efa265fc5
remove calls to set_alarm_in that were only there so that exceptions raised would be propagated
2018-05-18 12:25:47 +12:00
03392a208d
stop swallowing exceptions raised by the callback passed to run_in_bg
...
it is just more confusing that it is worth, especially when doing
development
2018-05-18 12:17:18 +12:00
13d7f13c42
fixes for stretchy where stretchy widget is selectable
2018-05-14 10:28:33 +12:00
960f51ca91
remove view argument to Form.as_rows and friends
2018-05-07 10:57:35 +12:00
0a0af0842b
fix stupid crash
2018-05-04 10:31:36 +12:00
fa8f8d32f5
down all network links that have changed config before applying it
...
this means that if you enter a broken config, it breaks as it should
2018-05-03 12:14:06 +12:00
92457e5724
Merge pull request #324 from CanonicalLtd/mwhudson/click-helper
...
add --click, --script arguments to subiquity-tui
2018-05-03 11:35:35 +12:00
1ed27f1848
Merge pull request #322 from CanonicalLtd/mwhudson/no-create-user
...
stop creating the user in the live session
2018-05-01 13:01:08 +12:00
5a6d0ac90f
a docstring
2018-05-01 13:00:27 +12:00
acdd3bdec7
refactor a bit
2018-05-01 12:57:03 +12:00
58d64eb419
over engineered way to delay command-line supplied script invocation
...
use this to allow click helper to wait for a button to appear
2018-05-01 12:49:39 +12:00
db4d8a537e
add a way to specify actions to take in the UI on the command line
...
--script takes a little python snippet to run in a helpful namespace
--click is a wrapper around --script to click a button
2018-05-01 12:29:29 +12:00
07438a1049
add support for Frames to find_with_pred in view_helpers
2018-05-01 12:17:53 +12:00
fe671d8d9b
fix rendering of nic info if dhcp failed but has addresses of other family
...
This bug has been here forever! Oh well.
2018-04-27 14:56:30 +12:00
dc17fcae4f
stop creating the user in the live session
...
there is no real reason to do this, and it lets me delete some code.
i also cleaned some other stuff up in the area
2018-04-27 14:16:37 +12:00
7d704f83f0
mark even more strings as translatable
2018-04-19 13:09:00 +12:00
78e6fea854
work around strange behaviour of _("")
2018-04-19 10:29:08 +12:00
688a270c17
a round of marking strings as translatable and ensuring translations are actually displayed in the UI
2018-04-19 10:29:08 +12:00
fdd3fae45a
fix crash on escape key
2018-04-19 09:57:11 +12:00
2d3d500e34
a couple of tweaks to make more translated strings appear
2018-04-18 20:18:15 +12:00
6396025964
Merge pull request #315 from CanonicalLtd/mwhudson/scollbar-focus
...
change scrollbar color if focused
2018-04-17 12:57:22 +12:00
ba041718dc
Merge pull request #316 from CanonicalLtd/mwhudson/stretchy-overlay
...
add an overlay that has nicer resizing behaviour
2018-04-17 12:57:15 +12:00
7eafa420fb
add show_stretch_overlay, simplify show_overlay
2018-04-17 12:23:11 +12:00
6a76f8ad02
add a version of Overlay that copes with small and large screens better
...
See the docstring for the long version.
2018-04-17 12:22:00 +12:00
e041260e2a
change scrollbar color if focused
2018-04-16 23:31:10 +12:00
5a6ad92239
add some validation to URLEditor
2018-04-12 09:43:02 +12:00
13eaa5c9dc
add a bare-bones proxy model/view/controller
2018-04-09 15:05:46 +12:00
028914da97
another small helper
2018-04-09 14:37:26 +12:00
a723d25a4c
create a helper to create a common screen layout
2018-04-09 14:30:59 +12:00
0fc83c4bc1
simplify a bunch of views
...
i am slowly getting better at urwid...
2018-04-09 14:10:36 +12:00
9d9c233dc4
bludgeon urwid into some kind of submissoin
2018-03-26 23:49:04 +13:00
e61eb454cf
Merge pull request #299 from CanonicalLtd/mwhudson/disable-wifi-server
...
do not show wlan interfaces in server installer
2018-03-21 15:44:55 +13:00
56c582a0d0
the way subiquity works it is better do consider a Pile selectable if any of its elements are selectable
...
Without this, if a non-selectable thing ends up focused, the net effect is that
all further input is ignored, which is bad.
2018-03-21 11:18:56 +13:00
0c071f7b0d
form fields should not be validated on entry
2018-03-21 10:39:32 +13:00
b3da7266b9
do not show wlan interfaces in server installer
2018-03-21 09:35:21 +13:00
8287d695dc
fix live updates of network screen
2018-03-16 15:30:14 +13:00
1f937090c0
update help text for address
2018-03-14 14:58:58 +13:00
59a500c9e5
add more space between form rows, align help to the left
2018-03-14 14:58:58 +13:00
ca953ea01f
improve scrolling experience
...
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).
The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.
As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
c57f0057f3
simplifications
2018-03-14 14:20:53 +13:00
9ba11aedb5
change how ssh import field works
...
This is the only place in subiquity today where we have selectable fields side
by side, which contradicts the goal to be able to navigate subiquity with up,
down and enter keys only. Replace the existing fancy widget with two fields,
one to select the import source and one to enter the username.
Also remove the "Ubuntu SSO" option as that has never worked.
2018-03-14 14:07:03 +13:00
f77a861c38
pop up a little dialog while the keyboard config is applying
2018-03-13 20:58:33 +13:00
0656d2b2bc
add a border to all overlays to make them more readable
2018-03-12 14:25:27 +13:00
d15565bdf1
console_conf does not pass a hostname here
2018-03-08 18:06:34 +13:00
8d8071de8d
nicer install progress reporting in the footer to start with
2018-02-28 13:49:24 +13:00
b215ceaf7d
do not log wifi password when an interface appears
...
This can happen in particular when netplan re-plugs an interface.
2018-02-26 22:29:41 +13:00
4a5e3b3815
stop showing >s on network config choices that do not lead to a new screen
2018-02-20 10:32:51 +13:00
306978ee79
cursor positioning nerdery on network config screen
2018-02-20 10:29:24 +13:00
a14b8debda
try different process for exit to shell
2018-02-13 15:38:55 +13:00
1794ed53dd
implement keyboard selection ( #276 )
...
A new screen immediately after language.
2018-02-08 10:37:22 +13:00
923df8d0b2
allow forms to override name of cancel button
2018-01-12 12:56:24 +13:00
124b4e7f20
make the contents of a selector pop up dialog a listbox
...
the one for keyboard layout will need to scroll!
2018-01-12 10:27:44 +13:00
c9f3bd3ae0
fix behaviour of "up" on views that have done initially focused
...
before this, if you press up on e.g. the network view, focus would go to the first nic
not the last as you might expect. this is pretty obscure but oh well. such is urwid.
2018-01-11 11:50:08 +13:00
f972119126
beef up partition view tests a bit
2017-12-21 14:41:05 +13:00
ad9c527b51
touch /run/casper-no-prompt if answers are supplied
2017-12-21 11:40:51 +13:00
d77b4148ef
expand NetworkConfigureIPv4InterfaceView tests a bit
2017-12-11 09:52:36 +13:00
67611165df
fix network manual view and add super simple test of it
2017-12-08 09:41:51 +13:00
956342478a
move subiquity.ui.views.tests.helpers to subiquitycore.testing.view_helpers
2017-12-08 09:28:48 +13:00
c60d37f275
some testing ideas
2017-11-27 21:51:39 +13:00
94b4f550e3
update config to match probert changes
2017-11-27 09:54:11 +13:00
ad95cdd4d7
Merge pull request #255 from CanonicalLtd/vorlon/fix-up-tests
...
fix tests slightly
2017-11-27 09:09:08 +13:00
54a52015d6
tone down log spam a bit
2017-11-24 12:50:37 +13:00
c5692c38f4
Merge pull request #271 from CanonicalLtd/mwhudson/colors
...
implement new color scheme from design
2017-11-24 12:13:03 +13:00
fadd568323
Merge pull request #268 from CanonicalLtd/mwhudson/reorg-config-rendering
...
move curtin config rendering to a method on SubiquityModel
2017-11-24 12:12:37 +13:00
b5c07497e8
make language and disk selection buttons use the done style
2017-11-24 11:19:01 +13:00
ba8056768e
update to use colors from design
2017-11-22 14:10:03 +13:00
c85602527e
stop any of the *_btn functions defining a label by default
2017-11-22 13:53:35 +13:00
e211f67b72
permit myself one bit of clever code
2017-11-22 12:16:09 +13:00
ab9e382387
remove some more leftover bits
2017-11-22 12:05:30 +13:00
20d4e04efd
streamline a bit, add comments
2017-11-22 11:49:20 +13:00
225a7637ca
move color scaffolding into core
2017-11-22 11:37:49 +13:00
918a1979b3
stop modifying the xterm palette at all and use ISO 8613 3 codes instead
2017-11-22 11:26:47 +13:00
cfbc4ffc0c
more precise color rendering in xterm-like terminals
2017-11-21 15:24:07 +13:00
Dimitri John Ledkov