Commit Graph

1834 Commits

Author SHA1 Message Date
Ryan Harper 45fabd78f2 pep8 fixes for subiquitycore.ui.views.tests.test_network_configure_manual_interface 2018-05-24 16:51:51 -05:00
Ryan Harper f2715a4735 pep8 fixes for subiquitycore.controllers.network 2018-05-24 16:51:51 -05:00
Ryan Harper b7e60f7b91 pep8 fixes for subiquitycore.testing.view_hewlpers 2018-05-24 16:51:51 -05:00
Ryan Harper 40caacaca3 pep8 fixes for subiquitycore.models.network 2018-05-24 16:51:51 -05:00
Ryan Harper acd24c0796 Add pep8 script 2018-05-24 16:51:51 -05:00
Ryan Harper a0bf68f3c4 pyflakes3 fixes
Add and enable pyflakes3 on console_conf, subiquity, subiquitycore and tests.
Replace NOQA markers with __all__ declarations for module imports.
Replace some obvious deadcode that voilates flake8, separate pass for removing
dead code rather than commenting will be handled later.
2018-05-24 16:51:51 -05:00
Ryan Harper 86216997f3 Add missing 'sig' parameter in confirm callback 2018-05-24 16:51:51 -05:00
Ryan Harper 2b41811d65 Remove unused 'os' import 2018-05-24 16:51:51 -05:00
Ryan Harper 0849db7c14 Add pyflakes3 target and script 2018-05-24 16:51:49 -05:00
Michael Hudson-Doyle bd48ed9b1d remove SimpleList
and the Body widget, both utterly trivial
2018-05-25 09:35:25 +12:00
Michael Hudson-Doyle 752b15eac3 fix welcome screen when LANG is set in environment
https://bugs.launchpad.net/subiquity/+bug/1773216
2018-05-25 09:29:52 +12:00
Michael Hudson-Doyle dce672609a
Merge pull request #342 from smoser/cleanup/makefile-pythonpath
Makefile: Always put PYTHONPATH into environment
2018-05-25 09:14:07 +12:00
Scott Moser d71cb7cadf Makefile: Always put PYTHONPATH into environment
Just use 'export PYTHONPATH' in the Makefile so that we all targets
have that in their environment.
2018-05-24 12:47:16 -04:00
Ryan Harper ae94db26ac
Merge pull request #340 from raharper/fix/drop-dead-code
Drop commented out / dead code
2018-05-24 08:55:31 -05:00
Michael Hudson-Doyle 30b8389513 Merge branch 'master' into mwhudson/snap-screen 2018-05-24 15:33:18 +12:00
Michael Hudson-Doyle 8f914a9dbd proxy tweaks
only send network-proxy-set if proxy has changed
fix proxy_systemd_dropin
2018-05-24 15:33:03 +12:00
Michael Hudson-Doyle 453eb06537 allow retrying of a failed snap download 2018-05-24 12:54:30 +12:00
Ryan Harper 6558fa553e Re-add Hebrew, marked as noqa 2018-05-23 18:55:14 -05:00
Ryan Harper 3c9b2e28c7 Drop commented out / dead code 2018-05-23 18:53:12 -05:00
Michael Hudson-Doyle 1ce06e3d87 Merge branch 'master' into mwhudson/snap-screen 2018-05-24 10:41:09 +12:00
Michael Hudson-Doyle a30c3a63e4
Merge pull request #341 from CanonicalLtd/mwhudson/scollbars-as-decoration
convert ScrollBarListBox to decoration rather than subclass
2018-05-24 10:39:41 +12:00
Michael Hudson-Doyle 0fbb3ec69e oops 2018-05-23 14:52:56 +12:00
Michael Hudson-Doyle 1ad8e20ba5 no cancel button on snap list 2018-05-23 14:34:29 +12:00
Michael Hudson-Doyle 0fe1f5145c sprinkle in some more ".base_widget"s 2018-05-23 13:40:14 +12:00
Michael Hudson-Doyle a1fc3c2b4d do not advance progess bar until postinstall steps are done 2018-05-23 13:28:24 +12:00
Michael Hudson-Doyle 58444f25e1 oops 2018-05-23 13:26:58 +12:00
Michael Hudson-Doyle 5f5775b9e0 replace SnapdSnapInfoLoader.state with a few booleans 2018-05-23 13:25:45 +12:00
Michael Hudson-Doyle f3bd43c7c4 final review comment 2018-05-23 13:18:18 +12:00
Michael Hudson-Doyle 7441cb6df6 convert ScrollBarListBox to decoration rather than subclass
for all the usual reasons why composition is better than inheritance,
but in particular because I want to have a listbox that has a scrollbar
but not our custom tab behaviour in another branch. decoration in urwid
is not as transparent as it sometimes seems it should be but luckily
there's only one view that does much with its listbox and it was due
for some cleanup anyway.
2018-05-23 13:14:00 +12:00
Michael Hudson-Doyle 517a733352 make ScrollBarListBox decoration 2018-05-23 12:31:04 +12:00
Michael Hudson-Doyle 3aac53cf1b misc review feedback 2018-05-23 11:59:14 +12:00
Michael Hudson-Doyle ca1d7ba77b parameterize store section to load 2018-05-23 11:38:42 +12:00
Michael Hudson-Doyle 702aaee953 add some long comments and rename some variables 2018-05-23 11:35:33 +12:00
Michael Hudson-Doyle 57091ffc35 add a README to examples/snaps 2018-05-23 10:14:17 +12:00
Michael Hudson-Doyle f3b9ec87d9 one last UI tweak 2018-05-22 23:41:57 +12:00
Michael Hudson-Doyle 676d22482e note new dependencies in a few places 2018-05-22 23:15:13 +12:00
Michael Hudson-Doyle 18d3f6dc8d a comment 2018-05-22 23:12:04 +12:00
Michael Hudson-Doyle 9a6275ec96 final(?) oops 2018-05-22 23:04:31 +12:00
Michael Hudson-Doyle 52560dc82c answers support and some other fixes 2018-05-22 23:01:28 +12:00
Michael Hudson-Doyle 919b292800 Merge branch 'master' into mwhudson/snap-screen 2018-05-22 22:47:36 +12:00
Michael Hudson-Doyle 626488e988
Merge pull request #334 from CanonicalLtd/mwhudson/move-excerpt-title-to-view
move excerpt, title and footer from controller to view
2018-05-22 22:38:39 +12:00
Michael Hudson-Doyle be4d1da044 allow retrying loading of snap info 2018-05-22 22:35:42 +12:00
Michael Hudson-Doyle c0d0a4aafc allow retrying the whole list of snaps 2018-05-22 22:12:52 +12:00
Michael Hudson-Doyle 23ae0748f0 better code layout 2018-05-22 22:12:35 +12:00
Michael Hudson-Doyle 2fcc4ed95f minor tweaks 2018-05-22 20:59:46 +12:00
Michael Hudson-Doyle f174ba16dc ffs 2018-05-22 14:55:58 +12:00
Michael Hudson-Doyle ac535012f8 create a dir before writing to it... 2018-05-22 14:09:53 +12:00
Michael Hudson-Doyle 28dd8c9d17 stage python3-requests & python3-requests-unixsocket 2018-05-22 13:59:06 +12:00
Michael Hudson-Doyle 18ba5cbac3 track confinement of snaps and seed classic snaps appropriately 2018-05-22 13:39:01 +12:00
Michael Hudson-Doyle 4f0ec36a97 actually sort of works now 2018-05-22 13:32:44 +12:00