028914da97
another small helper
2018-04-09 14:37:26 +12:00
a723d25a4c
create a helper to create a common screen layout
2018-04-09 14:30:59 +12:00
0fc83c4bc1
simplify a bunch of views
...
i am slowly getting better at urwid...
2018-04-09 14:10:36 +12:00
56c582a0d0
the way subiquity works it is better do consider a Pile selectable if any of its elements are selectable
...
Without this, if a non-selectable thing ends up focused, the net effect is that
all further input is ignored, which is bad.
2018-03-21 11:18:56 +13:00
0c071f7b0d
form fields should not be validated on entry
2018-03-21 10:39:32 +13:00
8287d695dc
fix live updates of network screen
2018-03-16 15:30:14 +13:00
1f937090c0
update help text for address
2018-03-14 14:58:58 +13:00
59a500c9e5
add more space between form rows, align help to the left
2018-03-14 14:58:58 +13:00
ca953ea01f
improve scrolling experience
...
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).
The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.
As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
c57f0057f3
simplifications
2018-03-14 14:20:53 +13:00
9ba11aedb5
change how ssh import field works
...
This is the only place in subiquity today where we have selectable fields side
by side, which contradicts the goal to be able to navigate subiquity with up,
down and enter keys only. Replace the existing fancy widget with two fields,
one to select the import source and one to enter the username.
Also remove the "Ubuntu SSO" option as that has never worked.
2018-03-14 14:07:03 +13:00
8d8071de8d
nicer install progress reporting in the footer to start with
2018-02-28 13:49:24 +13:00
4a5e3b3815
stop showing >s on network config choices that do not lead to a new screen
2018-02-20 10:32:51 +13:00
306978ee79
cursor positioning nerdery on network config screen
2018-02-20 10:29:24 +13:00
923df8d0b2
allow forms to override name of cancel button
2018-01-12 12:56:24 +13:00
124b4e7f20
make the contents of a selector pop up dialog a listbox
...
the one for keyboard layout will need to scroll!
2018-01-12 10:27:44 +13:00
c9f3bd3ae0
fix behaviour of "up" on views that have done initially focused
...
before this, if you press up on e.g. the network view, focus would go to the first nic
not the last as you might expect. this is pretty obscure but oh well. such is urwid.
2018-01-11 11:50:08 +13:00
d77b4148ef
expand NetworkConfigureIPv4InterfaceView tests a bit
2017-12-11 09:52:36 +13:00
67611165df
fix network manual view and add super simple test of it
2017-12-08 09:41:51 +13:00
c60d37f275
some testing ideas
2017-11-27 21:51:39 +13:00
ad95cdd4d7
Merge pull request #255 from CanonicalLtd/vorlon/fix-up-tests
...
fix tests slightly
2017-11-27 09:09:08 +13:00
54a52015d6
tone down log spam a bit
2017-11-24 12:50:37 +13:00
b5c07497e8
make language and disk selection buttons use the done style
2017-11-24 11:19:01 +13:00
ba8056768e
update to use colors from design
2017-11-22 14:10:03 +13:00
c85602527e
stop any of the *_btn functions defining a label by default
2017-11-22 13:53:35 +13:00
4d0d48f2f5
add some comments
2017-10-25 21:52:43 +13:00
c0889dfffc
add explicit entries in the palette for scrollbar parts
2017-10-25 21:09:49 +13:00
3515961ac9
slightly lower level implementation of ScrollBarListBox.render
...
lower level and less reentrant, which is the main advantage
2017-10-25 21:01:03 +13:00
0b4ae2b1a5
prevent scrollbox from getting squished to 0 rows
2017-10-25 20:50:53 +13:00
08e51b87ae
move some listboxs inside their padding
2017-10-20 15:51:01 +13:00
5405abecc3
Add a scrollbar to our custom listbox implementation.
...
It's pretty ugly for now.
2017-10-20 15:47:32 +13:00
b6a27582c9
redo padding and layout of network views
2017-10-20 14:55:01 +13:00
1db8a1dc40
get rid of padding after header
2017-10-20 14:06:57 +13:00
491ca1e1c0
Indicate which network config method is active.
2017-10-12 11:01:33 -04:00
5507fd0fbc
clunky way of indicating which network config method is active
2017-10-11 21:35:10 +13:00
ae1b8c2e66
Import i18n module before use.
2017-10-09 17:28:21 +00:00
68b9f6f1be
add a way to run console-conf or subiquity with a subset of the screens
2017-10-09 09:24:32 +13:00
f5637a717e
a start at a more sophisticated ssh identity widget
2017-10-06 15:39:14 +13:00
b06d1a78c4
improve validation of hostname and username fields
...
not sure hostname validation makes perfect sense but at least it is a bit
more transparent now
2017-10-05 22:14:44 +13:00
1bfb42c9b8
allow the same set of characters in realname as accepted by chfn -f
2017-10-05 16:33:26 +13:00
a73b76c7d2
clear any validation error as soon as the field becomes valid
...
this is why I changed size's validation to be side-effect free in the last
commit...
2017-10-05 16:19:31 +13:00
876e2dc1b7
change partition size field to only modify user input explicitly on loss of focus
2017-10-05 16:16:31 +13:00
eafd614ce9
simplify things a bit by removing the ability to pass validator= and cleaner= to form fields
2017-10-05 15:45:16 +13:00
35988f2fd9
change form machinery to always have space for validation error
...
and display help, if present, there by default
2017-10-05 15:08:10 +13:00
d35a7e08d8
Merge pull request #248 from CanonicalLtd/mwhudson/better-colors
...
color tweaks
2017-09-28 17:28:42 -04:00
2c6fb9ed99
hide network error if showing before starting config again
2017-09-28 16:00:35 -04:00
cd85358a1b
overwrite more of the console palette
2017-09-28 09:58:09 -04:00
86ac32905b
change the progress bar to show x / y rather than a %age
...
Also make its progress more automatic.
2017-09-26 09:01:22 -04:00
b60c0d33f5
have enter advance to the next focus item in piles and listboxes
2017-09-21 15:30:50 +12:00
785b4d5568
Fix up more fixed layouts with button_pile().
2017-09-20 14:01:42 +01:00
Michael Hudson-Doyle