812f33cab6
default to setting up LVM in guided storage screen
2020-05-13 16:34:35 +12:00
24abf5dd4e
fix some lint found by new version of flake8
2020-05-12 10:41:54 +12:00
a05b030085
fix lint
2020-05-08 15:44:07 +12:00
21ed91d7d3
add comments, contexts for some translatable strings
...
from scanning though about one third of subiquity.pot
2020-05-08 15:40:59 +12:00
59c47254e7
use pgettext in one place, add support for extracting it
2020-05-08 15:13:15 +12:00
33bdc90780
copy gettext.py from python 3.8 and use it
2020-05-08 15:09:46 +12:00
3060a03bd6
make some things slightly better
2020-05-08 15:06:24 +12:00
2d65fe4f16
attempt to make providing a good translation easier
...
* annotate a few missed string literals with _()
* try to consistently use named placeholders when formatting strings
for display (i.e. _("frob the {thing}") not _("frob the {}")
* run selector values, form captions and form help through _() before
display
* use ngettext in one place. not sure if there need to be more...
* reduce cuteness about how strings are constructed in a few places
2020-05-06 21:16:24 +12:00
4e3996f3f8
improve with_context helper a bit, use it more
...
the decorated function must now be called with keyword arguments
2020-05-05 16:20:03 +12:00
4891d76aca
actually write the netplan from the autoinstall config to the target system
...
I got lost in a forest of similarly named methods :(
2020-05-04 19:37:43 +12:00
bc37b2c628
add a helper to make it easier to next contexts appropriately
...
i want this to help debug another branch i am working on!
2020-05-04 18:44:47 +12:00
d15e5f25fa
remove mistakenly added backup files
2020-05-01 13:45:59 +12:00
5dc2895481
add the ability to remove a particular overlay, not just the top one
2020-05-01 12:46:45 +12:00
7e9c1412b9
introduce and use a state_path helper for finding things in /run
2020-05-01 09:58:06 +12:00
37a62f21aa
fix travis some more
2020-04-30 20:56:09 +12:00
b66ad552f8
make default_netplan valid, for some reason this causes issues sometimes on travis
2020-04-30 20:25:14 +12:00
6007b4dc41
do not crash in a terminal < 76 columns wide
...
for https://bugs.launchpad.net/ubuntu-z-systems/+bug/1874314
2020-04-28 21:32:46 +12:00
88165ce5fd
use a cleaner way of attaching controllers to contexts
2020-04-24 14:45:20 +12:00
9ff059eae7
put zdev rows directly in a listbox, not in a pile in a listbox
...
this required adding TableListRow.set_contents.
it fixes (partly by accident) a crash when a row becomes unselectable
after a refresh (https://bugs.launchpad.net/subiquity/+bug/1874114 ), it
also makes the home and end keys do something sane.
really this view should not rebuild every row on any change, but that's
something for another day.
2020-04-22 15:36:06 +12:00
760fbaa22f
Review comments
2020-04-16 00:22:52 +01:00
a70d309f6a
Use common palette.
...
Fixes header frindge colors in console-conf.
2020-04-09 12:20:16 +01:00
f3b1a70822
Merge pull request #692 from bboozzoo/bboozzoo/chooser-tweaks
...
console_conf: various recover chooser tweaks
2020-04-09 10:59:39 +01:00
a33a477324
subiquitycore/core: fix typo in comments
...
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
2020-04-07 15:35:47 +02:00
9a11e90719
attach a controller to most contexts
2020-04-07 21:51:11 +12:00
246570314a
pass the context object to report_start_event / report_finish_event
2020-04-07 21:51:11 +12:00
81b6f8a90a
if netplan apply fails show an error rather than crashing the ui
2020-04-07 12:16:53 +12:00
00e33ae0e1
include ssh host key details in ssh help
2020-04-06 14:10:26 +12:00
4101440814
a bigger hammer
2020-04-03 13:47:29 +13:00
fa476d54cc
treat virtual network devices a bit more like physical ones
...
in particular: have subiquitycore.netplan understand them. The goal of
all this is to make the recent change to not delete virtual interfaces
if their configuration has not changed actually work.
2020-04-03 10:12:42 +13:00
9bcf507b7c
subiquitycore: do not assume that stdin is /proc/self/fd/0
...
The KeyCodesFilter assumed that /proc/self/fd/0 is actual stdin and proceeded to
toy with that fd. This broke the recovery mode chooser where console-conf is fed
a list of recovery systems over stdin. The `sys.stdin` is already correctly
updated to use the real tty and that should be used elsewhere instead of
hardcoding the fd number.
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
2020-04-02 13:08:16 +02:00
a03a336bd7
translate concurrent.futures.CancelledError to asyncio.CancelledError
...
apparently cancelling something that is running in a thread leads to a different
exception class being raised...
2020-04-02 12:15:06 +13:00
590b4b8f23
Merge pull request #655 from bboozzoo/bboozzoo/uc20-recovery-chooser
...
console_conf: implement UC20 recovery chooser
2020-04-01 22:05:30 +01:00
cab565304a
write netplan directly to the target
...
rather than via curtin and then cloud-init
2020-04-01 19:37:02 +13:00
93ac6b94a3
Merge remote-tracking branch 'upstream/master' into bboozzoo/uc20-recovery-chooser
2020-03-31 17:14:28 +02:00
d717375d9c
apply network autoinstall config
2020-03-31 15:58:18 +13:00
d97bf081ea
Only delete virtual devices when config has changed
2020-03-26 21:26:34 +00:00
5d77d71499
subiquitycore: allow overriding input/output when creating screens
...
The interaction with snap-recovery-chooser happens over stdin/stdout. The early
setup code in console-conf will attempt to restore sys.stdin/sys.stdout and hook
them up to the current tty.
The patch allows passing input/output streams explicitly as parameters to the
constructors.
Also, default to sys.stdin/sys.stdout and pass both streams explicitly when
constructing urwid.raw_display.Screen(), to workaround the bug in their
constructor. THe constructor is defined as follows:
class Screen(BaseScreen, RealTerminal):
def __init__(self, input=sys.stdin, output=sys.stdout):
What means, that even if we override sys.stdout/sys.stdin globally in our setup
code, this will have no effect as `input` and `output` already got their values.
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
2020-03-24 13:32:52 +01:00
3856a11186
fix deleting virtual network devices
2020-03-20 09:18:25 +13:00
cc52bb62a5
fix enabling dhcp on a virtual interface
2020-03-20 09:17:29 +13:00
7596e63a9f
pass **kw args to arun_command in run_command_in_foreground
...
this makes the debug shell run in / rather than /snap/subiquity/whatever
2020-03-17 12:23:06 +13:00
b4ab4d8f1b
Only mark definitively seen screens as configured.
...
Mark a screen as configured if:
- last-screen is present
- the screen was before the screen last-screen indicates
2020-03-16 16:37:25 +13:00
94611c58e2
remove last-screen file before restarting or exiting
...
unless we are restarting because of a snap refresh.
ths lead to all kinds of confusion after e.g. a ui crash after a snap refresh
2020-03-16 16:37:16 +13:00
99218fbeb4
support early and late commands
2020-02-04 14:03:59 +13:00
963cbaaafe
refactor how subiquity is exited after install
...
if we want to do things after install has completed (e.g.: run late
commands), we can't have the code that runs the install invoking
/sbin/reboot directly.
2019-12-20 13:54:34 +13:00
f925c3fa2a
Merge pull request #622 from mwhudson/make_screen-method
...
make screen behaviour more configurable
2019-12-20 13:09:57 +13:00
a40082a29b
Merge pull request #621 from mwhudson/controller-set-tweaks
...
tweak ControllerSet
2019-12-20 13:01:04 +13:00
78d59de8c6
only call setraw if the screen is talking to a tty
2019-12-20 12:48:27 +13:00
039b5313c4
move make_screen into a method
2019-12-20 12:47:37 +13:00
ab6fdeb1b5
tweak ControllerSet
...
* add a way to load just one controller
* fetch the RepeatedController class from a projet specific location
neither used yet, but soon
2019-12-20 12:43:42 +13:00
cb52ab75a2
use the asyncio loop object rather than the urwid loop almost everywhere
2019-12-20 12:04:38 +13:00
cfc38e1c1b
make all subiquity controllers used inherit from SubiquityController
...
There is going to be a chunk of subiquity specific functionality coming
for autoinstalls, this gives us somewhere to put it.
2019-12-20 11:41:12 +13:00
570472315d
Add SingleInstanceTask.wait
...
this can be called without having to worry about the task being
cancelled out from under you
2019-12-20 11:00:46 +13:00
45478b68a4
add a way to change the default level of a context's children
2019-12-20 09:47:38 +13:00
a91dff2b14
add a way to log a dialog open/close, use it for network dialogs
2019-12-20 09:47:38 +13:00
4be25fc78f
log applying network config via context
2019-12-20 09:47:36 +13:00
1f1937b03f
report progress through screens via context
2019-12-20 09:46:26 +13:00
fa39f10651
fix answers
2019-12-20 09:46:26 +13:00
5961b68b7d
introduce a Context object for logging start/stop events
2019-12-20 09:46:26 +13:00
0c268f6c22
fix case where NIC does not get DHCP address
2019-12-19 16:06:56 +13:00
904c0e3179
Merge pull request #613 from mwhudson/model-events
...
stop using urwid signals to coordinate installation
2019-12-17 02:11:32 +00:00
ca1635a1f9
a bit of refactoring
2019-12-17 15:05:17 +13:00
dce0f10c10
Merge guided method & disk selection into one screen. ( #588 )
...
Merge guided method & disk selection into one screen.
2019-12-17 12:59:03 +13:00
29c9f0878b
indent a "raise" properly
2019-12-17 11:28:42 +13:00
4bcb0e5fd1
Merge pull request #609 from mwhudson/less-signalling
...
stop some pointless use of urwid signals
2019-12-16 19:38:45 +00:00
42343d665f
Merge pull request #601 from mwhudson/more-async-refresh
...
make the refresh view code use asyncio apis
2019-12-16 12:33:22 +00:00
c067e5e741
Merge pull request #606 from mwhudson/prober-fail-lower
...
push debug_flag block probe crashing into Prober
2019-12-16 12:27:16 +00:00
33af65bde1
make --screen command line option do something again
2019-12-16 23:17:21 +13:00
324dddac94
push debug_flag block probe crashing into Prober
2019-12-16 23:15:48 +13:00
01e5261b3f
kill off other top level signals
2019-12-16 23:09:17 +13:00
2765e6a773
replace next-screen/prev-screen signals with method calls
2019-12-16 23:02:03 +13:00
7e7ca080f6
Merge pull request #604 from mwhudson/tab-cycling-oddity
...
fix tab-cycling between header and body
2019-12-16 21:37:20 +13:00
7b697a1978
Merge pull request #602 from mwhudson/selector-non-text
...
allow Selector to have non-text entries
2019-12-16 21:36:45 +13:00
b41560fc4c
fix tab-cycling between header and body
2019-12-16 21:32:25 +13:00
9736825e32
simplify SubForm stuff a bit
2019-12-16 21:21:57 +13:00
6913294de6
EXTREMELY OBSCURE fix
...
without this, selectors get skipped over when selecting the first element in a
pile if the label is some kind of container.
2019-12-16 21:15:46 +13:00
9759957f36
allow Selector to have non-text entries
2019-12-16 13:28:42 +13:00
de18cc977f
make SingleInstanceTask.start_sync set self.task synchronously
2019-12-16 12:33:19 +13:00
5173e46b33
Merge pull request #600 from mwhudson/fix-probing-failures
...
stop block probing failures from crashing the process
2019-12-15 09:53:47 +13:00
fe08311c19
stop block probing failures from crashing the process
...
There is a common problem in concurrent / asynchronous code of what to
do with unhandled exceptions. If a (conceptual) thread of execution
fails, there's no guarantee (and no way of telling) if there's anything
listening. By default, I chose to have a failing task propagate the
exception up to the run loop for two reasons:
1) Unhandled exceptions are generally bad
2) urwid.ExitMainLoop needs to be propagated to the run loop to have
any effect
But this means that tasks that are expected to fail (and have this
failure handled) like block probing crash the process, which is
obviously a Bad Thing. This branch adds a way to turn off exception
propagation per-task, which is a bit hackish but works ok it seems.
2019-12-15 09:45:14 +13:00
bd3ede4c21
Merge pull request #595 from mwhudson/remove-run_in_bg
...
remove run_in_bg
the asyncioification is complete (apart from bug fixes)
2019-12-15 09:44:09 +13:00
6d4ea2bf34
Merge pull request #596 from xnox/uc20
...
Unbreak console-conf in UC20 images
2019-12-15 09:04:03 +13:00
ae5cd6268a
kill off run_in_bg and some related hacks
2019-12-15 08:53:37 +13:00
a92b88ed9d
asyncioify run_command_in_foreground
2019-12-15 08:53:36 +13:00
d6689d9200
Merge pull request #594 from mwhudson/asyncio-ssh
...
asyncioify ssh
2019-12-14 16:48:55 +00:00
b4ff1bde70
Merge pull request #599 from mwhudson/radiobuttonfield
...
add a RadioButtonField for forms
2019-12-14 16:47:29 +00:00
a2fc6da694
add a RadioButtonField for forms
2019-12-14 22:35:19 +13:00
285eeee0ed
Merge pull request #598 from mwhudson/repeatedcontroller-index
...
fix RepeatedController
2019-12-14 22:16:07 +13:00
0090aec3be
fix RepeatedController
...
a snap update was offered the second time even if it had been
offered already
2019-12-14 21:44:10 +13:00
5571e1fab3
add a class for controllers with no ui
...
there will be a bunch of these coming for autoinstall
2019-12-14 21:27:39 +13:00
d19e405666
Unbreak console-conf in UC20 images
2019-12-14 03:00:17 +00:00
05a61544fb
asyncio.create_subprocess_exec defaults stdin to None
2019-12-13 11:44:12 +13:00
992e131b5f
squash all exceptions when cancelling the task in SingleInstanceTask
...
otherwise restarting a failed task just raises the exception from the previous
failure
2019-12-13 10:05:23 +13:00
4e1afd60a4
do not always stop networkd
2019-12-13 10:04:57 +13:00
b155d3eff0
have apply_config task exit as soon as all dhcp NICs have an address
2019-12-13 10:04:31 +13:00
08e081415d
move async_helpers to subiquitycore
2019-12-13 10:04:02 +13:00
5a7abd99b7
only run network answers once
2019-12-13 10:03:46 +13:00
eb228ab7f3
introduce a helper for a restartable task
...
(there are going to be a few of these)
2019-12-13 10:03:32 +13:00
2d1bd0011d
a little refactoring
2019-12-13 09:40:15 +13:00
a260bebc0b
rip out TaskSequence
2019-12-13 09:39:48 +13:00
19f8f91d29
asyncify network controller
2019-12-13 09:39:13 +13:00
efed69ff7c
some asyncifying of network
2019-12-13 09:37:36 +13:00
b65a8177a3
Merge pull request #591 from mwhudson/asyncio-installation
...
asyncioify installation
2019-12-13 09:14:13 +13:00
4c84bb6494
add a form field that has another form as its widget
2019-12-12 23:20:12 +13:00
05c4fa4403
add a way for a form field not to have space for help
2019-12-12 23:19:46 +13:00
d8746ce75e
add a way for a form field to not have a caption
2019-12-12 23:19:09 +13:00
f549883f80
tweak some log levels
2019-12-12 21:57:20 +13:00
d08cce4970
create an INFO level log file too, unconditionally include it in error reports
2019-12-12 21:49:44 +13:00
3d80f46225
asyncioify the installation
2019-12-12 15:19:22 +13:00
297d7c2060
add Application.select_screen
...
SubiquityUI will want to override this for autoinstally things
2019-12-12 10:38:04 +13:00
fb2f322544
tidy up next/prev_screen
2019-12-12 10:38:04 +13:00
64378cdb95
refactor how controllers are stored a bit
2019-12-12 10:38:03 +13:00
b3c013907b
Merge pull request #586 from mwhudson/restart-after-update
...
remove last-screen file before restarting subiquity
2019-12-12 09:19:54 +13:00
411a78ccb3
steal the fix for https://github.com/urwid/urwid/issues/235
...
the symptom of the bug fixed is that exceptions that crash the process
do not get reported sensibly.
2019-12-11 23:21:11 +13:00
932f703c7a
remove last-screen file before restarting subiquity
...
this fixes a crash loop when the users updates the subiquity snap
then hits an install failure and selects restart
2019-12-11 23:17:16 +13:00
cac9cba8ec
asyncio.create_subprocess_exec does not support check=True
2019-12-11 15:02:18 +13:00
f805a9d9dd
add a convenience wrapper
2019-12-11 14:39:48 +13:00
864e09cc99
use asyncio event loop and a little asyncio api
2019-12-11 14:39:25 +13:00
ac071ec9bf
Merge pull request #574 from mwhudson/error-report-ui
...
first cut at error report ui
2019-11-18 12:30:50 +13:00
73b53f2bf3
stop caching probed storage data
...
A recent branch carefully called Prober.get_storage() whenever a udev
block device event was seen. But Prober.get_storage() cached the results
from probert rendering that useless. Rip the caching and some other
complexity out of the prober class.
2019-11-13 10:07:51 +13:00
615dc1b1dd
show an unseen ui crash on startup
2019-11-08 13:36:30 +13:00
6d3f014f7a
simple view of a crash report
2019-11-08 13:36:30 +13:00
74ef2ad8f6
add a way to create a crash report
2019-11-07 14:47:18 +13:00
54823e364c
remove signal sent after debug shell exits
2019-11-04 23:52:49 +13:00
4798348740
Merge pull request #567 from mwhudson/restricted-saved-probing
...
implement restricted probing for canned probert data
2019-11-04 10:44:18 +13:00
ca02972195
add a controlled way to make various things fail
...
In dry-run mode, treat SUBIQUITY_DEBUG as a comma-separated list of
things to fail:
* install-fail: curtin install fails
* copy-logs-fail: the postinstall copying of logs fails
* bpfail-full: full block device probing fails
* bpfail-restricted: restricted block device probing fails
In addition, control-u makes the UI crash in dry-run mode.
(This is all for testing of crash report generation but does not depend
on that).
2019-11-04 10:43:29 +13:00
d56b72b35b
implement restricted probing for canned probert data
2019-10-31 13:39:01 +13:00
a3734cda03
wrap actionmenu/selector popups in Color.body
...
this fixes a slight visual glitch in gnome-terminal
2019-10-16 12:50:44 +13:00
f2918fa30b
Merge pull request #550 from mwhudson/reprobe-block-devices-on-shell-exit
...
Reprobe block devices on debug shell exit
2019-10-09 15:37:23 +13:00
3e39db4013
Asciify color pallete
2019-10-07 22:30:23 +01:00
3f548665e1
Add ASCII mode
2019-10-04 17:17:26 +01:00
7a3a88ab0c
add a signal that is fired when a debug shell exits
2019-10-04 15:10:11 +13:00
36cdf0effd
some better names
2019-10-04 13:39:39 +13:00
415db68e36
always use vt100 codes for white/black/default
...
For maximum compatibility in mono mode.
2019-10-04 13:39:39 +13:00
cea3a65ca1
refactor how palettes and colors and screens are set up
2019-10-04 13:39:39 +13:00
29c9e0c984
add a hot key (f4) for turning color on and off
2019-10-04 13:39:39 +13:00
d2f996732f
Don't mark a dash as translatable
2019-10-02 11:45:34 -07:00
34034e4a79
Don't mark 'DHCPv{v}' as translatable
2019-10-02 11:40:58 -07:00
9ece5d2222
implement local documentation
2019-10-02 10:51:34 +13:00
0c4d809c05
Have the help button open a help menu.
...
None of the items do anything yet though.
2019-10-02 10:48:58 +13:00
70bb4ab5dd
add [ Help ] button to header
2019-10-02 10:48:35 +13:00
3450078f4b
Merge pull request #542 from mwhudson/log-file-per-pid
...
create one log file per invocation
2019-10-02 10:29:25 +13:00
93732dfb73
fix run_command_in_foreground to disconnect from stdin while in backgound
...
Not sure how I didn't notice this when implementing it for the first
time but well. This is all fairly confusing.
2019-09-30 16:26:24 +13:00
fb6ea590a5
still create a subiquity-debug.log symlink
2019-09-30 16:21:42 +13:00
7c1154b758
create one log file per invocation
...
Log to subiquity-debug.log.$PID instead of just subiquity-debug.log.
When we implement error reports we'll obviously attach the log to the
error report. There's no point adding log messages from previous runs of
subiquity.
2019-09-30 13:47:56 +13:00
a2ccb0cd9e
remove all remaining footer-related things
2019-09-30 09:32:23 +13:00
a96c5c8805
Make header narrower, move right_icon into header.
2019-09-30 09:32:07 +13:00
d8d5b2e265
remove the footer
2019-09-27 14:31:34 +12:00
c442a166ca
Merge pull request #537 from mwhudson/log-sanity
...
clean up logging a touch
2019-09-26 11:57:27 +12:00
947f14a0af
move stretchy signals from overlay to stretchy itself
...
Also add overridable opened/closed hooks.
2019-09-12 21:36:40 +12:00
d0151deec0
some more logging statements to follow user around the ui a little more
2019-09-09 15:33:45 +12:00
Michael Hudson-Doyle