Michael Hudson-Doyle
960f51ca91
remove view argument to Form.as_rows and friends
2018-05-07 10:57:35 +12:00
Michael Hudson-Doyle
fa8f8d32f5
down all network links that have changed config before applying it
...
this means that if you enter a broken config, it breaks as it should
2018-05-03 12:14:06 +12:00
Michael Hudson-Doyle
fe671d8d9b
fix rendering of nic info if dhcp failed but has addresses of other family
...
This bug has been here forever! Oh well.
2018-04-27 14:56:30 +12:00
Michael Hudson-Doyle
7d704f83f0
mark even more strings as translatable
2018-04-19 13:09:00 +12:00
Michael Hudson-Doyle
028914da97
another small helper
2018-04-09 14:37:26 +12:00
Michael Hudson-Doyle
a723d25a4c
create a helper to create a common screen layout
2018-04-09 14:30:59 +12:00
Michael Hudson-Doyle
0fc83c4bc1
simplify a bunch of views
...
i am slowly getting better at urwid...
2018-04-09 14:10:36 +12:00
Michael Hudson-Doyle
8287d695dc
fix live updates of network screen
2018-03-16 15:30:14 +13:00
Michael Hudson-Doyle
1f937090c0
update help text for address
2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle
ca953ea01f
improve scrolling experience
...
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).
The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.
As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
Michael Hudson-Doyle
4a5e3b3815
stop showing >s on network config choices that do not lead to a new screen
2018-02-20 10:32:51 +13:00
Michael Hudson-Doyle
306978ee79
cursor positioning nerdery on network config screen
2018-02-20 10:29:24 +13:00
Michael Hudson-Doyle
c9f3bd3ae0
fix behaviour of "up" on views that have done initially focused
...
before this, if you press up on e.g. the network view, focus would go to the first nic
not the last as you might expect. this is pretty obscure but oh well. such is urwid.
2018-01-11 11:50:08 +13:00
Michael Hudson-Doyle
d77b4148ef
expand NetworkConfigureIPv4InterfaceView tests a bit
2017-12-11 09:52:36 +13:00
Michael Hudson-Doyle
67611165df
fix network manual view and add super simple test of it
2017-12-08 09:41:51 +13:00
Michael Hudson-Doyle
c85602527e
stop any of the *_btn functions defining a label by default
2017-11-22 13:53:35 +13:00
Michael Hudson-Doyle
08e51b87ae
move some listboxs inside their padding
2017-10-20 15:51:01 +13:00
Michael Hudson-Doyle
b6a27582c9
redo padding and layout of network views
2017-10-20 14:55:01 +13:00
Mathieu Trudel-Lapierre
491ca1e1c0
Indicate which network config method is active.
2017-10-12 11:01:33 -04:00
Michael Hudson-Doyle
5507fd0fbc
clunky way of indicating which network config method is active
2017-10-11 21:35:10 +13:00
Michael Hudson-Doyle
2c6fb9ed99
hide network error if showing before starting config again
2017-09-28 16:00:35 -04:00
Dimitri John Ledkov
785b4d5568
Fix up more fixed layouts with button_pile().
2017-09-20 14:01:42 +01:00
Michael Hudson-Doyle
14fa3cd107
use button_pile helper everywhere
2017-09-20 15:20:32 +12:00
Michael Hudson-Doyle
f000fc24eb
add a helper to pad a pile of buttons just enough
2017-09-20 14:55:02 +12:00
Michael Hudson-Doyle
9356501aa7
change cancel buttons to back buttons where appropriate
...
and also some "Done" buttons become "Save" buttons.
2017-09-18 17:19:27 +01:00
Dimitri John Ledkov
693f3e7c7d
Barebones i18n setup.
2017-09-18 14:14:39 +01:00
Dimitri John Ledkov
648d7d4086
Buttons
2017-09-18 14:01:11 +01:00
Michael Hudson-Doyle
91d57c50f2
a slightly different approach
2017-09-15 10:40:11 +12:00
Dimitri John Ledkov
7c5e55e0b2
Update color palette
...
Create palette for traffic light buttons: green (default), amber and
red. Color-code most buttons.
Make all progressbars orange for the completed part.
2017-09-12 12:05:44 +01:00
Michael Hudson-Doyle
1b328dbb61
work around urwid crash
...
see https://github.com/urwid/urwid/issues/253
2017-09-08 12:36:44 +12:00
Michael Hudson-Doyle
e0f75ba013
tweaks to network views
...
1) move the done / cancel buttons (and error display) out of scrolling region
2) focus done by default
3) update footer texts to make sense
4) use a bit more of the horizontal space to show interface information
2017-09-08 09:48:41 +12:00
Michael Hudson-Doyle
9afd3cbc5a
have escape always remove an overlay view
2017-04-05 15:20:36 +12:00
Michael Hudson-Doyle
395b30451e
stop being clever in handling of escape in network screens
2017-04-05 14:36:46 +12:00
Michael Hudson-Doyle
f8211b56fb
clean up wifi config view code a bunch
...
(this was the first complicated urwid code i wrote)
2017-03-21 14:47:01 +13:00
Michael Hudson-Doyle
62ad81d690
make sure wifi psk is between 8 and 63 characters long
2017-03-21 14:39:23 +13:00
Michael Hudson-Doyle
26c1af8328
allow the gateway to be empty for an interface
2017-03-20 14:51:41 +13:00
Michael Hudson-Doyle
404ca627da
use evilnick's wording on the network page
2017-03-02 13:52:20 +13:00
Michael Hudson-Doyle
2a1fbcd6fe
remove some help leftovers
2017-02-16 12:36:26 +13:00
Michael Hudson-Doyle
308a29c75b
move help to an overlay
2017-02-14 16:16:19 +13:00
Michael Hudson-Doyle
65f9d1ef62
move show_overlay to BaseView
2017-02-14 16:16:19 +13:00
Michael Hudson-Doyle
a6954b49e2
the various editor classes' caption argument is optional now
2017-02-14 15:19:56 +13:00
Michael Hudson-Doyle
906af4d41a
simplify forms and edit widgets a bit
2017-02-14 15:16:12 +13:00
Michael Hudson-Doyle
3353c851ee
make help appear in same place on identity view as before
2017-02-13 15:50:39 +13:00
Michael Hudson-Doyle
ee966f7039
rewrite validation stuff into something like a form library
...
This is inspired by the sort of design e.g. Django uses for its forms.
2017-02-13 14:21:26 +13:00
Michael Hudson-Doyle
af2bfc40ef
fix mismerge
2017-02-10 15:42:43 +13:00
Michael Hudson-Doyle
9854d5ccce
Merge remote-tracking branch 'origin/master' into mwhudson/ipv4-validation
2017-02-08 16:10:36 +13:00
Michael Hudson-Doyle
f0eb2cdf70
make Color.button etc apply the corresponding focus map
...
about 1e6 times more readable
2017-02-08 15:37:18 +13:00
Michael Hudson-Doyle
ebddb50483
better validation for manual network view
2017-02-08 13:18:20 +13:00
Michael Hudson-Doyle
0627bfe9f4
start to add validation to manual network view
2017-02-08 13:18:20 +13:00
Michael Hudson-Doyle
3c5ac3140f
use new containers everywhere
2017-02-03 14:21:39 +13:00
Michael Hudson-Doyle
d75cbabb61
move subiquity welcome stuff out of subiquitycore
2017-01-17 12:04:15 +13:00
Michael Hudson-Doyle
0caf13181e
Do not say a netdev is not configured when there is no configuration
2017-01-11 15:42:16 +13:00
Michael Hudson-Doyle
ae05b66a47
rewrite Selector to work like an HTML <select> widget
...
This was way way harder than it seemed like it should be, but it seems a lot
nicer to me.
For https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1654387
2017-01-09 16:11:32 +13:00
Mathieu Trudel-Lapierre
09b8235b07
Fix displaying IPs for login view in subiquitycore.
2016-12-21 17:18:08 -05:00
Mathieu Trudel-Lapierre
01c42205f0
Fix identity controller for subiquity; correctly process done signal and displaying local user info.
2016-12-20 15:40:28 -05:00
Michael Hudson-Doyle
21d3f78c9c
use a IPv6 example address on manual ipv6 screen
2016-12-15 14:17:49 +13:00
Michael Hudson-Doyle
38c600528b
remove some of the ip-version-in-method-name methods
2016-12-12 15:58:41 +13:00
Michael Hudson-Doyle
4de99bd41e
use the ip version as a parameter a bunch more
2016-12-12 15:54:33 +13:00
Michael Hudson-Doyle
2a716df0ad
add and use NetworkConfigureIPv6InterfaceView
2016-12-12 15:45:45 +13:00
Michael Hudson-Doyle
8582e2bc02
network_configure_manual_interface.py -> network_configure_ipv4_interface.py
2016-12-12 15:41:30 +13:00
Michael Hudson-Doyle
be69509efa
parameterize NetworkConfigureIPv4InterfaceView
2016-12-12 15:40:07 +13:00
Michael Hudson-Doyle
1efaed7648
add network model interfaces that take ip version as a parameter
2016-12-12 15:34:59 +13:00
Michael Hudson-Doyle
15bb9afcc2
move identityview to subiquity
...
subiquity and console-conf do not share any view code any more
2016-11-23 09:54:36 +13:00
Michael Hudson-Doyle
7c90a9e4da
Fix crash when an interface has more than one IP address of the same family.
2016-11-11 11:29:57 +13:00
Michael Hudson-Doyle
344b177f16
validate user input a lot more thoroughly in the static ipv4 view
2016-11-08 11:07:20 +13:00
Michael Hudson-Doyle
a7bfef3646
show error message from netplan generate when it fails
2016-11-08 10:39:54 +13:00
Michael Hudson-Doyle
8a44befe2a
remove UI for customizing default route, not supported by netplan
...
Yet, anyway.
2016-11-08 10:39:05 +13:00
Michael Hudson-Doyle
31b21799b7
remove dependency on netifaces
2016-11-07 16:56:36 +13:00
Michael Hudson-Doyle
c4fdf5cb72
allow choosing from visible networks when configuring wifi
2016-11-07 16:56:36 +13:00
Michael Hudson-Doyle
cacd456a6a
Adapt to netlink event driven version of probert.
2016-11-07 16:56:32 +13:00
Michael Hudson-Doyle
82b11dbd69
reorganize the network model and make the UI a bit more consistent
...
The main change here is to separate the state a network device is in and the
state we want it to be in. So it now parses the netplan config on a system as
well as probing the state of via probert.
The UI is changed to make this distintion too, and be IMO a bit more
consistent. Somewhere in this I've removed the display of whether the
probed address was found via DHCP or not, possibly that should be put
back if it doesn't make things too cluttered.
In dry-run mode, we now still write the config and feed it to netplan, but
in a way that doesn't affect the system we are running it on.
2016-11-07 15:15:46 +13:00
Michael Hudson-Doyle
6b99559819
oops
2016-11-02 12:14:01 +13:00
Michael Hudson-Doyle
91e42e37bd
Merge branch 'master' into mwhudson/kill-some-signals
2016-11-02 12:00:47 +13:00
Michael Hudson-Doyle
6318de27cf
make sure selecting dhcp after manual configuration clears out gateway & nameserver config
2016-10-21 08:59:34 +13:00
Michael Hudson-Doyle
6d93221a43
do not add empty strings to nameservers or search_domains
2016-10-21 08:59:09 +13:00
Michael Hudson-Doyle
7edcf3bcb7
UI for entering name servers/domains
2016-10-20 22:31:10 +13:00
Michael Hudson-Doyle
f603207d94
remove most trivial use of signals from console-conf's flow
2016-10-11 12:48:28 +13:00
Michael Hudson-Doyle
e348207597
Remove most use of signals from welcome and network views.
2016-10-10 16:47:42 +13:00
Michael Hudson-Doyle
0bd33b7074
fix subiquity side again
2016-09-29 12:29:21 +13:00
Michael Hudson-Doyle
d9095336e5
do not have controllers (or view code!!) know the order of the screens
2016-09-27 21:35:47 +13:00
Michael Hudson-Doyle
dad0e10912
completely separate menu -> signal and signal -> method mappings
...
and put the signal -> method mapping into the controller
this breaks the subiquity part even more than before, but it's pretty broken
already.
2016-09-27 20:53:17 +13:00
Michael Hudson-Doyle
e765538c95
address some UI comments from Mark
2016-09-20 14:13:31 +12:00
Michael Hudson-Doyle
f78cae64bd
Show if a link is not connected.
...
At least as well as ip(8) does it.
2016-09-16 14:28:40 +12:00
Mathieu Trudel-Lapierre
e608362b34
Merge pull request #154 from CanonicalLtd/mwhudson/wifi-ui
...
Add a basic UI for entering wifi config details.
2016-09-09 15:33:48 -04:00
Michael Hudson-Doyle
bf827db28d
fix scrolling with many interfaces
2016-09-05 21:07:56 +12:00
Michael Hudson-Doyle
313b4d86db
add a word
2016-09-05 20:17:05 +12:00
Michael Hudson-Doyle
97171f6b71
improve UI a bit
2016-09-05 16:55:09 +12:00
Michael Hudson-Doyle
f58d2aa7c0
refactor a bit
2016-09-05 16:38:26 +12:00
Michael Hudson-Doyle
9451d69076
actually do something with the inputted data
2016-09-05 16:25:45 +12:00
Michael Hudson-Doyle
f9668b8802
more low quality UI work
2016-09-05 15:36:59 +12:00
Michael Hudson-Doyle
bf3384596e
a start a configure-wifi ui
2016-09-05 12:03:06 +12:00
Michael Hudson-Doyle
806e3fb86d
do not crash when enabling DHCP on an interface with an address
...
Fixes #141
2016-08-23 13:48:47 +12:00
Michael Hudson-Doyle
0a2546b3bd
do not probe network on returning from network sub-screen
...
otherwise we overwrite our settings with the probed data!
2016-08-23 12:47:55 +12:00
Michael Hudson-Doyle
efa8ef43d2
allow configuration to be canceled
2016-08-22 17:02:42 +12:00
Mathieu Trudel-Lapierre
958ab1a339
Show decent error messages on failure.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-08-18 16:15:28 -04:00
Mathieu Trudel-Lapierre
0c8deeece4
Update padding sizes for prettier output; account for future translations.
2016-08-16 22:15:41 -04:00
Mathieu Trudel-Lapierre
0e93ab3e61
Check we're online, display network error otherwise.
2016-08-16 15:25:58 -04:00
Mathieu Trudel-Lapierre
0e92883a83
Make it a little more obvious where labels are in fact buttons or menus
2016-08-16 15:01:51 -04:00
Mathieu Trudel-Lapierre
10d06a73e4
Allow clearing IP configuration
2016-08-16 14:14:25 -04:00
Mathieu Trudel-Lapierre
11782ced12
Improve handling of the default routes.
2016-08-16 12:59:19 -04:00
Mathieu Trudel-Lapierre
df5e0fcb4c
Try to do something sane to set a default gateway
2016-08-16 01:09:28 -04:00
Mathieu Trudel-Lapierre
cac89c30e9
Do bonding, dhcp toggle, and segregate IPv4 and IPv6 again.
2016-08-16 00:48:15 -04:00
Mathieu Trudel-Lapierre
0f82a12208
Allow setting IPs and rendering as yaml
2016-08-15 17:05:19 -04:00
Mathieu Trudel-Lapierre
18c7e93cc2
WIP: Remove actions, port to an approximation of network yaml v2.
2016-08-13 00:13:22 -04:00
Mathieu Trudel-Lapierre
d73ef34774
Display IPv6 addresses.
2016-08-12 17:55:03 -04:00
Mathieu Trudel-Lapierre
6754a15c93
Allow more than one IPv4 address on an interface, and leave room for IPv6.
2016-08-09 15:11:02 -04:00
Mathieu Trudel-Lapierre
046d3774ba
Revert "Temporary unbreak, but nerf the user logins with email address."
...
This reverts commit 89c9e70501
.
2016-07-28 20:51:48 -04:00
Mathieu Trudel-Lapierre
89c9e70501
Temporary unbreak, but nerf the user logins with email address.
2016-07-28 20:40:14 -04:00
Michael Hudson-Doyle
ac06f25abd
Refactor identity stuff to avoid dep on curtin in console-conf case.
...
A bit verbose perhaps, but works. Now console-conf only depends on curtin for
the network stuff.
2016-07-27 16:05:47 +12:00
Michael Hudson-Doyle
dc11c6a27c
Move function for creating a user to its own file.
2016-07-27 14:52:16 +12:00
Michael Hudson-Doyle
d9f596c994
Move disk and install things from subiquitycore to subiquity.
2016-07-26 16:00:36 +12:00
Michael Hudson-Doyle
04a6d88ffe
rename ViewPolicy to BaseView
2016-07-26 14:21:24 +12:00
Michael Hudson-Doyle
264f698299
Fix flake8 warnings in subiquitycore.
...
Except for line length warnings, because life is too short of that.
A few of these are real bugs.
2016-07-25 14:44:51 +12:00
Mathieu Trudel-Lapierre
1d8c5b3cdb
Deal with the fact there may be no default route for an IP family.
2016-07-06 18:30:43 -04:00
Mathieu Trudel-Lapierre
0205423133
Do a slightly better job at showing default gateways.
2016-07-06 18:14:13 -04:00
Mathieu Trudel-Lapierre
73d73dff94
NetworkView: rework layout for network info based on review.
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 17:24:31 -04:00
Mathieu Trudel-Lapierre
848ccabc7d
console_conf: start initial console-conf tree with a custom controller story
...
And a custom Welcome screen to boot; to show the overriding of settings.
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 14:18:54 -04:00
Mathieu Trudel-Lapierre
e1970b6477
Rename subiquity to subiquitycore -- will serve as base classes for everything
...
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-06-30 14:17:01 -04:00