626488e988
Merge pull request #334 from CanonicalLtd/mwhudson/move-excerpt-title-to-view
...
move excerpt, title and footer from controller to view
2018-05-22 22:38:39 +12:00
f6f214125f
move TaskSequence somewhere more generic
...
I want to reuse it in my containerizing branch.
Improve API and docs a bit while I am looking at it.
2018-05-21 11:52:06 +12:00
11708703c9
move titles, footers, excerpts from controller to view
...
read title and footer from the view instance, make views respsonsible for rendering
the excerpt
adapts infrastructure, welcome, keyboard, network views
2018-05-18 15:55:49 +12:00
960f51ca91
remove view argument to Form.as_rows and friends
2018-05-07 10:57:35 +12:00
fa8f8d32f5
down all network links that have changed config before applying it
...
this means that if you enter a broken config, it breaks as it should
2018-05-03 12:14:06 +12:00
fe671d8d9b
fix rendering of nic info if dhcp failed but has addresses of other family
...
This bug has been here forever! Oh well.
2018-04-27 14:56:30 +12:00
7d704f83f0
mark even more strings as translatable
2018-04-19 13:09:00 +12:00
028914da97
another small helper
2018-04-09 14:37:26 +12:00
a723d25a4c
create a helper to create a common screen layout
2018-04-09 14:30:59 +12:00
0fc83c4bc1
simplify a bunch of views
...
i am slowly getting better at urwid...
2018-04-09 14:10:36 +12:00
8287d695dc
fix live updates of network screen
2018-03-16 15:30:14 +13:00
1f937090c0
update help text for address
2018-03-14 14:58:58 +13:00
ca953ea01f
improve scrolling experience
...
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).
The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.
As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
4a5e3b3815
stop showing >s on network config choices that do not lead to a new screen
2018-02-20 10:32:51 +13:00
306978ee79
cursor positioning nerdery on network config screen
2018-02-20 10:29:24 +13:00
c9f3bd3ae0
fix behaviour of "up" on views that have done initially focused
...
before this, if you press up on e.g. the network view, focus would go to the first nic
not the last as you might expect. this is pretty obscure but oh well. such is urwid.
2018-01-11 11:50:08 +13:00
d77b4148ef
expand NetworkConfigureIPv4InterfaceView tests a bit
2017-12-11 09:52:36 +13:00
67611165df
fix network manual view and add super simple test of it
2017-12-08 09:41:51 +13:00
c85602527e
stop any of the *_btn functions defining a label by default
2017-11-22 13:53:35 +13:00
08e51b87ae
move some listboxs inside their padding
2017-10-20 15:51:01 +13:00
b6a27582c9
redo padding and layout of network views
2017-10-20 14:55:01 +13:00
491ca1e1c0
Indicate which network config method is active.
2017-10-12 11:01:33 -04:00
5507fd0fbc
clunky way of indicating which network config method is active
2017-10-11 21:35:10 +13:00
2c6fb9ed99
hide network error if showing before starting config again
2017-09-28 16:00:35 -04:00
785b4d5568
Fix up more fixed layouts with button_pile().
2017-09-20 14:01:42 +01:00
14fa3cd107
use button_pile helper everywhere
2017-09-20 15:20:32 +12:00
f000fc24eb
add a helper to pad a pile of buttons just enough
2017-09-20 14:55:02 +12:00
9356501aa7
change cancel buttons to back buttons where appropriate
...
and also some "Done" buttons become "Save" buttons.
2017-09-18 17:19:27 +01:00
693f3e7c7d
Barebones i18n setup.
2017-09-18 14:14:39 +01:00
648d7d4086
Buttons
2017-09-18 14:01:11 +01:00
91d57c50f2
a slightly different approach
2017-09-15 10:40:11 +12:00
7c5e55e0b2
Update color palette
...
Create palette for traffic light buttons: green (default), amber and
red. Color-code most buttons.
Make all progressbars orange for the completed part.
2017-09-12 12:05:44 +01:00
1b328dbb61
work around urwid crash
...
see https://github.com/urwid/urwid/issues/253
2017-09-08 12:36:44 +12:00
e0f75ba013
tweaks to network views
...
1) move the done / cancel buttons (and error display) out of scrolling region
2) focus done by default
3) update footer texts to make sense
4) use a bit more of the horizontal space to show interface information
2017-09-08 09:48:41 +12:00
9afd3cbc5a
have escape always remove an overlay view
2017-04-05 15:20:36 +12:00
395b30451e
stop being clever in handling of escape in network screens
2017-04-05 14:36:46 +12:00
f8211b56fb
clean up wifi config view code a bunch
...
(this was the first complicated urwid code i wrote)
2017-03-21 14:47:01 +13:00
62ad81d690
make sure wifi psk is between 8 and 63 characters long
2017-03-21 14:39:23 +13:00
26c1af8328
allow the gateway to be empty for an interface
2017-03-20 14:51:41 +13:00
404ca627da
use evilnick's wording on the network page
2017-03-02 13:52:20 +13:00
2a1fbcd6fe
remove some help leftovers
2017-02-16 12:36:26 +13:00
308a29c75b
move help to an overlay
2017-02-14 16:16:19 +13:00
65f9d1ef62
move show_overlay to BaseView
2017-02-14 16:16:19 +13:00
a6954b49e2
the various editor classes' caption argument is optional now
2017-02-14 15:19:56 +13:00
906af4d41a
simplify forms and edit widgets a bit
2017-02-14 15:16:12 +13:00
3353c851ee
make help appear in same place on identity view as before
2017-02-13 15:50:39 +13:00
ee966f7039
rewrite validation stuff into something like a form library
...
This is inspired by the sort of design e.g. Django uses for its forms.
2017-02-13 14:21:26 +13:00
af2bfc40ef
fix mismerge
2017-02-10 15:42:43 +13:00
9854d5ccce
Merge remote-tracking branch 'origin/master' into mwhudson/ipv4-validation
2017-02-08 16:10:36 +13:00
f0eb2cdf70
make Color.button etc apply the corresponding focus map
...
about 1e6 times more readable
2017-02-08 15:37:18 +13:00
Michael Hudson-Doyle