Commit Graph

3986 Commits

Author SHA1 Message Date
Michael Hudson-Doyle 7b4a7b235c
Merge pull request #968 from mwhudson/kernel-controller
move kernel package selection to its own controller/model
2021-06-03 11:24:27 +12:00
Michael Hudson-Doyle 8e1e1439ae
Merge pull request #966 from mwhudson/fs-labels-reorg
move storage description functionality to singledispatch methods
2021-06-03 11:23:50 +12:00
Dan Bungert 2da973579e Cleanup example data
These examples were crashing dryrun if supplied as a machineconfig due
to the missing blockdev.
2021-06-02 14:54:43 -06:00
Dan Bungert 910e6f9bad
Typo fix 2021-06-02 09:09:19 -06:00
Dan Bungert 49ebdc0300 Merge branch 'main' into fs-labels-reorg 2021-06-02 09:03:16 -06:00
Dan Bungert 1a91ee7a01
github action: s/groovy/impish (#969) 2021-06-02 08:03:16 -06:00
Michael Hudson-Doyle c74b3ccf60 move label tests closer to implementation 2021-06-02 15:20:19 +12:00
Michael Hudson-Doyle a33682f101 replace bios_grub label with (slightly) English words 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle faa9473a25 mark a couple more strings as translatable
even if a translation being provided seems a bit unlikely
2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle 957fd90699 migrate for_client to singledispatch 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle ef81639175 add docstrings to generic functions 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle f68c80cf7d kill off short_label as separate function 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle 3441e5db5c migrate desc and short_label to singledispatch 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle 4ef222ee03 migrate label to singledispatch 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle 7f67f65875 migrate usage_labels to singledispatch 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle 55191bafb5 make annotations a functools.singledispatch 2021-06-02 15:20:18 +12:00
Michael Hudson-Doyle 9564f9ae52 move kernel package selection to its own controller/model 2021-06-02 13:58:53 +12:00
Michael Hudson-Doyle 5b7409750e
Merge pull request #964 from mwhudson/network-error-reports
handle some networking errors better
2021-06-02 13:44:26 +12:00
Michael Hudson-Doyle 8848db87cd change log.error to log.exception when handling a network subsriber call failing 2021-06-02 13:23:44 +12:00
Michael Hudson-Doyle 65a3290a7d add wlan-related methods to API
nothing will call these yet because we are still hiding wlan nics in the
model but it is all simple enough
2021-06-02 13:18:18 +12:00
Michael Hudson-Doyle 6aaa0b70d9
Merge pull request #962 from mwhudson/fs-action-reorg
move DeviceAction stuff to its own file
2021-06-02 13:15:16 +12:00
Michael Hudson-Doyle 1e294a9915 do not crash the server when a call to a network subscriber fails 2021-06-02 13:09:14 +12:00
Michael Hudson-Doyle 4dd7922a80 generate an error report when a network subscription handler fails 2021-06-02 13:09:14 +12:00
Michael Hudson-Doyle c1e9b0a2d7 fix call to make_apport_report on apply_config failure 2021-06-02 13:09:14 +12:00
Michael Hudson-Doyle 47b2836aee pretend virtual wlan (i.e. mac80211_hwsim) devices are real
this allows their use for testing
2021-06-02 12:40:57 +12:00
Michael Hudson-Doyle d14fd35330 move "enabling wifi turns on dhcp4" behaviour to controller from view 2021-06-02 12:40:50 +12:00
Michael Hudson-Doyle 902c57f7f7 move start_scan error handling into controller
report errors via scan_state field
2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle b84fa27752 call apply_config in controller set_wlan method 2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle b046608a78 fix type annotations in network model types 2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle 4850cee5ce NetworkConfigureWLANStretchy.update_link should only care about updates for its nic
this was very confusing to debug!
2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle c325e76e9e fix the wlan view calls to controller methods to pass just the nic name 2021-06-02 12:28:42 +12:00
Michael Hudson-Doyle 7726c14d87 move action tests 2021-05-31 22:59:59 +12:00
Michael Hudson-Doyle b3e124d26f convert all "is this action possible on this device" code over to new style 2021-05-31 22:59:59 +12:00
Michael Hudson-Doyle 22bf1a0321 light refactor 2021-05-31 22:59:59 +12:00
Michael Hudson-Doyle a3588e8fa9 migrate can_EDIT functionality 2021-05-31 22:59:59 +12:00
Michael Hudson-Doyle 997897fa51 convert supported_actions method into a functools.singledispatch 2021-05-31 22:59:59 +12:00
Michael Hudson-Doyle d75af226a5 make subiquity.common.filesystem into a package 2021-05-31 22:59:59 +12:00
Marcus Tomlinson d444177932
Create socket directory from dirname not basename (#961) 2021-05-26 14:57:28 -06:00
Dan Bungert f27c424c8d
Open the permissions on the socket (#959)
* Open the permissions on the socket

Installer clients can be non-root.
Installer clients run in an environment where root is just a
password-less sudo away.

* Same permissions on the other socket also
2021-05-25 18:04:36 -06:00
Dan Bungert 657f27ebf9
Rearrange makefile targets (#960)
Skip a recursive make step and simplify a bit.
Add dryrun-server.
Also an unrelated whitespace fix.
2021-05-25 16:59:22 -06:00
Michael Hudson-Doyle 63fc286644
Merge pull request #958 from mwhudson/lp-1929129
do not crash in server start up if cloud-init is not running
2021-05-21 10:21:21 +12:00
Michael Hudson-Doyle 77576714ff do not crash in server start up if cloud-init is not running
such as desktop (for now) and bionic (oops)
2021-05-21 09:52:56 +12:00
Dan Bungert f1c7c17c19
Don't redundantly remove from the overlay list (#957)
There are two places that remove from this list, and the current arm64
crash is running into a scenario where we try to remove from the
overlays list only to find that it's not actually there.
So don't remove if it's already gone.
2021-05-19 20:18:56 -06:00
Dan Bungert 4f9de12556
Split unit / integration tests a bit (#956)
Unit tests should be quick and run frequently.
Integration tests can be longer and run less often.
Split them up.
2021-05-17 07:31:29 -06:00
Michael Hudson-Doyle 3cbcddb651
Merge pull request #954 from mwhudson/no-apport-hooks-in-dry-run-mode
do not run most apport hooks in dry-run mode
2021-05-14 04:31:14 +12:00
Michael Hudson-Doyle 77343cb160 do not run most apport hooks in dry-run mode
they are slow and can hang in CI
2021-05-14 04:27:25 +12:00
Michael Hudson-Doyle 0de5aec333
Merge pull request #950 from mwhudson/shell-on-autoinstall-fail
offer to run a shell after an autoinstall fails
2021-05-13 10:26:15 +12:00
Dan Bungert d04b6a9a3e
dryrun: use the simple machine config (#952)
`make dryrun` will now use the simple sample machine config instead of
probing local hardware.   That local probe only seems to be viable
anyhow if we're running as root, and that's vulnerable to real problems
if dryrun is less than 100% insulated from making real machine changes.
2021-05-12 16:23:58 -06:00
Michael Hudson-Doyle fcc542d436
Merge pull request #953 from mwhudson/traceback-in-response
include the traceback in the response when a server method fails
2021-05-13 07:00:01 +12:00
Michael Hudson-Doyle 7a6a984578 add a bit in DESIGN.md about how errors work in the API 2021-05-13 06:17:33 +12:00