Michael Hudson-Doyle
6752cb2e68
generalize, simplify core event handling
2020-05-04 18:44:47 +12:00
Michael Hudson-Doyle
bc37b2c628
add a helper to make it easier to next contexts appropriately
...
i want this to help debug another branch i am working on!
2020-05-04 18:44:47 +12:00
Michael Hudson-Doyle
89af2709a7
Merge pull request #748 from mwhudson/fix-install-confirmation
...
fix install confirmation
2020-05-04 18:42:35 +12:00
Michael Hudson-Doyle
d9bed483a6
fix install confirmation
...
this is a global overlay now but i forgot to update its code
2020-05-04 18:32:19 +12:00
Michael Hudson-Doyle
355d08f270
Merge pull request #747 from mwhudson/lp-1876605
...
raid fixes
2020-05-04 15:43:29 +12:00
Michael Hudson-Doyle
4564871ad2
fix tests
2020-05-04 15:28:42 +12:00
Michael Hudson-Doyle
81b459cb99
make spare_devices optional in autoinstall config
2020-05-04 14:18:42 +12:00
Michael Hudson-Doyle
8a84e470c5
make sure the size of a partition gets set to int
2020-05-04 14:16:03 +12:00
Michael Hudson-Doyle
d15e5f25fa
remove mistakenly added backup files
2020-05-01 13:45:59 +12:00
Michael Hudson-Doyle
4359378b3b
Merge pull request #744 from mwhudson/global-overlays
...
add and use the concept of a "global overlay"
2020-05-01 13:38:26 +12:00
Michael Hudson-Doyle
9687f74adb
Merge pull request #745 from mwhudson/update-probert
...
update probert to drop --mknodes from vgscan invocation
2020-05-01 13:37:54 +12:00
Michael Hudson-Doyle
f3a0ba12bd
update probert to drop --mknodes from vgscan invocation
2020-05-01 13:37:04 +12:00
Michael Hudson-Doyle
2aa3bea55e
add and use the concept of a "global overlay"
...
a problem with my previous merge was that the top overlay was always
removed when the install finished, but if the user had opened a help
topic in the mean time that was the wrong thing to do. also if the
view was switched under the install notification (which is a bit
unlikely but could happen) the dialog would disappear.
this finally pushed me to generically handle "global overlays" that are
not tied to the underlying, controller-controlled view. there are a few
of these now:
* help dialogs
* error reports
* the "are you sure?" install confirmation
* now the install notification
this adds an api for adding and removing them, and the api for removing
them includes which overlay to remove.
2020-05-01 12:54:23 +12:00
Michael Hudson-Doyle
2a53fce963
add a dry-run hot key for pretending to run an install
2020-05-01 12:51:28 +12:00
Michael Hudson-Doyle
5dc2895481
add the ability to remove a particular overlay, not just the top one
2020-05-01 12:46:45 +12:00
Michael Hudson-Doyle
f9eb715108
Merge pull request #738 from mwhudson/stop-all-probing-on-install
...
Stop all probing during installation
2020-05-01 11:45:04 +12:00
Michael Hudson-Doyle
4249088d00
fix travis
2020-05-01 11:36:42 +12:00
Michael Hudson-Doyle
405fc26923
review feedback
2020-05-01 11:27:20 +12:00
Dimitri John Ledkov
f5b477ab15
Merge pull request #740 from anonymouse64/feature/uc20-no-install-mode-console-conf
...
bin/console-conf-wrapper: don't do anything during install mode
2020-04-30 23:58:44 +01:00
Michael Hudson-Doyle
c781c0f7c5
show a dialog when another subiquity is running an install
2020-05-01 10:09:24 +12:00
Michael Hudson-Doyle
5e2a8be9c4
factor journald-listening code out of InstallProgressController
2020-05-01 09:59:15 +12:00
Michael Hudson-Doyle
adb8e2ac43
move file locking into a utility module with logging
2020-05-01 09:58:06 +12:00
Michael Hudson-Doyle
5edfddabf5
prevent probing from running while an install is running
...
take an exclusive lock on /run/subiquity/installing while installing.
block probes take a shared lock on the same file, so the probe cannot
overlap with the install and cause the various problems we've seen.
2020-05-01 09:58:06 +12:00
Michael Hudson-Doyle
7e9c1412b9
introduce and use a state_path helper for finding things in /run
2020-05-01 09:58:06 +12:00
Michael Hudson-Doyle
3908449039
Merge pull request #741 from mwhudson/restart-ssh-subiquity-on-refresh
...
restart subiquity when snap refresh completes
2020-04-30 21:18:25 +12:00
Michael Hudson-Doyle
37a62f21aa
fix travis some more
2020-04-30 20:56:09 +12:00
Michael Hudson-Doyle
25bc8a891c
restart subiquity when snap refresh completes
...
we usually do not get to this point, but we do when logged in via ssh.
see https://bugs.launchpad.net/subiquity/+bug/1874034
2020-04-30 20:30:53 +12:00
Michael Hudson-Doyle
b52ce65ce4
Merge pull request #743 from mwhudson/travis-fix
...
make default_netplan valid, for some reason this causes issues sometimes on travis
2020-04-30 20:30:18 +12:00
Michael Hudson-Doyle
b66ad552f8
make default_netplan valid, for some reason this causes issues sometimes on travis
2020-04-30 20:25:14 +12:00
Michael Hudson-Doyle
261a39587c
Merge pull request #739 from mwhudson/autoinstall-network-oops
...
fix some autoinstall network oopses
2020-04-30 11:40:47 +12:00
Ian Johnson
3238dba4d2
bin/console-conf-wrapper: don't do anything during install mode
...
For now, we want to just block console-conf from doing anything in install mode,
i.e. allowing a user to login etc. but eventually we will probably want to show
more useful status information from snapd during the install mode process.
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
2020-04-29 13:50:42 -05:00
Michael Hudson-Doyle
abc64fb5f2
do not force double "network" keys in autoinstall config
...
I obviously didn't test this very hard before release :/
2020-04-29 19:46:17 +12:00
Michael Hudson-Doyle
dac850f319
never try to show an error report in non-interactive mode (it just crashes anyway)
2020-04-29 19:46:17 +12:00
Michael Hudson-Doyle
d082bad4ce
have a netplan failure crash a non-interactive install
2020-04-29 19:46:17 +12:00
Michael Hudson-Doyle
f8eef1d16a
fix Subiquity.restart dry-run path now we actually hit that in runtests.sh
2020-04-29 19:46:17 +12:00
Michael Hudson-Doyle
05ca96d7ba
run netplan generate --root .subiquity after each integration test
2020-04-29 19:39:10 +12:00
Michael Hudson-Doyle
43081d0dd5
Merge pull request #737 from mwhudson/better-lvm-default
...
have the lv created by the guided lvm option take up 80% of the vg
2020-04-29 18:09:55 +12:00
Michael Hudson-Doyle
dc66caa601
slightly more sophisticated lv-sizing heuristics
2020-04-29 15:13:36 +12:00
Michael Hudson-Doyle
ac8ab7ef47
Merge pull request #736 from mwhudson/stty-sane
...
run "stty sane" in a non-interactive install on the serial line
2020-04-29 13:57:15 +12:00
Michael Hudson-Doyle
d07234611a
have the lv created by the guided lvm option take up 80% of the vg
2020-04-28 23:44:18 +12:00
Michael Hudson-Doyle
136b684454
run "stty sane" in a non-interactive install on the serial line
...
for https://bugs.launchpad.net/subiquity/+bug/1874052
2020-04-28 23:38:35 +12:00
Michael Hudson-Doyle
e604defd3c
Merge pull request #735 from mwhudson/small-console
...
do not crash in a terminal < 76 columns wide
2020-04-28 21:40:09 +12:00
Michael Hudson-Doyle
6007b4dc41
do not crash in a terminal < 76 columns wide
...
for https://bugs.launchpad.net/ubuntu-z-systems/+bug/1874314
2020-04-28 21:32:46 +12:00
Michael Hudson-Doyle
2438a5c1b8
Merge pull request #734 from mwhudson/late-commands-earlier
...
run late commands earlier
2020-04-28 07:30:41 +12:00
Michael Hudson-Doyle
dd1969f89b
split "Reboot" controller out of InstallProgress controller
...
this means late commands run before copying logs to the target and
waiting for the user to click restart
2020-04-24 17:39:57 +12:00
Michael Hudson-Doyle
88165ce5fd
use a cleaner way of attaching controllers to contexts
2020-04-24 14:45:20 +12:00
Michael Hudson-Doyle
12f01405ae
Merge pull request #717 from mwhudson/no-stage-libc6
...
stop staging libc6 now we are core18 based
2020-04-24 13:56:20 +12:00
Michael Hudson-Doyle
73d1136eee
do not stage libnl* packages, they are in the core snap
2020-04-24 13:54:21 +12:00
Michael Hudson-Doyle
905d34daaa
Merge pull request #733 from mwhudson/disable-multiple-boot-devices-on-bionic
...
do not offer resilient boot options pre-focal
2020-04-24 13:51:25 +12:00
Michael Hudson-Doyle
c34834f64e
update add_boot_device tests to insulate from underlying system
...
instead always test both resilient and non-resilient paths.
also this finally prompted me to make the tests less repetitive
2020-04-24 13:40:16 +12:00