Michael Hudson-Doyle
5f8e3dc2a4
do not call next-screen from a background thread
2018-10-31 09:58:58 +13:00
Michael Hudson-Doyle
09bbe3ff19
Do not call the default route waiter repeatedly.
...
This can crash when multiple interfaces get routes.
2018-10-31 09:58:58 +13:00
Michael Hudson-Doyle
15b6bb1114
Major refactor of network model
...
The main thrust of this is to not create virtual interfaces until
applying the config.
This meant that the network model has to change a bit to be able to
represent interfaces that do not yet exist on the system. I did this
by ripping out most of the existing network device code: now a
NetworkDev is really just a wrapper for the config for a device and (if
it exists) the netlink data too. A few places had to adjust to checking
if the netlink info is available before accessing it but all in all it
was not that painful.
There are a few other refactorings in this commit that perhaps should be
split out (how the bond parameters are handled, some stuff about
resizing the table rows when interfaces are edited) but it doesn't
really seem worth it.
2018-10-31 09:58:56 +13:00
Michael Hudson-Doyle
7a86603539
prevent bonding of bonds
...
https://bugs.launchpad.net/bugs/1782397
2018-07-23 10:39:14 +12:00
Michael Hudson-Doyle
96ee3db409
make example CIDR form address family appropriate
...
https://bugs.launchpad.net/bugs/1782391
2018-07-23 10:38:06 +12:00
Michael Hudson-Doyle
7f766e93a1
forbid bonding of vlans
...
https://bugs.launchpad.net/bugs/1782351
2018-07-23 10:34:41 +12:00
Michael Hudson-Doyle
42b339605c
make button labels more consistent
...
especially back vs cancel
for https://bugs.launchpad.net/subiquity/+bug/1781457
2018-07-16 22:45:36 +12:00
Michael Hudson-Doyle
d95f089a04
add arrows at end of scrollbar
...
for https://bugs.launchpad.net/subiquity/+bug/1781460
2018-07-16 12:44:38 +12:00
Michael Hudson-Doyle
53fb81a65b
correctly call wrapped lost_focus in _Validator.lost_focus
...
fixes https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1781429
2018-07-16 12:44:38 +12:00
Michael Hudson-Doyle
f19a453e0e
mark interfaces that have dhcp enabled but did not get an address as optional
2018-07-12 14:17:20 +12:00
Michael Hudson-Doyle
437f42b599
lint
2018-07-12 11:36:30 +12:00
Michael Hudson-Doyle
f3b0d13fbe
a proper multi-nic selector
2018-07-12 10:10:08 +12:00
Michael Hudson-Doyle
07ac05b6d3
view improvements
2018-07-11 22:02:52 +12:00
Michael Hudson-Doyle
46c0d598ad
first cut at a bond form that handles devices too
2018-07-11 22:02:52 +12:00
Michael Hudson-Doyle
5e683dcc1f
add create bond button
2018-07-11 22:02:52 +12:00
Michael Hudson-Doyle
2f149a8aac
enable/disable bond options as bonding mode changes
2018-07-11 22:02:52 +12:00
Dimitri John Ledkov
87558f0074
lint
2018-07-11 22:02:52 +12:00
Dimitri John Ledkov
88b64ca7fd
Fix up bond netplan.
2018-07-11 22:02:52 +12:00
Dimitri John Ledkov
87ef3749e6
Finish bond master/slaves.
2018-07-11 22:02:52 +12:00
Dimitri John Ledkov
e0d231f5d7
Create bond
2018-07-11 22:02:52 +12:00
Michael Hudson-Doyle
0457985208
fixup tests
2018-07-11 14:55:41 +12:00
Michael Hudson-Doyle
535a0f3b04
fix editing an interface
2018-07-11 09:43:58 +12:00
Michael Hudson-Doyle
c21cec6fdc
fix logic around waiting for udev to settle to avoid busy loop
2018-07-11 09:41:56 +12:00
Michael Hudson-Doyle
e91308e8b9
close any dialog open for an interface that is deleted
2018-07-11 09:36:14 +12:00
Michael Hudson-Doyle
c69b89b4df
expand a whinge about urwid's focus behaviour
2018-07-11 09:35:01 +12:00
Michael Hudson-Doyle
91def10468
improve message on vlan interfaces
2018-07-10 22:58:47 +12:00
Michael Hudson-Doyle
53a14e30ad
make updates to network screen in response to netlink events more finegrained
2018-07-10 13:25:05 +12:00
Michael Hudson-Doyle
1701246d12
refactor how device row gets created a bit
2018-07-10 12:34:42 +12:00
Michael Hudson-Doyle
b3636cfcd9
refactor how netdev action menu gets populated
2018-07-10 12:30:01 +12:00
Michael Hudson-Doyle
db042eafa6
read vlan config from netlink
...
using support i just added to probert
2018-07-08 14:16:22 +12:00
Dimitri John Ledkov
8a0e94ccc7
Pacify flake8
2018-07-06 15:00:27 +01:00
Dimitri John Ledkov
a4daae42d6
Fix crash, after deleting last vlan.
2018-07-06 14:33:34 +01:00
Dimitri John Ledkov
68b6b2a6b1
Implement information screen for the network interfaces.
2018-07-06 14:33:32 +01:00
Dimitri John Ledkov
92c53b29ae
Vlan ui
2018-07-06 14:31:42 +01:00
Dimitri John Ledkov
173eac79a5
models/network: use same NetDev in both dictionaries
...
One can lookup interfaces by ifindex and by name. Ensure, both
dictionaries use the same NetDev object. This way, when config of
NetDev is updated, it is correctly reflected whichever way the NetDev
is accessed.
2018-07-06 14:30:42 +01:00
Michael Hudson-Doyle
d5f136c413
improve behaviour when a spanning column makes table want to be wider than view
2018-07-06 15:20:25 +12:00
Michael Hudson-Doyle
e3e5c7f760
fix tests
2018-07-06 14:44:19 +12:00
Michael Hudson-Doyle
ed09054928
fix lint
2018-07-06 14:17:27 +12:00
Michael Hudson-Doyle
29fe577013
delete more unused code
2018-07-06 14:13:30 +12:00
Michael Hudson-Doyle
830d89c735
unify "action menu row" creation
2018-07-06 13:57:55 +12:00
Michael Hudson-Doyle
7d15727b74
add wlan editing
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
2e281d00d4
delete gobs of old code
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
2251cac4ba
trim back to existing functionality
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
805ad5f495
code motion
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
79a380f28f
initialize manual form fields
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
58fd656aed
small tweaks
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
834b5a1014
a bit better
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
89a30721a2
copy network manager a bit more directly
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
0fdd9721ce
tweaks
2018-07-06 13:36:53 +12:00
Michael Hudson-Doyle
08de48623f
more
2018-07-06 13:36:53 +12:00