Commit Graph

128 Commits

Author SHA1 Message Date
Michael Hudson-Doyle 7c90a9e4da Fix crash when an interface has more than one IP address of the same family. 2016-11-11 11:29:57 +13:00
Michael Hudson-Doyle 7bef718e18 re-work logic, including having console-conf generate the file to show 2016-11-09 14:33:58 +13:00
Michael Hudson-Doyle 19081d53bc reparse netplan configs after writing config
'netplan apply' can re-plug network interfaces, so it looked like we
forgot how an interface had been configured
2016-11-09 12:21:06 +13:00
Michael Hudson-Doyle 344b177f16 validate user input a lot more thoroughly in the static ipv4 view 2016-11-08 11:07:20 +13:00
Michael Hudson-Doyle a7bfef3646 show error message from netplan generate when it fails 2016-11-08 10:39:54 +13:00
Michael Hudson-Doyle 8a44befe2a remove UI for customizing default route, not supported by netplan
Yet, anyway.
2016-11-08 10:39:05 +13:00
Michael Hudson-Doyle 31b21799b7 remove dependency on netifaces 2016-11-07 16:56:36 +13:00
Michael Hudson-Doyle c4fdf5cb72 allow choosing from visible networks when configuring wifi 2016-11-07 16:56:36 +13:00
Michael Hudson-Doyle cacd456a6a Adapt to netlink event driven version of probert. 2016-11-07 16:56:32 +13:00
Michael Hudson-Doyle 82b11dbd69 reorganize the network model and make the UI a bit more consistent
The main change here is to separate the state a network device is in and the
state we want it to be in. So it now parses the netplan config on a system as
well as probing the state of via probert.

The UI is changed to make this distintion too, and be IMO a bit more
consistent. Somewhere in this I've removed the display of whether the
probed address was found via DHCP or not, possibly that should be put
back if it doesn't make things too cluttered.

In dry-run mode, we now still write the config and feed it to netplan, but
in a way that doesn't affect the system we are running it on.
2016-11-07 15:15:46 +13:00
Michael Hudson-Doyle d48a70973e restore escape key behaviour 2016-11-02 12:44:04 +13:00
Michael Hudson-Doyle f9de0818a8 fix C-x 2016-11-02 12:24:06 +13:00
Michael Hudson-Doyle 6b99559819 oops 2016-11-02 12:14:01 +13:00
Michael Hudson-Doyle 91e42e37bd Merge branch 'master' into mwhudson/kill-some-signals 2016-11-02 12:00:47 +13:00
Michael Hudson-Doyle 019b5c4b3e make properly sure that the wifi password does not get logged
Two of these were properly stupid :(

LP: #1636421 (again)
2016-10-28 13:14:05 +13:00
Michael Hudson-Doyle 74be6a382a launchpad allows = in emails too 2016-10-27 09:28:52 +13:00
Michael Hudson-Doyle ef0da85568 allow + in email addresses 2016-10-27 09:24:21 +13:00
Michael Hudson-Doyle 47af1de57e remove setting of umask, redact wifi password from log file
The setting of umask was breaking configuring wifi :(
2016-10-26 11:02:23 +13:00
Michael Hudson-Doyle 6318de27cf make sure selecting dhcp after manual configuration clears out gateway & nameserver config 2016-10-21 08:59:34 +13:00
Michael Hudson-Doyle 6d93221a43 do not add empty strings to nameservers or search_domains 2016-10-21 08:59:09 +13:00
Mathieu Trudel-Lapierre 0ef1ec679b models/network: move nameservers rendering to the interface rather than being global
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-10-20 15:18:19 -04:00
Michael Hudson-Doyle 7edcf3bcb7 UI for entering name servers/domains 2016-10-20 22:31:10 +13:00
Michael Hudson-Doyle 67f2ee4cda include nameservers in device config 2016-10-20 21:59:34 +13:00
Michael Hudson-Doyle 262a7a4806 Merge pull request #172 from CanonicalLtd/mwhudson/render-gateway
render gateway4/gateway6 in network config
2016-10-20 13:22:25 +13:00
Michael Hudson-Doyle d594b77f28 do not write the netplan config so the world can see it 2016-10-20 12:37:19 +13:00
Michael Hudson-Doyle baf05ac5ad render gateway4/gateway6 in network config
See https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1634540
2016-10-20 11:04:18 +13:00
Michael Hudson-Doyle f603207d94 remove most trivial use of signals from console-conf's flow 2016-10-11 12:48:28 +13:00
Michael Hudson-Doyle e348207597 Remove most use of signals from welcome and network views. 2016-10-10 16:47:42 +13:00
Michael Hudson-Doyle 23ff9fe1e8 controllers can have signals without models now. 2016-09-29 14:52:11 +13:00
Michael Hudson-Doyle 8020dd38c7 address review comments 2016-09-29 14:06:09 +13:00
Michael Hudson-Doyle 0bd33b7074 fix subiquity side again 2016-09-29 12:29:21 +13:00
Michael Hudson-Doyle 2f8c1aa5cf move logic from identity/login views into identity controller
This was what I wanted to do before I got distracted by the other things.
2016-09-27 21:56:48 +13:00
Michael Hudson-Doyle d9095336e5 do not have controllers (or view code!!) know the order of the screens 2016-09-27 21:35:47 +13:00
Michael Hudson-Doyle 2373837269 make fake network actions in dry-run mode a lot quicker 2016-09-27 20:53:17 +13:00
Michael Hudson-Doyle dad0e10912 completely separate menu -> signal and signal -> method mappings
and put the signal -> method mapping into the controller

this breaks the subiquity part even more than before, but it's pretty broken
already.
2016-09-27 20:53:17 +13:00
Mathieu Trudel-Lapierre ba51edff75 models/network: don't render wifi devices that have no addresses and no DHCP.
Otherwise netplan, seeing the device half-rendered, also expects to set a
SSID we haven't set.

Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
2016-09-23 15:21:32 -04:00
Michael Hudson-Doyle cd2758cc90 do not override datefmt so we get seconds (and even microseconds) in the logs 2016-09-21 11:56:04 +12:00
Michael Hudson-Doyle e765538c95 address some UI comments from Mark 2016-09-20 14:13:31 +12:00
Michael Hudson-Doyle cbc6e97af7 use is_connected from probert 2016-09-19 11:27:12 +12:00
Michael Hudson-Doyle f78cae64bd Show if a link is not connected.
At least as well as ip(8) does it.
2016-09-16 14:28:40 +12:00
Michael Hudson-Doyle 682c81c289 Really probe (i.e. call into probert) every time we load the network screen.
Connected-ness of a link is something that can plausibly change over short
timescales.
2016-09-16 14:27:37 +12:00
Michael Hudson-Doyle 6161967459 Merge pull request #159 from CanonicalLtd/mwhudson/lp-1623756
Do not write any config for a wlan device that has not been given a ESSID
2016-09-16 09:59:31 +12:00
Michael Hudson-Doyle fdd99e21f0 be more careful in BackgroundProcess.cancel
Someone sent me a traceback where cancel() was called before .proc was set.  I
don't really understand how this happens, but there's no harm in being careful.
2016-09-15 21:35:48 +12:00
Michael Hudson-Doyle 36967e2309 Do not write any config for a wlan device that has not been given a ESSID
See https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1623756
2016-09-15 21:30:41 +12:00
Mathieu Trudel-Lapierre e608362b34 Merge pull request #154 from CanonicalLtd/mwhudson/wifi-ui
Add a basic UI for entering wifi config details.
2016-09-09 15:33:48 -04:00
Mathieu Trudel-Lapierre d882666e2e Merge pull request #155 from CanonicalLtd/mwhudson/fix-columns
fix scrolling with many interfaces
2016-09-09 14:52:43 -04:00
Michael Hudson-Doyle bfbb876855 version from PPA 2016-09-05 21:21:05 +12:00
Michael Hudson-Doyle bf827db28d fix scrolling with many interfaces 2016-09-05 21:07:56 +12:00
Michael Hudson-Doyle 313b4d86db add a word 2016-09-05 20:17:05 +12:00
Michael Hudson-Doyle 97171f6b71 improve UI a bit 2016-09-05 16:55:09 +12:00