Commit Graph

1969 Commits

Author SHA1 Message Date
Scott Moser af94275618 Make tox and Makefile more similar.
This does a few things with the end goal of making simplifying and
making consistent tox and 'make' methods of test or check.

Things here:
 * move python programs out of bin and into their own main.  Use
   entry_points to get scripts written for them.  One gain here is
   that we no longer have python programs that are not named .py.
   flake8 and friends would not check those programs by default.
 * install scripts in bin/ using the setup.py scripts and adjust
   snapcraft.yaml and debian packaging for that.
 * declare and use PYTHON in Makefile to avoid repeating 'python3'
 * declare and use CHECK_DIRS in Makefile for list of dirs to check.
 * no longer run 'flake8' from 'make check' by default.
 * remove the old tests/ directory.
2018-06-05 22:19:17 -04:00
Scott Moser bf807867c3 setup.py: fix package build. (#351)
Package build was broken with my last commit.
This restores functional debuild/dpkg-buildpackage.
2018-06-06 14:04:33 +12:00
Scott Moser 51a7169904 tox: Support running tests and flake8 in tox.
This puts into place a tox.ini for running unit tests without
a large amount of deps installed into the system. For example,
we did not want to need libnl-route-3-dev or build-essential installed
in the system in order to run unit tests.

In order avoid import errors in the modules due to these missing
dependencies, we have added a 'fake_deps/' directory that provides
mock'd objects of the dependencies that were used.

The only installed packages necessary for this to run should be
tox itself and its dependencies (pip and friends).  From a clean new
container we can then do:
  apt-get install tox
  git clone ...
  tox

Also along the way:
 * adjust setup.py to only need the DistUtilsExtra during 'build'.
   This means tox usage doesn't require python3-distutils-extra.
 * drop use of lsb_release in favor of built-in parsing.
   This python module wasn't doing much.  We can parse /etc/lsb-release
   ourselves with less footprint.  Also part of the motivation for this
   is that lsb_release was not on pypi.
 * replace use of StorageInfo in test_partition.py with a FakeStorageInfo
 * .gitignore: ignore only the top level 'probert' directory so that
   we can track fake_deps/probert.
 * fix a couple escape chars, by using raw strings (r'').
 * adjust gettext to return un-modified strings rather than '_(string)',
   but support old style if FAKE_TRANSLATE=mangle.
2018-06-05 17:59:46 -04:00
Scott Moser 86826811a8 Remove dead controllers for ceph, iscsi, raid.
These controllers were broken (with failing 'imports') and were
not used.  Drop them, they can be resurrected at a later date when
needed.
2018-06-05 15:33:49 -04:00
Michael Hudson-Doyle c53b3dae8f change back to looking for ssh-import-id in answers 2018-06-01 10:22:55 +12:00
Michael Hudson-Doyle a64ae8bd82
Merge pull request #339 from CanonicalLtd/mwhudson/snap-screen
offer featured snaps for installation
2018-06-01 09:13:00 +12:00
Michael Hudson-Doyle f4c481860f remove a flag that is set but never checked 2018-06-01 09:04:16 +12:00
Michael Hudson-Doyle 19dd965461 some self-review 2018-05-31 12:31:02 +12:00
Michael Hudson-Doyle 738d8e11c7 oops 2018-05-31 11:58:58 +12:00
Michael Hudson-Doyle 49ad5c28ef switch to using cloud-init to download/install snaps 2018-05-31 10:53:01 +12:00
Michael Hudson-Doyle c044dc91b1 fix lint 2018-05-31 10:37:57 +12:00
Michael Hudson-Doyle eab0f668ff use general machinery a little more 2018-05-31 10:28:29 +12:00
Michael Hudson-Doyle 3f86d7594d move Padding outside SnapInfoView 2018-05-31 10:03:30 +12:00
Michael Hudson-Doyle 1a79a7679a fix selectability of snap description 2018-05-31 09:56:11 +12:00
Michael Hudson-Doyle f2d0d0aade update default snap store section and examples to server 2018-05-31 09:54:07 +12:00
Michael Hudson-Doyle 8e50ce252c Merge branch 'master' into mwhudson/snap-screen 2018-05-25 11:44:19 +12:00
Michael Hudson-Doyle 915bce02e0
Merge pull request #344 from CanonicalLtd/mwhudson/travis-tests
update travis jobs: test on cosmic, run make lint
2018-05-25 11:42:50 +12:00
Michael Hudson-Doyle 15a2c1867c fix lint 2018-05-25 11:26:14 +12:00
Michael Hudson-Doyle 293793fa49 merge master 2018-05-25 11:06:23 +12:00
Michael Hudson-Doyle 43f581bca4 update travis jobs: test on cosmic, run make lint 2018-05-25 10:56:01 +12:00
Michael Hudson-Doyle ed5e1d86b5 fix lint 2018-05-25 10:43:55 +12:00
Michael Hudson-Doyle 50e0ebebbf
Merge pull request #343 from raharper/feature/add-pyflakes
Add pep8 and pyflake3 targets and apply all of the fixes
2018-05-25 10:37:55 +12:00
Ryan Harper b55eb58501 pep8 fix, imports at top 2018-05-24 16:59:32 -05:00
Ryan Harper 618142f132 Rework make lint target to use pep8 pyflakes3 targets 2018-05-24 16:59:32 -05:00
Ryan Harper f8745a1cc3 pyflakes3 fixes for bin/console-conf-tui 2018-05-24 16:59:31 -05:00
Ryan Harper 5f8b562361 Add bin/*tui to pyflakes3 check 2018-05-24 16:59:31 -05:00
Ryan Harper 3ff00ff866 pep8 fixes for bin/subiquity-tui 2018-05-24 16:59:31 -05:00
Ryan Harper 36c42179e2 pep8 fixes for bin/console-conf-tui 2018-05-24 16:59:31 -05:00
Ryan Harper 879901149f Add bin/*-tui to pep8 checks 2018-05-24 16:59:31 -05:00
Ryan Harper 053a1c249d pyflakes3 fixes for subiquitycore/__init__.py 2018-05-24 16:59:31 -05:00
Ryan Harper 2c5beeca91 pyflakes3 fixes for subiquity/ui/views/filesystem/partition.py 2018-05-24 16:59:31 -05:00
Ryan Harper afefe7f163 pyflakes fixes for subiquity/controllers/installpath.py 2018-05-24 16:59:31 -05:00
Ryan Harper 636fec4dd5 pyflakes fix for subiquity/controllers/filesystem.py 2018-05-24 16:59:31 -05:00
Ryan Harper ed0f705806 pyflakes fixes for subiquity/__init__.py 2018-05-24 16:59:31 -05:00
Ryan Harper dc5661ebd5 pyflakes fixes for console_conf/__init__.py 2018-05-24 16:59:31 -05:00
Ryan Harper 103fc1edda pep8 fixes for console_conf/ui/views/identity.py 2018-05-24 16:59:31 -05:00
Ryan Harper b1d9581b9a pep8 fixes for console_conf/ui/views/login.py 2018-05-24 16:59:31 -05:00
Ryan Harper a06c15bd28 pep8 fixes for console_conf/ui/views/welcome.py 2018-05-24 16:59:31 -05:00
Ryan Harper 1451bfc93b pep8 fixes for console_conf/models/console_conf.py 2018-05-24 16:59:31 -05:00
Ryan Harper 8743ff5200 pep8 fixes for console_conf/controllers/identity.py 2018-05-24 16:59:31 -05:00
Ryan Harper a8f9b720da pep8 fixes for subiquity/models/subiquity.py 2018-05-24 16:59:31 -05:00
Ryan Harper 51d97b482c pep8 fixes for subiquity/ui/mount.py 2018-05-24 16:59:31 -05:00
Ryan Harper 999e313b3c pep8 fixes for subiquity/ui/spinner.py 2018-05-24 16:59:31 -05:00
Ryan Harper 534c39708c pep8 fixes for subiquity/ui/views/identity.py 2018-05-24 16:59:31 -05:00
Ryan Harper 4517c82772 pep8 fixes for subiquity/ui/views/installpath.py 2018-05-24 16:59:31 -05:00
Ryan Harper 156a65210b pep8 fixes for subiquity/ui/views/keyboard.py 2018-05-24 16:59:31 -05:00
Ryan Harper d7c8b1111b pep8 fixes for subiquitycore/core.py 2018-05-24 16:59:31 -05:00
Ryan Harper d293c52152 pep8 fixes for subiquitycore/tasksequence.py 2018-05-24 16:59:31 -05:00
Ryan Harper 4c1b6e6fc9 pep8 fixes for subiquitycore/ui/buttons.py 2018-05-24 16:59:31 -05:00
Ryan Harper 080ac4c245 pep8 fixes for subiquitycore/ui/form.py 2018-05-24 16:59:31 -05:00