Commit Graph

1733 Commits

Author SHA1 Message Date
Michael Hudson-Doyle 76467a08d8 only reduce size of initial partition if adding the boot partition means the requested size no longer fits 2018-03-26 12:25:07 +13:00
Michael Hudson-Doyle e028ca0360 add some explanatory text to the view of the boot/bios_grub partition 2018-03-26 12:22:07 +13:00
Michael Hudson-Doyle a544a66622 do not allow editing the size of the bios_grub partition 2018-03-26 12:21:50 +13:00
Michael Hudson-Doyle 9ed5de40b2
Merge pull request #302 from CanonicalLtd/mwhudson/no-partnum-in-ui
remove ability to supply partition number from the UI
2018-03-26 11:54:00 +13:00
Michael Hudson-Doyle dadfddc6a0 remove ability to supply partition number from the UI
also remove it from the curtin config.
2018-03-26 11:01:43 +13:00
Michael Hudson-Doyle 229c8880bc
Merge pull request #301 from CanonicalLtd/mwhudson/part-sizing
adjust details of partition sizing
2018-03-23 09:44:11 +13:00
Michael Hudson-Doyle b691f5548e
Merge pull request #300 from CanonicalLtd/mwhudson/swap-fun
adjust curtin config so swap partitions are actually used
2018-03-23 09:11:48 +13:00
Michael Hudson-Doyle d2a9f84b18 fix tests with slightly more realistic sizes 2018-03-22 14:27:06 +13:00
Michael Hudson-Doyle 753a7c67b3 special case the user entering the displayed "max size" string to mean the actual max size
rounding can make these marginally different
2018-03-22 14:18:00 +13:00
Michael Hudson-Doyle ef5229d037 round up partition size on edit
and complain here if the size is too big
2018-03-22 14:17:06 +13:00
Michael Hudson-Doyle e914919c61 round user input for partition sizes up to 1MiB boundaries 2018-03-22 14:16:39 +13:00
Michael Hudson-Doyle d1c431af01 round displayed hd sizes down to the nearest MiB
do not know if this makes a real difference but no real cost to being defensive
2018-03-22 14:15:36 +13:00
Michael Hudson-Doyle af67c7074c have humanize_size round down rather than up
rounding up can end up showing a free size for a disk that is larger than the
actual free size...
2018-03-22 14:14:03 +13:00
Michael Hudson-Doyle 7c6bd753af suppress the swapfile if there is an explcit swap partition 2018-03-21 23:39:20 +13:00
Michael Hudson-Doyle 0651023365 add a mount for anything formatted as swap 2018-03-21 23:27:58 +13:00
Michael Hudson-Doyle 91ba2d0602 set swap flag on a partition too 2018-03-21 23:27:51 +13:00
Michael Hudson-Doyle e61eb454cf
Merge pull request #299 from CanonicalLtd/mwhudson/disable-wifi-server
do not show wlan interfaces in server installer
2018-03-21 15:44:55 +13:00
Michael Hudson-Doyle 366d27713b remove crufty line that has a typoed variable name 2018-03-21 15:43:51 +13:00
Michael Hudson-Doyle d0da487895 avoid a strange apparmor bug/issue by invoking subiquity entrypoint directly
see https://forum.snapcraft.io/t/snapd-2-32-breaks-live-server-installer/4597 for more details
2018-03-21 15:42:55 +13:00
Michael Hudson-Doyle 56c582a0d0 the way subiquity works it is better do consider a Pile selectable if any of its elements are selectable
Without this, if a non-selectable thing ends up focused, the net effect is that
all further input is ignored, which is bad.
2018-03-21 11:18:56 +13:00
Michael Hudson-Doyle 0c071f7b0d form fields should not be validated on entry 2018-03-21 10:39:32 +13:00
Michael Hudson-Doyle b3da7266b9 do not show wlan interfaces in server installer 2018-03-21 09:35:21 +13:00
Michael Hudson-Doyle 8287d695dc fix live updates of network screen 2018-03-16 15:30:14 +13:00
Michael Hudson-Doyle 5ab28c9b98 bump version in debian/changelog 2018-03-16 15:30:08 +13:00
Michael Hudson-Doyle d9091b12dc add __init__.py to console_conf/models/ 2018-03-16 15:29:50 +13:00
Michael Hudson-Doyle a35723089d a simple script to put the edge subiquity snap into a new iso 2018-03-14 15:25:53 +13:00
Michael Hudson-Doyle dfc6627801
Merge pull request #298 from CanonicalLtd/mwhudson/design-feedback
address feedback from sprint
2018-03-14 15:00:02 +13:00
Michael Hudson-Doyle 1f937090c0 update help text for address 2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle 59a500c9e5 add more space between form rows, align help to the left 2018-03-14 14:58:58 +13:00
Michael Hudson-Doyle 16f8bc07d0
Merge pull request #294 from CanonicalLtd/mwhudson/better-scrolling
improve scrolling experience
2018-03-14 14:58:36 +13:00
Michael Hudson-Doyle 2a1e0f1ffa
Merge pull request #297 from CanonicalLtd/mwhudson/ssh-import-rework
change how ssh import field works
2018-03-14 14:58:25 +13:00
Michael Hudson-Doyle ca953ea01f improve scrolling experience
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).

The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.

As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
Michael Hudson-Doyle 5a81c397b9
Merge pull request #295 from CanonicalLtd/mwhudson/no-swapfile-for-btrfs-root
prevent creation of a swapfile when / is btrfs
2018-03-14 14:27:01 +13:00
Michael Hudson-Doyle c57f0057f3 simplifications 2018-03-14 14:20:53 +13:00
Michael Hudson-Doyle 9ba11aedb5 change how ssh import field works
This is the only place in subiquity today where we have selectable fields side
by side, which contradicts the goal to be able to navigate subiquity with up,
down and enter keys only. Replace the existing fancy widget with two fields,
one to select the import source and one to enter the username.

Also remove the "Ubuntu SSO" option as that has never worked.
2018-03-14 14:07:03 +13:00
Michael Hudson-Doyle e1bc2eb45d
Merge pull request #296 from CanonicalLtd/mwhudson/shift-tab-fixery
keyboard fixes: show dialog while applying, re-setup shift tab afterwards
2018-03-14 10:04:35 +13:00
Michael Hudson-Doyle bafef44750 /snap/bin is apparently not on PATH for subiquity... 2018-03-13 21:28:58 +13:00
Michael Hudson-Doyle 067b63b79d run subiquity-loadkeys after setupcon to restore shift tab behaviour 2018-03-13 20:58:36 +13:00
Michael Hudson-Doyle f77a861c38 pop up a little dialog while the keyboard config is applying 2018-03-13 20:58:33 +13:00
Michael Hudson-Doyle cb45a4b7df prevent creation of a swapfile when / is btrfs
https://bugs.launchpad.net/subiquity/+bug/1750657
2018-03-13 20:19:37 +13:00
Michael Hudson-Doyle 599eea3e2c
Merge pull request #292 from CanonicalLtd/mwhudson/overlay-border
add a border to all overlays to make them more readable
2018-03-13 16:59:49 +13:00
Michael Hudson-Doyle 80a8ce5260
Merge pull request #293 from CanonicalLtd/mwhudson/red-red
change danger color to be #ff0000
2018-03-13 16:59:23 +13:00
Michael Hudson-Doyle 6dd6299a6e fix a crash 2018-03-13 14:42:47 +13:00
Michael Hudson-Doyle c31183ff13 change danger color to be #ff0000 2018-03-12 14:28:34 +13:00
Michael Hudson-Doyle 0656d2b2bc add a border to all overlays to make them more readable 2018-03-12 14:25:27 +13:00
Michael Hudson-Doyle 23dc099933
Merge pull request #291 from CanonicalLtd/resurrect-console-conf
Resurrect console conf
2018-03-08 21:52:38 +13:00
Michael Hudson-Doyle 6f4a87101b flakes-- 2018-03-08 19:05:51 +13:00
Michael Hudson-Doyle 0273a3d110 "modernize" console-conf views 2018-03-08 18:51:39 +13:00
Michael Hudson-Doyle d15565bdf1 console_conf does not pass a hostname here 2018-03-08 18:06:34 +13:00
Michael Hudson-Doyle 1d4d5021ec fix button creation 2018-03-08 18:06:07 +13:00