When the request to v2/systems/enhanced-secureboot-desktop (or
equivalent) fails, Subiquity did not capture the reason. This makes
it difficult to understand why this call sometimes fails. We now log the
response text to understand better what's going on.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
We now rely on distro-info to find out the EOL ESM date on LTS releases.
This information is meant to be shown on the Ubuntu Pro screens ;
instead of hardcoded values.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Before running curthooks, we now look in the target if there is an
installed kernel. If there is, we instruct curtin _not_ to install
another one.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
When running subiquity in dry-run mode with SUBIQUITY_DEBUG=run-drivers,
we now support using a YAML file describing the hardware in a
umockdev-compatible way. This allows to give some control on what
ubuntu-drivers list will reply.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
The script can be invoked in different ways:
Run mypy in the current working directory and display the output:
$ scripts/run-mypy.py
Run mypy in a clean copy of the HEAD revision:
$ scripts/run-mypy.py --checkout-head
Run mypy in the current working directory and compare the result with
another revision (here main):
$ scripts/run-mypy.py --diff-against main
Run mypy in a clean copy of the HEAD revision and compare with another
revision (here main):
$ scripts/run-mypy.py --diff-against main --checkout-head
The produced result might be slightly different from what the CI does
because it also clones checks out curtin and probert (at the right
revision). This is something we might want to do in the CI as well.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
The pep8 binary package was a transitional package. It would install a
symlink /usr/bin/pep8 -> pycodestyle
pep8 does not exist anymore in mantic.
pycodestyle would be the right binary package going forward. That said,
we stopped using the pep8 command back in 2018 with this commit:
af9427561 Make tox and Makefile more similar.
Let's drop the dependency instead.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
The existing event based method of watching for has_network has a flaw.
The incoming route_change events from probert do not distinguish routes
on the same interface but a different metric, so if 2 routes on one
interface appear, we only get one event. Then if one of those routes is
removed, we will inappropriately remove this route from the
default_routes list.
Aside from the code watching the event stream, the set of default routes
is an elaborate boolean value.
Simplify the code by passing around a boolean, and when we get a
route_change event, use that to go looking again at the list of default
routes.
LP: #2004659
python3-aiohttp has been fixed and released in focal-updates.
New Subiquity builds should not be affected by LP: #1969393 anymore.
This reverts commit 413cc87337.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
The build instruction contain a step
PYTHONPATH=probert ./probert/bin/probert --all > mymachine.json
This requires package os-prober.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Running `make install_depends` does not (always) pull python3-systemd
which is a dependency of Subiquity.
In environments having Install-Recommends enabled, python3-systemd is
pulled by apport which is itself pulled by python3-apport.
Fixed by adding it to the list of dependencies in apt-deps.txt
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Olivier Gayot