58fd656aed
small tweaks
2018-07-06 13:36:53 +12:00
834b5a1014
a bit better
2018-07-06 13:36:53 +12:00
89a30721a2
copy network manager a bit more directly
2018-07-06 13:36:53 +12:00
0fdd9721ce
tweaks
2018-07-06 13:36:53 +12:00
08de48623f
more
2018-07-06 13:36:53 +12:00
4c9ec9cf5e
more
2018-07-06 13:36:53 +12:00
6eb255c2e0
beginnings of an edit network device dialog
2018-07-06 13:36:53 +12:00
ad8d6c9086
skeleton of new view
2018-07-06 13:36:53 +12:00
9cbaac4542
use our custom WidgetWrap everywhere
2018-06-22 09:38:18 +12:00
1ab495c0a8
fix refreshing network view on network changes
2018-06-13 13:38:03 +12:00
5f233be9b1
pep8 fixes for subiquitycore/ui/views/network.py
2018-05-24 16:54:02 -05:00
c908115ee0
pep8 fixes for subiquitycore/ui/views/network_configure_manual_interface.py
2018-05-24 16:54:02 -05:00
c99941f3c5
pep8 fixes for subiquitycore/ui/views/login.py
2018-05-24 16:51:51 -05:00
62ea440b3d
pep8 fixes for subiquitycore/ui/views/network.py
2018-05-24 16:51:51 -05:00
0fa5dcab28
pep8 fixes
2018-05-24 16:51:51 -05:00
c8d4c51ddd
pep8 fixes
2018-05-24 16:51:51 -05:00
ae9412159d
Don't use __name__ in getLogger
2018-05-24 16:51:51 -05:00
13ca352291
pep8 fixes for subiquitycore/ui/views/network_configure_wlan_interface.py
2018-05-24 16:51:51 -05:00
591be4ecbc
pep8 fixes for subiquitycore.ui.views.network_default_route
2018-05-24 16:51:51 -05:00
45fabd78f2
pep8 fixes for subiquitycore.ui.views.tests.test_network_configure_manual_interface
2018-05-24 16:51:51 -05:00
a0bf68f3c4
pyflakes3 fixes
...
Add and enable pyflakes3 on console_conf, subiquity, subiquitycore and tests.
Replace NOQA markers with __all__ declarations for module imports.
Replace some obvious deadcode that voilates flake8, separate pass for removing
dead code rather than commenting will be handled later.
2018-05-24 16:51:51 -05:00
0fe1f5145c
sprinkle in some more ".base_widget"s
2018-05-23 13:40:14 +12:00
626488e988
Merge pull request #334 from CanonicalLtd/mwhudson/move-excerpt-title-to-view
...
move excerpt, title and footer from controller to view
2018-05-22 22:38:39 +12:00
f6f214125f
move TaskSequence somewhere more generic
...
I want to reuse it in my containerizing branch.
Improve API and docs a bit while I am looking at it.
2018-05-21 11:52:06 +12:00
11708703c9
move titles, footers, excerpts from controller to view
...
read title and footer from the view instance, make views respsonsible for rendering
the excerpt
adapts infrastructure, welcome, keyboard, network views
2018-05-18 15:55:49 +12:00
960f51ca91
remove view argument to Form.as_rows and friends
2018-05-07 10:57:35 +12:00
fa8f8d32f5
down all network links that have changed config before applying it
...
this means that if you enter a broken config, it breaks as it should
2018-05-03 12:14:06 +12:00
fe671d8d9b
fix rendering of nic info if dhcp failed but has addresses of other family
...
This bug has been here forever! Oh well.
2018-04-27 14:56:30 +12:00
7d704f83f0
mark even more strings as translatable
2018-04-19 13:09:00 +12:00
028914da97
another small helper
2018-04-09 14:37:26 +12:00
a723d25a4c
create a helper to create a common screen layout
2018-04-09 14:30:59 +12:00
0fc83c4bc1
simplify a bunch of views
...
i am slowly getting better at urwid...
2018-04-09 14:10:36 +12:00
8287d695dc
fix live updates of network screen
2018-03-16 15:30:14 +13:00
1f937090c0
update help text for address
2018-03-14 14:58:58 +13:00
ca953ea01f
improve scrolling experience
...
Before this change, subiquity has lots of ListBoxes that just contain a single
Pile containing all their contents. This is (a) a bit silly (b) make some parts
of the scrolling experience a bit poor, for example urwid tries to scroll all
of a ListBox element into view when it gets focus but this is defeated by
shoving all the elements into a Pile (this causes
https://bugs.launchpad.net/subiquity/+bug/1750058 and a few other strange
bits).
The fix for this is obvious (don't wrap ListBox elements in a Pile) but this
breaks some aspects of tab cycling (when you shift tab back into a listbox you
want the last element of the box to be both selected and scrolled into view,
that sort of thing). Fixing all these bits of broken behaviour required
rewriting the tab cycling implementation to the point of copy/paste/hack-ing
the Pile.keypress method. Rather than doing the same for Columns, I just
prevent the creation of Columns with more than 1 selectable, which as we want
subiquity to be navigable with up/down/return does not seem so bad.
As penitence for all this, I've added a bunch of commentary explaining what is
going on.
2018-03-14 14:35:27 +13:00
4a5e3b3815
stop showing >s on network config choices that do not lead to a new screen
2018-02-20 10:32:51 +13:00
306978ee79
cursor positioning nerdery on network config screen
2018-02-20 10:29:24 +13:00
c9f3bd3ae0
fix behaviour of "up" on views that have done initially focused
...
before this, if you press up on e.g. the network view, focus would go to the first nic
not the last as you might expect. this is pretty obscure but oh well. such is urwid.
2018-01-11 11:50:08 +13:00
d77b4148ef
expand NetworkConfigureIPv4InterfaceView tests a bit
2017-12-11 09:52:36 +13:00
67611165df
fix network manual view and add super simple test of it
2017-12-08 09:41:51 +13:00
c85602527e
stop any of the *_btn functions defining a label by default
2017-11-22 13:53:35 +13:00
08e51b87ae
move some listboxs inside their padding
2017-10-20 15:51:01 +13:00
b6a27582c9
redo padding and layout of network views
2017-10-20 14:55:01 +13:00
491ca1e1c0
Indicate which network config method is active.
2017-10-12 11:01:33 -04:00
5507fd0fbc
clunky way of indicating which network config method is active
2017-10-11 21:35:10 +13:00
2c6fb9ed99
hide network error if showing before starting config again
2017-09-28 16:00:35 -04:00
785b4d5568
Fix up more fixed layouts with button_pile().
2017-09-20 14:01:42 +01:00
14fa3cd107
use button_pile helper everywhere
2017-09-20 15:20:32 +12:00
f000fc24eb
add a helper to pad a pile of buttons just enough
2017-09-20 14:55:02 +12:00
9356501aa7
change cancel buttons to back buttons where appropriate
...
and also some "Done" buttons become "Save" buttons.
2017-09-18 17:19:27 +01:00
693f3e7c7d
Barebones i18n setup.
2017-09-18 14:14:39 +01:00
648d7d4086
Buttons
2017-09-18 14:01:11 +01:00
91d57c50f2
a slightly different approach
2017-09-15 10:40:11 +12:00
7c5e55e0b2
Update color palette
...
Create palette for traffic light buttons: green (default), amber and
red. Color-code most buttons.
Make all progressbars orange for the completed part.
2017-09-12 12:05:44 +01:00
1b328dbb61
work around urwid crash
...
see https://github.com/urwid/urwid/issues/253
2017-09-08 12:36:44 +12:00
e0f75ba013
tweaks to network views
...
1) move the done / cancel buttons (and error display) out of scrolling region
2) focus done by default
3) update footer texts to make sense
4) use a bit more of the horizontal space to show interface information
2017-09-08 09:48:41 +12:00
9afd3cbc5a
have escape always remove an overlay view
2017-04-05 15:20:36 +12:00
395b30451e
stop being clever in handling of escape in network screens
2017-04-05 14:36:46 +12:00
f8211b56fb
clean up wifi config view code a bunch
...
(this was the first complicated urwid code i wrote)
2017-03-21 14:47:01 +13:00
62ad81d690
make sure wifi psk is between 8 and 63 characters long
2017-03-21 14:39:23 +13:00
26c1af8328
allow the gateway to be empty for an interface
2017-03-20 14:51:41 +13:00
404ca627da
use evilnick's wording on the network page
2017-03-02 13:52:20 +13:00
2a1fbcd6fe
remove some help leftovers
2017-02-16 12:36:26 +13:00
308a29c75b
move help to an overlay
2017-02-14 16:16:19 +13:00
65f9d1ef62
move show_overlay to BaseView
2017-02-14 16:16:19 +13:00
a6954b49e2
the various editor classes' caption argument is optional now
2017-02-14 15:19:56 +13:00
906af4d41a
simplify forms and edit widgets a bit
2017-02-14 15:16:12 +13:00
3353c851ee
make help appear in same place on identity view as before
2017-02-13 15:50:39 +13:00
ee966f7039
rewrite validation stuff into something like a form library
...
This is inspired by the sort of design e.g. Django uses for its forms.
2017-02-13 14:21:26 +13:00
af2bfc40ef
fix mismerge
2017-02-10 15:42:43 +13:00
9854d5ccce
Merge remote-tracking branch 'origin/master' into mwhudson/ipv4-validation
2017-02-08 16:10:36 +13:00
f0eb2cdf70
make Color.button etc apply the corresponding focus map
...
about 1e6 times more readable
2017-02-08 15:37:18 +13:00
ebddb50483
better validation for manual network view
2017-02-08 13:18:20 +13:00
0627bfe9f4
start to add validation to manual network view
2017-02-08 13:18:20 +13:00
3c5ac3140f
use new containers everywhere
2017-02-03 14:21:39 +13:00
d75cbabb61
move subiquity welcome stuff out of subiquitycore
2017-01-17 12:04:15 +13:00
0caf13181e
Do not say a netdev is not configured when there is no configuration
2017-01-11 15:42:16 +13:00
ae05b66a47
rewrite Selector to work like an HTML <select> widget
...
This was way way harder than it seemed like it should be, but it seems a lot
nicer to me.
For https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1654387
2017-01-09 16:11:32 +13:00
09b8235b07
Fix displaying IPs for login view in subiquitycore.
2016-12-21 17:18:08 -05:00
01c42205f0
Fix identity controller for subiquity; correctly process done signal and displaying local user info.
2016-12-20 15:40:28 -05:00
21d3f78c9c
use a IPv6 example address on manual ipv6 screen
2016-12-15 14:17:49 +13:00
38c600528b
remove some of the ip-version-in-method-name methods
2016-12-12 15:58:41 +13:00
4de99bd41e
use the ip version as a parameter a bunch more
2016-12-12 15:54:33 +13:00
2a716df0ad
add and use NetworkConfigureIPv6InterfaceView
2016-12-12 15:45:45 +13:00
8582e2bc02
network_configure_manual_interface.py -> network_configure_ipv4_interface.py
2016-12-12 15:41:30 +13:00
be69509efa
parameterize NetworkConfigureIPv4InterfaceView
2016-12-12 15:40:07 +13:00
1efaed7648
add network model interfaces that take ip version as a parameter
2016-12-12 15:34:59 +13:00
15bb9afcc2
move identityview to subiquity
...
subiquity and console-conf do not share any view code any more
2016-11-23 09:54:36 +13:00
7c90a9e4da
Fix crash when an interface has more than one IP address of the same family.
2016-11-11 11:29:57 +13:00
344b177f16
validate user input a lot more thoroughly in the static ipv4 view
2016-11-08 11:07:20 +13:00
a7bfef3646
show error message from netplan generate when it fails
2016-11-08 10:39:54 +13:00
8a44befe2a
remove UI for customizing default route, not supported by netplan
...
Yet, anyway.
2016-11-08 10:39:05 +13:00
31b21799b7
remove dependency on netifaces
2016-11-07 16:56:36 +13:00
c4fdf5cb72
allow choosing from visible networks when configuring wifi
2016-11-07 16:56:36 +13:00
cacd456a6a
Adapt to netlink event driven version of probert.
2016-11-07 16:56:32 +13:00
82b11dbd69
reorganize the network model and make the UI a bit more consistent
...
The main change here is to separate the state a network device is in and the
state we want it to be in. So it now parses the netplan config on a system as
well as probing the state of via probert.
The UI is changed to make this distintion too, and be IMO a bit more
consistent. Somewhere in this I've removed the display of whether the
probed address was found via DHCP or not, possibly that should be put
back if it doesn't make things too cluttered.
In dry-run mode, we now still write the config and feed it to netplan, but
in a way that doesn't affect the system we are running it on.
2016-11-07 15:15:46 +13:00
6b99559819
oops
2016-11-02 12:14:01 +13:00
91e42e37bd
Merge branch 'master' into mwhudson/kill-some-signals
2016-11-02 12:00:47 +13:00
6318de27cf
make sure selecting dhcp after manual configuration clears out gateway & nameserver config
2016-10-21 08:59:34 +13:00
6d93221a43
do not add empty strings to nameservers or search_domains
2016-10-21 08:59:09 +13:00
Michael Hudson-Doyle