Michael Hudson-Doyle
7b3bb0278b
fix some more assorted small wlan problems
2021-06-09 15:28:06 +12:00
Michael Hudson-Doyle
fa9628f34c
remove support from network model for filtering out wlan devices
2021-06-09 13:00:43 +12:00
Michael Hudson-Doyle
907e7dd7b0
implement UI for tracking wpasupplicant install state
...
this should perhaps be in the subiquity package vs subiquitycore somehow
but that seems hard.
2021-06-09 13:00:43 +12:00
Michael Hudson-Doyle
47b2836aee
pretend virtual wlan (i.e. mac80211_hwsim) devices are real
...
this allows their use for testing
2021-06-02 12:40:57 +12:00
Michael Hudson-Doyle
d14fd35330
move "enabling wifi turns on dhcp4" behaviour to controller from view
2021-06-02 12:40:50 +12:00
Michael Hudson-Doyle
902c57f7f7
move start_scan error handling into controller
...
report errors via scan_state field
2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle
b84fa27752
call apply_config in controller set_wlan method
2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle
b046608a78
fix type annotations in network model types
2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle
4850cee5ce
NetworkConfigureWLANStretchy.update_link should only care about updates for its nic
...
this was very confusing to debug!
2021-06-02 12:28:44 +12:00
Michael Hudson-Doyle
c325e76e9e
fix the wlan view calls to controller methods to pass just the nic name
2021-06-02 12:28:42 +12:00
Dan Bungert
2719c57c1b
locale - let it check interactive-sections again ( #937 )
...
* locale - let it check interactive-sections again
* Turn Serial into a whole new screen
When in serial, first offer the rich/basic choice (or SSH button),
and only show the current welcome screen if we choose rich mode.
Add a back button on Welcome if we are on serial.
LP: #1919251
2021-04-21 10:11:27 -06:00
Michael Hudson-Doyle
bc2ae6199a
asyncify pubsub a bit
2021-04-13 09:41:43 +12:00
Michael Hudson-Doyle
dab04bcb3a
simple replacement for urwid signals wrapper as used in server
...
I think this removes all use of urwid from the server code.
2021-04-13 09:41:43 +12:00
Michael Hudson-Doyle
b0af11ad02
kill any foreground subprocess before restarting
...
This fixes a problem where you drop to a shell and refresh subiquity
from that shell -- the client tries to restart but it is running in the
background and so crashes trying to modify the terminal settings. So
this kills the subprocess before restarting. This required the extremely
angry PR I sent before: forcefully killing the subprocess also crashes
the client before restart in a similar way.
2021-04-01 17:24:49 +13:00
Michael Hudson-Doyle
939c81920c
do not crash when subshell exits via signal
...
Here is something you can try with a live server installer today: drop
into a subshell and type "kill -9 $$". The installer will crash with an
'Input/output error' from tcsetattr.
What's going on is some deep unix arcana: when the subshell exits via
signal somehow the shell's process group is still in the foreground
(even though there are no processes in it?) and calling tcsetattr() from
a background process is not allowed. So the fix for this is reasonably
simple (or at least: short): call tcsetpgrp() to put our process group
back into the foreground. A background process doing this gets sent
SIGTTOU, but if we ignore that, all is well.
Frankly this is all very strange and I would like a lie down now.
2021-04-01 16:27:05 +13:00
Michael Hudson-Doyle
26593f4c16
Merge pull request #924 from mwhudson/lp-1921820-2
...
more reliably restart client when server restarts
2021-03-31 13:30:56 +13:00
Michael Hudson-Doyle
132440451d
more reliably restart client when server restarts
...
Splitting subiquity into server and client means that in general
old versions of the client can still be running when the server is
updated (the client running on tty1 will be restarted by snapd/systemd
when the snap is updated but clients running via e.g. ssh will not). I
implemented a way for the client to detect this and restart itself: the
server sets a header in all responses that indicates if it has been
updated. So far so good. But the way it knows that it has been updated
is to check the presence of a file that is only created when subiquity
itself triggers the refresh, so it's not there in the case of manual
refresh, and as reported in https://bugs.launchpad.net/bugs/1921820 this
can lead to the client crashing because it cannot parse the new server's
response. This simply changes to creating the marker file in the snap
post-refresh hook, which will be executed for manual snap refreshes as
well.
While I'm at it, remove the rest of the post-install hook that restarted
subiquity clients running on the serial line as the generic machinery
will work for these too.
2021-03-31 13:15:06 +13:00
Michael Hudson-Doyle
64ac97aafe
make subiquity client use new API for guided disk usage
2021-03-30 14:22:28 +13:00
Michael Hudson-Doyle
e3361aa51c
do not set installer user password if it has password or authorized keys
...
dearie me making a nice UI can involve a lot of typing.
2021-03-25 14:26:49 +13:00
Michael Hudson-Doyle
6fa1d9bbd0
fix crash on refresh: change ids are strings in the snapd api
...
for https://bugs.launchpad.net/subiquity/+bug/1913417
2021-02-10 11:43:58 +13:00
Michael Hudson-Doyle
fac0eeed43
fix crash when trying to view nic info
...
fixes half of https://bugs.launchpad.net/subiquity/+bug/1912955
2021-01-27 09:35:09 +13:00
Michael Hudson-Doyle
53d06961cc
append, do not overwrite logs
...
The log file names have pids in now, but when subiquity re-execs itself
to fake a snap refresh the pid doesn't change. Having the pre "refresh"
logs get overwritten does not help anything and is sometimes very
annoying.
2020-12-18 12:18:40 +13:00
Michael Hudson-Doyle
007dd3e5ef
tidy up answers handling a bit and fix a race
2020-12-16 10:21:32 +13:00
Michael Hudson-Doyle
aad036d925
split subiquity.core into subiquity.client.client and subiquity.server.server
2020-11-04 10:57:22 +13:00
Michael Hudson-Doyle
93b8998af6
split NetworkController into non-ui and ui-focused classes
2020-10-12 12:05:56 +13:00
Michael Hudson-Doyle
d6f3f83622
run network answers in run_answers
2020-10-12 11:58:08 +13:00
Michael Hudson-Doyle
287b4492e8
start to factor out bits of networkcontroller that touch the view
2020-10-12 11:47:48 +13:00
Michael Hudson-Doyle
798a9da563
have answers code wait for nic creation/deletion to take effect
...
the UI will not be quite so synchronous in the client/server world
2020-10-12 11:25:50 +13:00
Michael Hudson-Doyle
8dc31a3c6b
change network answers processing to not reference model directly
2020-10-12 11:22:08 +13:00
Michael Hudson-Doyle
f89b9e692a
asyncioify "fine grained action" handling a bit
2020-10-12 11:16:38 +13:00
Michael Hudson-Doyle
673ade7f2a
make core interface a little simpler
2020-10-09 13:12:09 +13:00
Michael Hudson-Doyle
c03f6580fd
move more code that should never have been so generic
2020-10-09 13:08:15 +13:00
Michael Hudson-Doyle
2bf981ebb8
move "last-screen" handling out of generic code
2020-10-09 13:07:04 +13:00
Michael Hudson-Doyle
15ae0bf234
make NetDevInfo.is_connected a bool, as it is supposed to be
2020-09-25 14:33:53 +12:00
Michael Hudson-Doyle
edc43ff811
add a minimal server process
...
run it automatically in dry-run mode
2020-09-22 14:43:26 +12:00
Michael Hudson-Doyle
7d02ee17f6
make zdev view/controller interface more client/server friendly
2020-09-21 21:04:14 +12:00
Michael Hudson-Doyle
bc6c66efbb
give contexts an id and have progressview track them by id not identity
2020-09-21 14:01:40 +12:00
Michael Hudson-Doyle
219360d12d
fixes for how install failures are presented
...
some of these have been around for a while :/
2020-09-21 14:01:23 +12:00
Michael Hudson-Doyle
56441c6f97
small tidies
2020-09-18 22:01:36 +12:00
Michael Hudson-Doyle
9b414df0eb
add a helper to wait and show a dialog if needed
...
use this in snaplist view. cancellation with asyncio is mindbending!
2020-09-18 21:51:14 +12:00
Michael Hudson-Doyle
a7bcc7faf0
add a way to wait for something with notification after 0.1s
...
use this for moving between screens, removing some crummy code from subquity/core.py
2020-09-18 21:18:27 +12:00
Michael Hudson-Doyle
6c258d6da4
allow make_ui to be a coroutine
2020-09-18 11:52:19 +12:00
Michael Hudson-Doyle
f0082c2068
change controller api to return a view, rather than setting it
2020-09-18 11:44:00 +12:00
Michael Hudson-Doyle
eb5dba579e
handle answers in a separate method
2020-09-18 11:18:08 +12:00
Michael Hudson-Doyle
aa3bce4414
do not run the urwid loop at all when not interactive
2020-09-18 09:54:50 +12:00
Michael Hudson-Doyle
45009e3a12
refactor startup a little
...
the point of this is to have the event loop running while loading
autoinstall commands, which means we do not have to start and stop the
event loop inside load_autoinstall_config if there are early-commands to
run.
2020-09-18 09:54:50 +12:00
Michael Hudson-Doyle
88821f745c
Merge pull request #822 from mwhudson/network-simpler-types
...
make network view use a plain-old-data view of a nic
2020-09-18 09:54:13 +12:00
Michael Hudson-Doyle
85b35c9e87
steal contextlib from Python 3.8
...
Python 3.6's does not have asynccontextmanager.
2020-09-11 16:55:26 +12:00
Michael Hudson-Doyle
01e9c04ab5
Merge pull request #817 from mwhudson/tuiapplication
...
remove all UI code from "core" application object, add tuiapplication
2020-09-10 11:31:30 +12:00
Michael Hudson-Doyle
f4066d97d7
convert controller api methods to take strings and trigger updates for affected nics
...
this is going to work better in the client/server world
2020-09-03 22:52:31 +12:00
Michael Hudson-Doyle
f32c74c86d
address review comments
2020-09-03 12:31:25 +12:00
Michael Hudson-Doyle
04426cec15
make network view use a plain-old-data view of a nic
...
The network view code used to crawl all over the network model object,
which isn't really going to work with the upcoming client/server split.
So this adds a much better defined interface between the view and
controller.
2020-09-03 11:12:38 +12:00
Michael Hudson-Doyle
e367226f47
fix crash on renaming bond
2020-08-25 13:55:20 +12:00
Michael Hudson-Doyle
edc65dbbfb
make the base controller have no ui, add subclass for one that has ui
2020-08-23 23:18:28 +12:00
Michael Hudson-Doyle
f6757af8d1
fix restarting after refresh
2020-08-23 23:18:28 +12:00
Michael Hudson-Doyle
f5f8a8a75c
import the controllers module explicitly
2020-08-23 23:18:28 +12:00
Michael Hudson-Doyle
ccd8c2382e
split urwid-using bits out of subiquitycore.core.Application
2020-08-23 23:18:26 +12:00
Michael Hudson-Doyle
bc1060eefa
make ControllerSet more re-usable
2020-08-23 22:59:39 +12:00
Michael Hudson-Doyle
63f5f57f30
Merge pull request #804 from mwhudson/screen-refactor
...
Move the code for setting up the screen to its own file
2020-08-23 22:43:42 +12:00
Tsunghan Liu (Robert Liu)
e798451c27
Ignore CAN and unknown interfaces (LP: #1890397 )
...
Add CAN and unknown interfaces to NETDEV_IGNORED_IFACE_TYPES, otherwise rander_config() will throw a KeyError exception when a unsupported interface shows up.
2020-08-07 21:04:05 +08:00
Michael Hudson-Doyle
210cdcb51b
Move the code for setting up the screen to its own file
...
Looking at this code thinking about the coming client / server split
made me realise that we could start by at least moving this
functionality to a more encapsulated place.
2020-07-27 23:40:17 +12:00
Michael Hudson-Doyle
6b26b668be
fix formatting of error message
2020-07-22 12:27:04 +12:00
Michael Hudson-Doyle
9271f17dd2
move subiquity.snapd to subiquitycore.snapd
2020-07-02 12:56:49 +12:00
Michael Hudson-Doyle
97b5c64805
do not crash in NetworkController._data_ready if ui.body is not a widgetwrap
...
for https://bugs.launchpad.net/subiquity/+bug/1881887
2020-06-12 15:01:58 +12:00
Michael Hudson-Doyle
a9dd3757f1
Merge pull request #761 from mwhudson/still-better-i18n
...
more work towards being able to provide good translations
2020-05-21 12:38:51 +12:00
Michael Hudson-Doyle
3e881df107
Merge pull request #778 from mwhudson/ascii-toggle
...
start in a super basic mode on serial, offer upgrade immediately
2020-05-21 12:05:47 +12:00
Dimitri John Ledkov
e2fe2a0693
Merge pull request #773 from xnox/snap-create-user-error
...
console_conf: fix showing error messages, when snap create-user fails
2020-05-21 01:02:31 +01:00
Michael Hudson-Doyle
0d267b320e
only allow downgrading color/ascii experience on serial
...
and collapse ascii/color choice to a single 'rich' toggle
2020-05-21 11:41:16 +12:00
Michael Hudson-Doyle
7bcfcba99b
Merge branch 'master' into still-better-i18n
2020-05-21 11:15:32 +12:00
Michael Hudson-Doyle
b85f8118b7
update the network view when wlan dialod is saved
2020-05-19 11:53:03 +12:00
Michael Hudson-Doyle
c523e21c34
update wlan dialog when scan results come in
2020-05-19 11:53:03 +12:00
Michael Hudson-Doyle
7236771d2f
correctly enable dhcp4 when configuring a ssid for a wlan interface
2020-05-19 11:53:03 +12:00
Michael Hudson-Doyle
acd6ee0032
Merge pull request #775 from mwhudson/logged-passwords-lp-1879381
...
do not log wifi passwords from existing configs
2020-05-19 11:25:44 +12:00
Michael Hudson-Doyle
e588d6475f
do not log wifi passwords from existing configs
2020-05-19 07:47:33 +12:00
Dimitri John Ledkov
debc34cb3c
Fix typo
2020-05-18 19:59:47 +01:00
Dimitri John Ledkov
6de8970560
console_conf: fix showing error messages, when snap create-user fails
2020-05-18 12:42:14 +01:00
Dimitri John Ledkov
da1477ba01
network: fix wifi screen
...
WiFi screen was broken since NetDev refactor. Unbreak it.
2020-05-18 12:00:42 +01:00
Michael Hudson-Doyle
812f33cab6
default to setting up LVM in guided storage screen
2020-05-13 16:34:35 +12:00
Michael Hudson-Doyle
24abf5dd4e
fix some lint found by new version of flake8
2020-05-12 10:41:54 +12:00
Michael Hudson-Doyle
a05b030085
fix lint
2020-05-08 15:44:07 +12:00
Michael Hudson-Doyle
21ed91d7d3
add comments, contexts for some translatable strings
...
from scanning though about one third of subiquity.pot
2020-05-08 15:40:59 +12:00
Michael Hudson-Doyle
59c47254e7
use pgettext in one place, add support for extracting it
2020-05-08 15:13:15 +12:00
Michael Hudson-Doyle
33bdc90780
copy gettext.py from python 3.8 and use it
2020-05-08 15:09:46 +12:00
Michael Hudson-Doyle
3060a03bd6
make some things slightly better
2020-05-08 15:06:24 +12:00
Michael Hudson-Doyle
2d65fe4f16
attempt to make providing a good translation easier
...
* annotate a few missed string literals with _()
* try to consistently use named placeholders when formatting strings
for display (i.e. _("frob the {thing}") not _("frob the {}")
* run selector values, form captions and form help through _() before
display
* use ngettext in one place. not sure if there need to be more...
* reduce cuteness about how strings are constructed in a few places
2020-05-06 21:16:24 +12:00
Michael Hudson-Doyle
4e3996f3f8
improve with_context helper a bit, use it more
...
the decorated function must now be called with keyword arguments
2020-05-05 16:20:03 +12:00
Michael Hudson-Doyle
4891d76aca
actually write the netplan from the autoinstall config to the target system
...
I got lost in a forest of similarly named methods :(
2020-05-04 19:37:43 +12:00
Michael Hudson-Doyle
bc37b2c628
add a helper to make it easier to next contexts appropriately
...
i want this to help debug another branch i am working on!
2020-05-04 18:44:47 +12:00
Michael Hudson-Doyle
d15e5f25fa
remove mistakenly added backup files
2020-05-01 13:45:59 +12:00
Michael Hudson-Doyle
5dc2895481
add the ability to remove a particular overlay, not just the top one
2020-05-01 12:46:45 +12:00
Michael Hudson-Doyle
7e9c1412b9
introduce and use a state_path helper for finding things in /run
2020-05-01 09:58:06 +12:00
Michael Hudson-Doyle
37a62f21aa
fix travis some more
2020-04-30 20:56:09 +12:00
Michael Hudson-Doyle
b66ad552f8
make default_netplan valid, for some reason this causes issues sometimes on travis
2020-04-30 20:25:14 +12:00
Michael Hudson-Doyle
6007b4dc41
do not crash in a terminal < 76 columns wide
...
for https://bugs.launchpad.net/ubuntu-z-systems/+bug/1874314
2020-04-28 21:32:46 +12:00
Michael Hudson-Doyle
88165ce5fd
use a cleaner way of attaching controllers to contexts
2020-04-24 14:45:20 +12:00
Michael Hudson-Doyle
9ff059eae7
put zdev rows directly in a listbox, not in a pile in a listbox
...
this required adding TableListRow.set_contents.
it fixes (partly by accident) a crash when a row becomes unselectable
after a refresh (https://bugs.launchpad.net/subiquity/+bug/1874114 ), it
also makes the home and end keys do something sane.
really this view should not rebuild every row on any change, but that's
something for another day.
2020-04-22 15:36:06 +12:00
Dimitri John Ledkov
760fbaa22f
Review comments
2020-04-16 00:22:52 +01:00
Dimitri John Ledkov
a70d309f6a
Use common palette.
...
Fixes header frindge colors in console-conf.
2020-04-09 12:20:16 +01:00
Dimitri John Ledkov
f3b1a70822
Merge pull request #692 from bboozzoo/bboozzoo/chooser-tweaks
...
console_conf: various recover chooser tweaks
2020-04-09 10:59:39 +01:00
Maciej Borzecki
a33a477324
subiquitycore/core: fix typo in comments
...
Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
2020-04-07 15:35:47 +02:00