The trap on ERR doesn't trigger in all the cases that we want.
The EXIT trap seems to be more robust, albeit with the requirement to
actually check the result code.
Move from using .subiquity as output-base to a tmpdir. This solves
several practical problems, like accidentally running the tests while
dryrun is open in another terminal or any other case where the server
process that is connected to is not the one that is expected.
Also makes cleanup nicer.
On failure, it will show which temporary directory was used to allow for
easy log examination.
To allow customization where an install iso can have the autoinstall
data, and to ignore that in favor of autoinstall from cloud-config, this
implements a more specific order of loading from the possible locaitons.
Also, the chosen file is set aside, and then is top priority if the
subiquity process is reloaded.
Grow a new API for enabling/disabling systemd experimental support. We
do this by chaining a specific command= in the boot section.
We preserve the user customized command= content when systemd
experimental support is not enabled.
Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
In addition to autoinstall_key, controllers can now define an
autoinstall_key_alias.
The purpose of this attribute is to provide a backward compatibility
mechanism when we need to change the name of an autoinstall_key for
whatever reason.
When loading autoinstall data, if we can't find data matching the
autoinstall_key, we will now also look for data matching the key alias.
In the JSON schema, the old name (i.e., autoinstall_key_alias) will be
marked deprecated and the description will have the name of the
replacement key (i.e., autoinstall_key).
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
If you run dryrun for console-conf, go to the network page, go to an
interface, then info, a crash of the form
TypeError: object str can't be used in 'await' expression
can be seen. The signature for the core version of get_info_for_netdev
is not async, but a non-async method returning str.
So mark the core version of the function async.
Co-authored-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
Building with --destructive-mode fails with error:
dh install
dh_testroot
dh_testroot: error: You must run this as root (or use fakeroot).
make: *** [debian/rules:6: install] Error 255
Use fakeroot for installation.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
The build instruction contain a step
PYTHONPATH=probert ./probert/bin/probert --all > mymachine.json
This requires package os-prober.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Running `make install_depends` does not (always) pull python3-systemd
which is a dependency of Subiquity.
In environments having Install-Recommends enabled, python3-systemd is
pulled by apport which is itself pulled by python3-apport.
Fixed by adding it to the list of dependencies in apt-deps.txt
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Dan Bungert