Commit Graph

2902 Commits

Author SHA1 Message Date
Michael Hudson-Doyle 2765e6a773 replace next-screen/prev-screen signals with method calls 2019-12-16 23:02:03 +13:00
Michael Hudson-Doyle 4c92e2dd53 make the snaplist code more async 2019-12-16 22:49:14 +13:00
Michael Hudson-Doyle 7e7ca080f6
Merge pull request #604 from mwhudson/tab-cycling-oddity
fix tab-cycling between header and body
2019-12-16 21:37:20 +13:00
Michael Hudson-Doyle 7b697a1978
Merge pull request #602 from mwhudson/selector-non-text
allow Selector to have non-text entries
2019-12-16 21:36:45 +13:00
Michael Hudson-Doyle 8ae0a72184
Merge pull request #603 from mwhudson/simplify-subform
simplify SubForm stuff a bit
2019-12-16 21:33:19 +13:00
Michael Hudson-Doyle b41560fc4c fix tab-cycling between header and body 2019-12-16 21:32:25 +13:00
Michael Hudson-Doyle 9736825e32 simplify SubForm stuff a bit 2019-12-16 21:21:57 +13:00
Michael Hudson-Doyle 6913294de6 EXTREMELY OBSCURE fix
without this, selectors get skipped over when selecting the first element in a
pile if the label is some kind of container.
2019-12-16 21:15:46 +13:00
Michael Hudson-Doyle 9759957f36 allow Selector to have non-text entries 2019-12-16 13:28:42 +13:00
Michael Hudson-Doyle 394cfc723c handle check task being cancelled while view is shown 2019-12-16 12:41:43 +13:00
Michael Hudson-Doyle de18cc977f make SingleInstanceTask.start_sync set self.task synchronously 2019-12-16 12:33:19 +13:00
Michael Hudson-Doyle b639d3a4dd do not have a request to v2/changes failing crash the ui 2019-12-16 11:50:38 +13:00
Michael Hudson-Doyle c44a15d4c3 straigthen out refresh logic and handle failed update better 2019-12-16 11:40:29 +13:00
Michael Hudson-Doyle 930d479e85 make the refresh view code use asyncio apis 2019-12-16 09:54:48 +13:00
Michael Hudson-Doyle 5173e46b33
Merge pull request #600 from mwhudson/fix-probing-failures
stop block probing failures from crashing the process
2019-12-15 09:53:47 +13:00
Michael Hudson-Doyle fe08311c19 stop block probing failures from crashing the process
There is a common problem in concurrent / asynchronous code of what to
do with unhandled exceptions. If a (conceptual) thread of execution
fails, there's no guarantee (and no way of telling) if there's anything
listening.  By default, I chose to have a failing task propagate the
exception up to the run loop for two reasons:

 1) Unhandled exceptions are generally bad
 2) urwid.ExitMainLoop needs to be propagated to the run loop to have
    any effect

But this means that tasks that are expected to fail (and have this
failure handled) like block probing crash the process, which is
obviously a Bad Thing. This branch adds a way to turn off exception
propagation per-task, which is a bit hackish but works ok it seems.
2019-12-15 09:45:14 +13:00
Michael Hudson-Doyle bd3ede4c21
Merge pull request #595 from mwhudson/remove-run_in_bg
remove run_in_bg

the asyncioification is complete (apart from bug fixes)
2019-12-15 09:44:09 +13:00
Michael Hudson-Doyle 6d4ea2bf34
Merge pull request #596 from xnox/uc20
Unbreak console-conf in UC20 images
2019-12-15 09:04:03 +13:00
Michael Hudson-Doyle ae5cd6268a kill off run_in_bg and some related hacks 2019-12-15 08:53:37 +13:00
Michael Hudson-Doyle a92b88ed9d asyncioify run_command_in_foreground 2019-12-15 08:53:36 +13:00
Michael Hudson-Doyle 614ebc415e stop using run_in_bg for setting the snapd proxy 2019-12-15 08:53:00 +13:00
Michael Hudson-Doyle 735966d163 use run_in_bg for uploading crash reports 2019-12-15 08:53:00 +13:00
Michael Hudson-Doyle d62636cf44 use run_in_thread for adding info to crash reports 2019-12-15 08:53:00 +13:00
Dimitri John Ledkov 8e882235be
Merge pull request #593 from mwhudson/asyncio-filesystem
asyncioify filesystem controller
2019-12-14 17:41:14 +00:00
Dimitri John Ledkov d6689d9200
Merge pull request #594 from mwhudson/asyncio-ssh
asyncioify ssh
2019-12-14 16:48:55 +00:00
Dimitri John Ledkov b4ff1bde70
Merge pull request #599 from mwhudson/radiobuttonfield
add a RadioButtonField for forms
2019-12-14 16:47:29 +00:00
Michael Hudson-Doyle a2fc6da694 add a RadioButtonField for forms 2019-12-14 22:35:19 +13:00
Michael Hudson-Doyle 285eeee0ed
Merge pull request #598 from mwhudson/repeatedcontroller-index
fix RepeatedController
2019-12-14 22:16:07 +13:00
Michael Hudson-Doyle 7078d47af6
Merge pull request #597 from mwhudson/no-ui-controller
add a class for controllers with no ui
2019-12-14 22:15:54 +13:00
Michael Hudson-Doyle 0090aec3be fix RepeatedController
a snap update was offered the second time even if it had been
offered already
2019-12-14 21:44:10 +13:00
Michael Hudson-Doyle 5571e1fab3 add a class for controllers with no ui
there will be a bunch of these coming for autoinstall
2019-12-14 21:27:39 +13:00
Dimitri John Ledkov d19e405666 Unbreak console-conf in UC20 images 2019-12-14 03:00:17 +00:00
Michael Hudson-Doyle 1db2c7ee5c asyncioify the ssh controller 2019-12-13 11:49:49 +13:00
Michael Hudson-Doyle 05a61544fb asyncio.create_subprocess_exec defaults stdin to None 2019-12-13 11:44:12 +13:00
Michael Hudson-Doyle b500df5ecc fix behaviour after a failed probe 2019-12-13 10:15:58 +13:00
Michael Hudson-Doyle 17251ce431 fix updating after a slow probe 2019-12-13 10:15:58 +13:00
Michael Hudson-Doyle eee1280de4 asyncioify filesystem controller 2019-12-13 10:15:58 +13:00
Michael Hudson-Doyle 2ad6f0b2ee
Merge pull request #585 from mwhudson/asyncio-network
asyncioify network controller
2019-12-13 10:15:34 +13:00
Michael Hudson-Doyle 6703efd03e document SingleInstanceTask a bit in DESIGN.md 2019-12-13 10:05:49 +13:00
Michael Hudson-Doyle 992e131b5f squash all exceptions when cancelling the task in SingleInstanceTask
otherwise restarting a failed task just raises the exception from the previous
failure
2019-12-13 10:05:23 +13:00
Michael Hudson-Doyle 4e1afd60a4 do not always stop networkd 2019-12-13 10:04:57 +13:00
Michael Hudson-Doyle b155d3eff0 have apply_config task exit as soon as all dhcp NICs have an address 2019-12-13 10:04:31 +13:00
Michael Hudson-Doyle 08e081415d move async_helpers to subiquitycore 2019-12-13 10:04:02 +13:00
Michael Hudson-Doyle 5a7abd99b7 only run network answers once 2019-12-13 10:03:46 +13:00
Michael Hudson-Doyle eb228ab7f3 introduce a helper for a restartable task
(there are going to be a few of these)
2019-12-13 10:03:32 +13:00
Michael Hudson-Doyle 2d1bd0011d a little refactoring 2019-12-13 09:40:15 +13:00
Michael Hudson-Doyle a260bebc0b rip out TaskSequence 2019-12-13 09:39:48 +13:00
Michael Hudson-Doyle 19f8f91d29 asyncify network controller 2019-12-13 09:39:13 +13:00
Michael Hudson-Doyle efed69ff7c some asyncifying of network 2019-12-13 09:37:36 +13:00
Michael Hudson-Doyle b65a8177a3
Merge pull request #591 from mwhudson/asyncio-installation
asyncioify installation
2019-12-13 09:14:13 +13:00