Commit Graph

310 Commits

Author SHA1 Message Date
Michael Hudson-Doyle a73b76c7d2 clear any validation error as soon as the field becomes valid
this is why I changed size's validation to be side-effect free in the last
commit...
2017-10-05 16:19:31 +13:00
Michael Hudson-Doyle 876e2dc1b7 change partition size field to only modify user input explicitly on loss of focus 2017-10-05 16:16:31 +13:00
Michael Hudson-Doyle eafd614ce9 simplify things a bit by removing the ability to pass validator= and cleaner= to form fields 2017-10-05 15:45:16 +13:00
Michael Hudson-Doyle 35988f2fd9 change form machinery to always have space for validation error
and display help, if present, there by default
2017-10-05 15:08:10 +13:00
Michael Hudson-Doyle aa564b9f6a ACTUALLY let udev queue settle rather than just pretending to 2017-09-29 08:37:31 -04:00
Michael Hudson-Doyle 3221599cb1 default routes can appear via CHANGE as well as NEW 2017-09-29 08:37:24 -04:00
Michael Hudson-Doyle 393055622c always super-call route_change 2017-09-29 08:37:19 -04:00
Michael Hudson-Doyle d35a7e08d8 Merge pull request #248 from CanonicalLtd/mwhudson/better-colors
color tweaks
2017-09-28 17:28:42 -04:00
Michael Hudson-Doyle 2c6fb9ed99 hide network error if showing before starting config again 2017-09-28 16:00:35 -04:00
Michael Hudson-Doyle cd85358a1b overwrite more of the console palette 2017-09-28 09:58:09 -04:00
Michael Hudson-Doyle 86ac32905b change the progress bar to show x / y rather than a %age
Also make its progress more automatic.
2017-09-26 09:01:22 -04:00
Michael Hudson-Doyle b60c0d33f5 have enter advance to the next focus item in piles and listboxes 2017-09-21 15:30:50 +12:00
Dimitri John Ledkov 785b4d5568
Fix up more fixed layouts with button_pile(). 2017-09-20 14:01:42 +01:00
Michael Hudson-Doyle 14fa3cd107 use button_pile helper everywhere 2017-09-20 15:20:32 +12:00
Michael Hudson-Doyle f000fc24eb add a helper to pad a pile of buttons just enough 2017-09-20 14:55:02 +12:00
Dimitri John Ledkov 790a1bf213
Fixup the merge due to changes on master. 2017-09-18 17:31:43 +01:00
Michael Hudson-Doyle 9356501aa7
change cancel buttons to back buttons where appropriate
and also some "Done" buttons become "Save" buttons.
2017-09-18 17:19:27 +01:00
Dimitri John Ledkov a6413ed87f
Refresh Button labels upon init. 2017-09-18 14:20:13 +01:00
Dimitri John Ledkov 693f3e7c7d
Barebones i18n setup. 2017-09-18 14:14:39 +01:00
Dimitri John Ledkov 648d7d4086
Buttons 2017-09-18 14:01:11 +01:00
Michael Hudson-Doyle a0fd94c0c4 remove connect_signal wrapper 2017-09-15 11:48:07 +12:00
Michael Hudson-Doyle ef54021b21 convert identity view 2017-09-15 11:04:38 +12:00
Michael Hudson-Doyle 91d57c50f2 a slightly different approach 2017-09-15 10:40:11 +12:00
Michael Hudson-Doyle 183e7f88b7 start process of using more semantic palette names
also make button helpers apply the palette by default
2017-09-14 14:51:56 +12:00
Dimitri John Ledkov 00c4fe935b
Setup orange for fbterm too 2017-09-12 14:28:08 +01:00
Dimitri John Ledkov 7c5e55e0b2
Update color palette
Create palette for traffic light buttons: green (default), amber and
red. Color-code most buttons.

Make all progressbars orange for the completed part.
2017-09-12 12:05:44 +01:00
Michael Hudson-Doyle e2b0dfa495 Merge branch 'master' into mwhudson/screen-review 2017-09-11 09:37:57 +12:00
Michael Hudson-Doyle 32261c3905 Merge branch 'master' into mwhudson/guided-partitioning
Fixing a few conflicts.
2017-09-11 09:26:09 +12:00
Michael Hudson-Doyle 7a09db2cd4 ridiculous stuff to show ubuntu orange on the linux tty 2017-09-08 15:59:30 +12:00
Michael Hudson-Doyle 1b328dbb61 work around urwid crash
see https://github.com/urwid/urwid/issues/253
2017-09-08 12:36:44 +12:00
Michael Hudson-Doyle e0f75ba013 tweaks to network views
1) move the done / cancel buttons (and error display) out of scrolling region
2) focus done by default
3) update footer texts to make sense
4) use a bit more of the horizontal space to show interface information
2017-09-08 09:48:41 +12:00
Michael Hudson-Doyle 977459ea62 pretty up and colorify subiquity a bit 2017-09-07 22:47:56 +12:00
Michael Hudson-Doyle 34f1e67d49 make it possible for subiquity and console_conf to use different colours 2017-09-07 21:37:48 +12:00
Michael Hudson-Doyle a9de883e0b tidy up palette definitions a bunch 2017-09-07 21:21:50 +12:00
Michael Hudson-Doyle 44b9334a28 allow editing partitions
there is some wonky stuff around mount point validation, to be fixed next
2017-09-05 14:25:21 +12:00
Michael Hudson-Doyle 4a54ca9e50 start making the partition form usable in other views 2017-09-05 11:58:49 +12:00
Michael Hudson-Doyle 923044be7e move Selector widget to its own file and create a class for its Options
I wanted this so I can enable/disable options after creating the widget.
2017-09-05 09:43:45 +12:00
Michael Hudson-Doyle 641f437fd7 do not ask guided/manual on re-entering config screen if any configuration has been done 2017-08-29 09:24:29 +12:00
Michael Hudson-Doyle ae5fee60c6 Merge pull request #207 from CanonicalLtd/cyphermox/snap
Add snapcraft.yaml and some fixes for working as a snap.
2017-04-06 12:40:45 +12:00
Michael Hudson-Doyle 9afd3cbc5a have escape always remove an overlay view 2017-04-05 15:20:36 +12:00
Michael Hudson-Doyle b3241d6b15 remove general clever escape handling 2017-04-05 15:16:30 +12:00
Michael Hudson-Doyle 395b30451e stop being clever in handling of escape in network screens 2017-04-05 14:36:46 +12:00
Mathieu Trudel-Lapierre d0976cd4da Merge branch 'master' into cyphermox/snap 2017-03-23 11:49:18 -04:00
Michael Hudson-Doyle c49b810336 have IntegerEditor.value return an integer, fixing broken partition numbers in the curtin config 2017-03-23 09:02:37 +13:00
Mathieu Trudel-Lapierre 4987e741d7 Merge branch 'master' into cyphermox/snap 2017-03-22 08:58:48 -04:00
Michael Hudson-Doyle f8211b56fb clean up wifi config view code a bunch
(this was the first complicated urwid code i wrote)
2017-03-21 14:47:01 +13:00
Michael Hudson-Doyle 62ad81d690 make sure wifi psk is between 8 and 63 characters long 2017-03-21 14:39:23 +13:00
Michael Hudson-Doyle 32578fb35e make sure waiting for the default route times out properly
see https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1672803
2017-03-21 13:38:35 +13:00
Michael Hudson-Doyle f1b97508fa dry-run fix 2017-03-20 15:03:32 +13:00
Michael Hudson-Doyle 26c1af8328 allow the gateway to be empty for an interface 2017-03-20 14:51:41 +13:00
Michael Hudson-Doyle 3f425c9e05 make the netplan file name and path depend (very slightly) on subiquity vs console-conf 2017-03-16 22:52:05 +13:00
Michael Hudson-Doyle 0d48ef1836 avoid wrapping captions in forms 2017-03-13 11:52:19 +13:00
Michael Hudson-Doyle 8cd4b020ee finish formatting/mounting available partitions 2017-03-10 15:46:21 +13:00
Michael Hudson-Doyle 66c1d94a4b consolidate mountpoint validation a bit 2017-03-07 21:10:03 +13:00
Michael Hudson-Doyle ad2a92a67d protection against empty containers when tabbing 2017-03-07 20:37:38 +13:00
Mathieu Trudel-Lapierre 3098d108b2 Support special paths for environment check binaries in snaps. 2017-03-06 13:28:44 -05:00
Michael Hudson-Doyle ff75b7a7fe fix crash on disappearing network interface
By being more careful about accessing self.focus in FocusTrackingMixin.

Fixes https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1667829
2017-03-02 21:34:12 +13:00
Michael Hudson-Doyle 404ca627da use evilnick's wording on the network page 2017-03-02 13:52:20 +13:00
Michael Hudson-Doyle 19ec2b5c41 only suggest the user logs in via scope global addresses 2017-02-17 14:21:54 +13:00
Michael Hudson-Doyle 8af0639dd4 cope with probert API changes 2017-02-17 12:37:47 +13:00
Michael Hudson-Doyle 2a1fbcd6fe remove some help leftovers 2017-02-16 12:36:26 +13:00
Michael Hudson-Doyle 693ca3d9bf fix a widget with no selectable widgets losing focus 2017-02-16 11:26:38 +13:00
Michael Hudson-Doyle 308a29c75b move help to an overlay 2017-02-14 16:16:19 +13:00
Michael Hudson-Doyle 65f9d1ef62 move show_overlay to BaseView 2017-02-14 16:16:19 +13:00
Michael Hudson-Doyle b00378304c I simplified RestrictedEditor a bit too much 2017-02-14 16:07:36 +13:00
Michael Hudson-Doyle 69f2b08684 simplify RestrictedEditor a whole bunch more 2017-02-14 15:27:25 +13:00
Michael Hudson-Doyle a6954b49e2 the various editor classes' caption argument is optional now 2017-02-14 15:19:56 +13:00
Michael Hudson-Doyle 906af4d41a simplify forms and edit widgets a bit 2017-02-14 15:16:12 +13:00
Michael Hudson-Doyle 3353c851ee make help appear in same place on identity view as before 2017-02-13 15:50:39 +13:00
Michael Hudson-Doyle a2062aaf57 convert identity view to use new validation stuff
help looks different though
2017-02-13 15:37:29 +13:00
Michael Hudson-Doyle 1e8322b05f remove old validation stuff 2017-02-13 15:14:20 +13:00
Michael Hudson-Doyle e58697a29c simplify api around enabling form fields 2017-02-13 15:12:04 +13:00
Michael Hudson-Doyle 1bd00a843a allow form fields to be enabled or disabled 2017-02-13 14:59:25 +13:00
Michael Hudson-Doyle 00c807dc9e convert add_partition view to new world
no enabling/disabling yet though
2017-02-13 14:48:53 +13:00
Michael Hudson-Doyle ee966f7039 rewrite validation stuff into something like a form library
This is inspired by the sort of design e.g. Django uses for its forms.
2017-02-13 14:21:26 +13:00
Michael Hudson-Doyle 472339a62b fixes for tabbing into/out of list boxes 2017-02-13 13:52:17 +13:00
Michael Hudson-Doyle af2bfc40ef fix mismerge 2017-02-10 15:42:43 +13:00
Michael Hudson-Doyle 9854d5ccce Merge remote-tracking branch 'origin/master' into mwhudson/ipv4-validation 2017-02-08 16:10:36 +13:00
Michael Hudson-Doyle f0eb2cdf70 make Color.button etc apply the corresponding focus map
about 1e6 times more readable
2017-02-08 15:37:18 +13:00
Michael Hudson-Doyle ebddb50483 better validation for manual network view 2017-02-08 13:18:20 +13:00
Michael Hudson-Doyle 0627bfe9f4 start to add validation to manual network view 2017-02-08 13:18:20 +13:00
Michael Hudson-Doyle 50b927fcc2 the start of an excessively general way of validating input 2017-02-07 14:02:07 +13:00
Michael Hudson-Doyle 1a9f0dc5dd make the mount point editing stuff into a single widget
and use it on "format entire disk" page
2017-02-07 10:28:56 +13:00
Michael Hudson-Doyle d372f0e306 respect _command_map 2017-02-06 22:12:38 +13:00
Michael Hudson-Doyle 9b94b567d6 refactor TabCyclingListBox to resemble TabCyclingMixin 2017-02-06 22:11:04 +13:00
Michael Hudson-Doyle abbc21c5fa simplify TabCyclingMixin a whole bunch 2017-02-06 22:05:16 +13:00
Michael Hudson-Doyle c8c468ff8e make some names less cryptic, add license info, docstrings 2017-02-06 21:38:19 +13:00
Michael Hudson-Doyle 3c5ac3140f use new containers everywhere 2017-02-03 14:21:39 +13:00
Michael Hudson-Doyle 3d2d2c79ea custom versions of urwid containers that support tab-cycling 2017-02-03 14:19:37 +13:00
Michael Hudson-Doyle 0aae936d63 remove previous tab "support" 2017-02-03 14:15:54 +13:00
Michael Hudson-Doyle 6426369fcb allow Selector to have disabled entries 2017-02-02 14:34:59 +13:00
Michael Hudson-Doyle 2408dda6c7 remove references to firstboot (an old name for console-conf?) 2017-01-26 11:18:03 +13:00
Michael Hudson-Doyle 8524e2bfe9 recommend some common mount points per spec 2017-01-25 16:39:28 +13:00
Michael Hudson-Doyle f00b60342c tweak Selector to be more ascii and close on escape 2017-01-25 16:20:46 +13:00
Michael Hudson-Doyle 78ca3c610f make disable_subiquity work again
this makes selecting "quit installer" at the end of installation work
2017-01-25 14:38:03 +13:00
Michael Hudson-Doyle 58af7dbb3b add some arrows to dropdown widget 2017-01-20 13:19:16 +13:00
Michael Hudson-Doyle a4d6682478 simpler api for doing stuff in a background thread 2017-01-18 12:03:56 +13:00
Michael Hudson-Doyle fa95fb55ad make callfromthread functionality more available, use it in installprogress 2017-01-18 12:02:34 +13:00
Michael Hudson-Doyle 8ede2d730c and with that, we no longer depend on tornado 2017-01-18 12:02:34 +13:00
Michael Hudson-Doyle d75cbabb61 move subiquity welcome stuff out of subiquitycore 2017-01-17 12:04:15 +13:00