Didier Roche
34b621ee66
Merge pull request #1165 from CarlosNihelton/fix-wsl-snap-env
...
[SystemSetup] Fix L-S-C behavior under WSL snap environment
2022-01-21 15:56:42 +01:00
Carlos Nihelton
0d30deac7f
Promotes the "--no-checks" to outside of dry-run
...
Tests in real WSL2 environment revealed that update-locale checks fails but with the "--no-checks" option it updates the locale files accordingly and when the image restarts the locale is correctly set.
2022-01-18 10:18:45 -03:00
Carlos Nihelton
a14a143d55
Fix l-s-c behavior under SNAP environment.
...
- By passing the datadir command line option.
2022-01-17 11:57:04 -03:00
Carlos Nihelton
957d56a52f
FIx unbound variable in live run
2022-01-17 10:48:58 -03:00
Olivier Gayot
3d3994f3f3
Fix return type of __recommended_languages_pack
...
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
2022-01-14 13:02:25 +01:00
Carlos Nihelton
e429babb03
Fixes potential false positive UID findings
...
Also, splits part of the configure() method:
- `__query_uid()` finds the username UID
- `_create_user()` creates the user set in IdentityModel
- Both methods accept a fake root path under dryrun.
2021-12-17 10:35:38 -03:00
Carlos Nihelton
b17c3d3db9
Cleanup complete.
...
- No user setup in wsl.conf
- Shutdown controller creates the launcher-command file
2021-12-14 12:13:00 -03:00
Carlos Nihelton
22a8219cb3
Dryrun won't stop configure controller due C-L-S
...
- Also noticed a possible unbound var in IOError handler.
2021-11-24 11:35:31 -03:00
Carlos Nihelton
a88fcdb8b3
Explicit case for c-l-s failure by returning None
2021-11-22 13:42:45 -03:00
Carlos Nihelton
37758047f2
Improved control over lang packs on integration
...
- Dryrun should never return empty packages list unless under failure.
- runtests check if the mimic-installed files match the proper language.
2021-11-22 12:16:01 -03:00
Carlos Nihelton
1e6c4472a5
Complementary to 1127 on integration side
2021-11-17 13:26:41 -03:00
Dan Bungert
1eefb7a9e5
check-language-support: fix empty pkg list
...
The check-language-support on my machine was providing a single empty
newline as output, and the length check isn't catching that as the
resulting packages array has a value of [''].
Drop empty values from the list to avoid a "KeyError: ''" exception.
2021-11-17 07:23:16 -07:00
Didier Roche
dde0a6d53c
Merge pull request #1116 from CarlosNihelton/ft-wsl-locale-deeng-31
...
System locale manipulation wired into Subiquity.
2021-11-16 08:43:51 +01:00
Carlos Nihelton
377e880cb5
Style improvements.
2021-11-12 16:04:02 -03:00
Carlos Nihelton
4bb8ee3b3b
SystemSetupModel now acks the variant at start.
...
- Without this change, wsl_configuration variant is not reckon without
client_variant.POST.
- Issue and suggestions of fixes originally reported by jpnurmi.
2021-11-11 09:22:10 -03:00
Carlos Nihelton
a1fd0615f8
Slipped on the linter.
2021-11-09 18:34:58 -03:00
Carlos Nihelton
409ac4157a
From weird splits into regex
2021-11-09 18:15:59 -03:00
Carlos Nihelton
63d565b89c
Write text files instead of wget
2021-11-09 18:15:20 -03:00
Carlos Nihelton
4e050ecddb
Style improvements.
2021-11-09 09:36:10 -03:00
Carlos Nihelton
f9d3877feb
Corrected list type hint for Python 3.8.
...
- CI failed on Focal due Python version unable to understand list[str].
2021-11-08 19:03:10 -03:00
Carlos Nihelton
eb6bd2d263
Smaller functions, early returns and funny mocking
2021-11-08 13:11:30 -03:00
Carlos Nihelton
6be4aea138
l-s-c as dep on Makefile, avoid raising exceptions
...
- And clear .subiquity/var/cache
2021-11-05 18:09:15 -03:00
Carlos Nihelton
5f9f2122ce
System locale manipulation wired into Subiquity.
...
- We don't have cloud-init in WSL.
- Subiquity must perform any actions to support the choosen locale.
- l-s-c package added as dependency.
2021-11-05 17:29:33 -03:00
Carlos Nihelton
106b8c758e
Temporary fix for integration tests chroot'ing
...
useradd -R does chroot.
useradd -P doesn't.
2021-11-03 15:53:02 -03:00
Didier Roche
277fe55599
Don’t block on running commands in configure
...
Those commands needs to be async to be able to still answer GET/POST
request while configure is running.
This allows showing up the summary page immediately.
Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
2021-11-03 12:35:25 +01:00
Didier Roche
f762f41a5b
Don’t override syslog dir to prevent printing on TUI.
...
Co-authored-by: Jean-Baptiste Lallement <jean-baptiste@ubuntu.com>
2021-11-03 10:32:57 +01:00
Carlos Nihelton
af91bb0a6f
Removing dead code.
...
- My bad.
2021-10-29 20:23:16 -03:00
Carlos Nihelton
4c0ad44738
Moving logic form SystemSetupModel to controllers.
...
- In order to stay confined into system_setup,
WSLLocaleController had to be recriated.
2021-10-29 12:53:06 -03:00
Carlos Nihelton
2125acffe6
WSL Locale controller is not needed anymore.
...
- With 'prefill' working, calling Powershell to find Windows locale
is not required anymore.
- Since `f21986be` subiquity's default locale controller respects
mode.selected_language initialization.
2021-10-28 15:52:24 -03:00
Carlos Nihelton
168a5c13a0
SystemSetupModel handles 'prefill' data
...
- Init method changed to accept that data, which could be None.
- If valid, user Identity and Locale are prepopulated.
- Server parses the YAML and send valid info (or None) to the Model.
2021-10-28 15:52:24 -03:00
Patrick Wu
a3fce9f9c2
system_setup: add useradd tests
2021-10-20 00:27:10 +08:00
Patrick Wu
ec04a6833a
system_setup: shutdown/reboot tests
2021-10-18 17:15:45 +08:00
Didier Roche
31fa83e79e
Merge pull request #1078 from canonical/wsl_oobe_deeng_83
...
DEENG-83 - Implement a reboot in shutdown to restart WSL instances to take new configuration in effect.
2021-10-12 18:13:07 +02:00
Patrick Wu
1d19dfb772
system_setup: implement shutdown/reboot action
2021-10-12 23:20:05 +08:00
Patrick Wu
8559d7fe7d
modulizing the usergroup retriving
2021-10-12 10:07:45 +08:00
Patrick Wu
271b72b41a
system_setup: setup user with wsl.conf
2021-10-11 15:33:46 +08:00
Patrick Wu
7ae8e108a6
system_setup: include full autoinstall system
2021-10-11 10:20:18 +08:00
Patrick Wu
1c111c764c
system_setup: write files to .subiquity when dryrun
2021-10-07 16:25:07 +08:00
Patrick Wu
c934268813
system_setup: changes and fixes
...
1. rebase with main and update autoinstall-system-setup.yml
2. provide a more unified indent style
3. update get_userandgroups() to the dropped one
4. fix the problematic os action
5. simply asignments
6. assign default_loader a default value
7. provide a type-to-file dict in wsl_conf
8. provide stderr info when providing error in creating user
9. update schema and example files
2021-10-06 22:13:15 +08:00
Patrick Wu
1a7274dbba
system_setup: unify api names and simply WSLconfig class into function
2021-10-06 22:13:15 +08:00
Patrick Wu
5c0e64e78a
system_setup: address the run_command fail issue
2021-10-06 22:13:15 +08:00
Patrick Wu
9fbff87fe1
system_setup: changes to the get-usersandgroups
2021-10-06 22:13:15 +08:00
Patrick Wu
32a62748c9
system_setup: initial redesign of generic config handler
...
Also have to change the logic for default loader
2021-10-06 22:13:15 +08:00
Patrick Wu
f31e252436
system_setup: reduce code duplication in getting default value
2021-10-06 22:13:15 +08:00
Patrick Wu
225cb1bd37
system_setup: fixes for after rebasing
...
1. add extra logs
2. improve the answers file
3. await the self.configured in wslconf API
2021-10-06 22:13:15 +08:00
Patrick Wu
032412a938
system_setup: provide configuration calls
2021-10-06 22:13:15 +08:00
Patrick Wu
a211689e08
system_setup: update client_variant to variant
2021-10-06 22:13:15 +08:00
Patrick Wu
0a0c53a61b
system_setup: move all write file actions to configure controller
...
This completes 5. Move all “Commits/Write to file” in the configure controller.
2021-10-06 22:13:15 +08:00
Jean-Baptiste Lallement
6cc8c6169b
Fix crash with autoinstall on non-systemd env
...
On WSL and any system without systemd the server crashes becauses
the syslog id is always set (and never None) and systemd cat cannot
connect to the journal.
We cant set the id to None because the API expects a string, so the
check "is not None" is always true.
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-10-04 13:09:24 -07:00
Jean-Baptiste Lallement
44b0b66531
Block shutdown controller on installation done
...
A race existed due to ~he shutdown controller not waiting for the
install task to be complete.
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
2021-09-28 09:32:39 +02:00