SingleInstanceTask has distinct steps for creation of the object, and
starting the task. If a different coroutine is waiting on the
SingleInstanceTask, it isn't safe to directly call
SingleInstanceTask.wait() as the task may or may not have been created
yet.
Existing code usage of SingleInstanceTask is in 4 categories, with
reguards to SingleInstanceTask.wait():
1) using SingleInstanceTask without using SingleInstanceTask.wait().
This is unchanged.
2) using SingleInstanceTask.wait without a check on task is not None.
This may be safe now, but is fragile in the face of innocent-looking
refactors around the SingleInstanceTask.
3) using SingleInstanceTask.wait after confirming that the task is not
None. This is fine but a leaky abstraction.
4) directly waiting on the SingleInstanceTask.task. Another leaky
abstraction, but it's solving a cancellation problem. Leaving this
alone.
By enhancing SingleInstanceTask.wait(), cases 2 and 3 are improved. The
code not checking the task today is made safer, and the code checking
the task today can be simplified.
We aren't close to hitting this timeout in unit tests that I can see,
but some of the asyncio tests I'm writing for now risk a hang and I
don't want to get CI stuck.
A reasonably common type of bug report is hitting the block probing
timeout. That timeout is at 15 seconds today. Extend that to 90
seconds, and log the time it takes.
As a performance exercise, it would be good to know where that time is
being spent and why it takes 10x longer or more for some people.
I couldn't find a way to set the variant as desktop in the autoinstall
file or command line.
Thus some shell scripting hackery runs curl to set the variant.
Also, GET /active_directory must provide user and domain, thus updating
the password and curl'ing again configures the AD controller.
When installing a package, try the package download up to three times
before giving up.
The install is only tried once.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
When apt is run as root, APT tries to drop privileges by setuid-ing to
the APT::Sandbox::User user (i.e., _apt by default). This does not work
for us when doing mirror testing because the default sandbox user does
not have access to the overlay. Therefore, APT produces a warning and
reverts to unsandboxed downloads.
Let's force apt to use unsandboxed downloads by setting root as the
sandbox user. This has the same result but avoids showing a warning in
the APT output during mirror testing.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Sadly, passing an alternative config file to apt using -o CLI options
does not work because apt:
1) Reads the configuration file first
2) Reads CLI options (and override specified settings) second
Therefore, the default configuration file is always read, instead of the
one we supply.
To specify an alternative configuration file, the recommendation from
the apt maintainer is to supply an APT_CONFIG variable, hinting apt to
read said file instead of the default.
We now generate a temporary file, write the directives we need to it
using the python apt library, and then execute apt-get with a path to
this temporary file set in APT_CONFIG.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
AD is by nature an optional feature.
Yet, we need to make its model part of the POSTINSTALL_MODEL_NAMES set.
That would turn this into a required controller.
Thus, explicitly mark AD as configured
For as long as TUI doesn't have a matching controller.
Michael Hudson-Doyle