Ryan Harper
0fa5dcab28
pep8 fixes
2018-05-24 16:51:51 -05:00
Ryan Harper
c8d4c51ddd
pep8 fixes
2018-05-24 16:51:51 -05:00
Ryan Harper
ae9412159d
Don't use __name__ in getLogger
2018-05-24 16:51:51 -05:00
Ryan Harper
13ca352291
pep8 fixes for subiquitycore/ui/views/network_configure_wlan_interface.py
2018-05-24 16:51:51 -05:00
Ryan Harper
591be4ecbc
pep8 fixes for subiquitycore.ui.views.network_default_route
2018-05-24 16:51:51 -05:00
Ryan Harper
45fabd78f2
pep8 fixes for subiquitycore.ui.views.tests.test_network_configure_manual_interface
2018-05-24 16:51:51 -05:00
Ryan Harper
f2715a4735
pep8 fixes for subiquitycore.controllers.network
2018-05-24 16:51:51 -05:00
Ryan Harper
b7e60f7b91
pep8 fixes for subiquitycore.testing.view_hewlpers
2018-05-24 16:51:51 -05:00
Ryan Harper
40caacaca3
pep8 fixes for subiquitycore.models.network
2018-05-24 16:51:51 -05:00
Ryan Harper
acd24c0796
Add pep8 script
2018-05-24 16:51:51 -05:00
Ryan Harper
a0bf68f3c4
pyflakes3 fixes
...
Add and enable pyflakes3 on console_conf, subiquity, subiquitycore and tests.
Replace NOQA markers with __all__ declarations for module imports.
Replace some obvious deadcode that voilates flake8, separate pass for removing
dead code rather than commenting will be handled later.
2018-05-24 16:51:51 -05:00
Ryan Harper
86216997f3
Add missing 'sig' parameter in confirm callback
2018-05-24 16:51:51 -05:00
Ryan Harper
2b41811d65
Remove unused 'os' import
2018-05-24 16:51:51 -05:00
Ryan Harper
0849db7c14
Add pyflakes3 target and script
2018-05-24 16:51:49 -05:00
Michael Hudson-Doyle
bd48ed9b1d
remove SimpleList
...
and the Body widget, both utterly trivial
2018-05-25 09:35:25 +12:00
Michael Hudson-Doyle
752b15eac3
fix welcome screen when LANG is set in environment
...
https://bugs.launchpad.net/subiquity/+bug/1773216
2018-05-25 09:29:52 +12:00
Michael Hudson-Doyle
dce672609a
Merge pull request #342 from smoser/cleanup/makefile-pythonpath
...
Makefile: Always put PYTHONPATH into environment
2018-05-25 09:14:07 +12:00
Scott Moser
d71cb7cadf
Makefile: Always put PYTHONPATH into environment
...
Just use 'export PYTHONPATH' in the Makefile so that we all targets
have that in their environment.
2018-05-24 12:47:16 -04:00
Ryan Harper
ae94db26ac
Merge pull request #340 from raharper/fix/drop-dead-code
...
Drop commented out / dead code
2018-05-24 08:55:31 -05:00
Michael Hudson-Doyle
8f914a9dbd
proxy tweaks
...
only send network-proxy-set if proxy has changed
fix proxy_systemd_dropin
2018-05-24 15:33:03 +12:00
Ryan Harper
6558fa553e
Re-add Hebrew, marked as noqa
2018-05-23 18:55:14 -05:00
Ryan Harper
3c9b2e28c7
Drop commented out / dead code
2018-05-23 18:53:12 -05:00
Michael Hudson-Doyle
a30c3a63e4
Merge pull request #341 from CanonicalLtd/mwhudson/scollbars-as-decoration
...
convert ScrollBarListBox to decoration rather than subclass
2018-05-24 10:39:41 +12:00
Michael Hudson-Doyle
0fe1f5145c
sprinkle in some more ".base_widget"s
2018-05-23 13:40:14 +12:00
Michael Hudson-Doyle
7441cb6df6
convert ScrollBarListBox to decoration rather than subclass
...
for all the usual reasons why composition is better than inheritance,
but in particular because I want to have a listbox that has a scrollbar
but not our custom tab behaviour in another branch. decoration in urwid
is not as transparent as it sometimes seems it should be but luckily
there's only one view that does much with its listbox and it was due
for some cleanup anyway.
2018-05-23 13:14:00 +12:00
Michael Hudson-Doyle
626488e988
Merge pull request #334 from CanonicalLtd/mwhudson/move-excerpt-title-to-view
...
move excerpt, title and footer from controller to view
2018-05-22 22:38:39 +12:00
Michael Hudson-Doyle
8d6a966e89
Merge pull request #338 from raharper/fix/subprocess_encoding
...
Fix/subprocess encoding
2018-05-22 10:01:24 +12:00
Ryan Harper
a84dd2b272
Encoding input when running commands
2018-05-21 13:35:26 -05:00
Ryan Harper
74ae9b9fde
Drop use of encoding kwarg to subprocess for python3.5 compat
2018-05-21 11:54:34 -05:00
Ryan Harper
e1a6542d86
run_command returns a CalledProcess object, no 'output' attribute, but 'stdout' instead
2018-05-21 11:29:41 -05:00
Michael Hudson-Doyle
79208bc00b
trap a TaskSequence gotcha
2018-05-21 13:09:56 +12:00
Michael Hudson-Doyle
4f531724bc
fix identity crash
2018-05-21 12:56:05 +12:00
Michael Hudson-Doyle
70ec850aad
Merge pull request #336 from CanonicalLtd/mwhudson/hack-ThreadPoolExecutor
...
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:59:12 +12:00
Michael Hudson-Doyle
384dadc5ed
hack to stop ThreadPoolExecutor blocking exit
2018-05-21 11:58:10 +12:00
Michael Hudson-Doyle
381d0bda8e
Merge pull request #335 from CanonicalLtd/mwhudson/move-tasksequence
...
move TaskSequence somewhere more generic
2018-05-21 11:57:23 +12:00
Michael Hudson-Doyle
f6f214125f
move TaskSequence somewhere more generic
...
I want to reuse it in my containerizing branch.
Improve API and docs a bit while I am looking at it.
2018-05-21 11:52:06 +12:00
Michael Hudson-Doyle
feda622ed2
hack setup.py to avoid needing to import subiquitycore
...
or else build_i18n fails!
2018-05-21 10:30:17 +12:00
Michael Hudson-Doyle
cbd5afe2c0
move imports of i18n higher so _ is always installed before tests are imported
2018-05-21 10:14:34 +12:00
Michael Hudson-Doyle
ac875751fb
fix installprogress
2018-05-18 16:27:05 +12:00
Michael Hudson-Doyle
ba0625bd6b
convert identity
2018-05-18 16:18:27 +12:00
Michael Hudson-Doyle
9ef2c4d7a2
convert filesystem views
...
impatient to get on with rewriting these as part of the raid work...
2018-05-18 16:14:10 +12:00
Michael Hudson-Doyle
f36525b740
convert proxy
2018-05-18 15:58:34 +12:00
Michael Hudson-Doyle
11708703c9
move titles, footers, excerpts from controller to view
...
read title and footer from the view instance, make views respsonsible for rendering
the excerpt
adapts infrastructure, welcome, keyboard, network views
2018-05-18 15:55:49 +12:00
Michael Hudson-Doyle
bdf2bd35a7
Merge pull request #329 from CanonicalLtd/mwhudson/proxy-tweaks
...
configure proxy for apt and snapd in installed system
2018-05-18 14:01:23 +12:00
Michael Hudson-Doyle
ff0af44ee7
Merge pull request #328 from CanonicalLtd/mwhudson/fetch-ssh-keys-earlier
...
have subiquity fetch ssh keys rather than cloud-init
2018-05-18 14:00:08 +12:00
Michael Hudson-Doyle
80f99deee8
use new, improved subprocess wrapper
2018-05-18 13:53:51 +12:00
Michael Hudson-Doyle
8e288537cd
lint
2018-05-18 13:53:51 +12:00
Michael Hudson-Doyle
368c3a9ddb
more refactoring
2018-05-18 13:53:51 +12:00
Michael Hudson-Doyle
1309b68bdd
make control flow a bit more comprehensible
2018-05-18 13:53:51 +12:00
Michael Hudson-Doyle
a06e07d5dd
a bit more
2018-05-18 13:53:51 +12:00