Merge pull request #1878 from ogayot/console-conf-network-crash

network: ensure we pass tasks to asyncio.wait
This commit is contained in:
Olivier Gayot 2023-12-12 10:03:48 +01:00 committed by GitHub
commit ea909d1428
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions

View File

@ -169,7 +169,8 @@ class NetworkController(BaseNetworkController, SubiquityController):
with context.child("wait_dhcp"): with context.child("wait_dhcp"):
try: try:
await asyncio.wait_for( await asyncio.wait_for(
asyncio.wait({e.wait() for e in dhcp_events}), 10 asyncio.wait({asyncio.create_task(e.wait()) for e in dhcp_events}),
10,
) )
except asyncio.TimeoutError: except asyncio.TimeoutError:
pass pass

View File

@ -391,7 +391,9 @@ class BaseNetworkController(BaseController):
return return
try: try:
await asyncio.wait_for(asyncio.wait({e.wait() for e in dhcp_events}), 10) await asyncio.wait_for(
asyncio.wait({asyncio.create_task(e.wait()) for e in dhcp_events}), 10
)
except asyncio.TimeoutError: except asyncio.TimeoutError:
pass pass