From 7f233bc09b00cc885a76a3d9305bea0707bf0c31 Mon Sep 17 00:00:00 2001
From: Dan Bungert <daniel.bungert@canonical.com>
Date: Thu, 16 Jun 2022 11:00:33 -0600
Subject: [PATCH] unittests: fix group check

The recently changed group list check is a bit fragile to the exact
groups available on the system.  Mock out the list of actually existing
groups.
---
 subiquity/models/tests/test_subiquity.py | 27 ++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/subiquity/models/tests/test_subiquity.py b/subiquity/models/tests/test_subiquity.py
index c7163c4d..c92b761b 100644
--- a/subiquity/models/tests/test_subiquity.py
+++ b/subiquity/models/tests/test_subiquity.py
@@ -15,6 +15,7 @@
 
 import fnmatch
 import unittest
+from unittest import mock
 import yaml
 
 from subiquitycore.pubsub import MessageHub
@@ -28,6 +29,24 @@ from subiquity.server.server import (
     )
 from subiquity.server.types import InstallerChannels
 
+getent_group_output = '''
+root:x:0:
+daemon:x:1:
+bin:x:2:
+sys:x:3:
+adm:x:4:syslog
+tty:x:5:syslog
+disk:x:6:
+lp:x:7:
+mail:x:8:
+news:x:9:
+uucp:x:10:
+man:x:12:
+sudo:x:27:
+ssh:x:118:
+lxd:x:132:
+'''
+
 
 class TestModelNames(unittest.TestCase):
 
@@ -182,7 +201,8 @@ class TestSubiquityModel(unittest.TestCase):
         config = model.render()
         self.assertNotIn('apt', config)
 
-    def test_cloud_init_user_list_merge(self):
+    @mock.patch('subiquitycore.utils.run_command')
+    def test_cloud_init_user_list_merge(self, run_cmd):
         main_user = IdentityData(
             username='mainuser',
             crypted_password='dummy_value',
@@ -193,14 +213,17 @@ class TestSubiquityModel(unittest.TestCase):
             model = self.make_model()
             model.identity.add_user(main_user)
             model.userdata = {'users': [secondary_user]}
+
+            run_cmd.return_value.stdout = getent_group_output
             cloud_init_config = model._cloud_init_config()
             self.assertEqual(len(cloud_init_config['users']), 2)
             self.assertEqual(cloud_init_config['users'][0]['name'], 'mainuser')
             self.assertEqual(
                 cloud_init_config['users'][0]['groups'],
-                'adm,cdrom,dip,lxd,plugdev,sudo'
+                'adm,lxd,sudo'
             )
             self.assertEqual(cloud_init_config['users'][1]['name'], 'user2')
+            run_cmd.assert_called_with(['getent', 'group'], check=True)
 
         with self.subTest('Secondary user only'):
             model = self.make_model()