From a8e3f9a2184f8cf7038dd05544c522962fb397c9 Mon Sep 17 00:00:00 2001 From: Carlos Nihelton Date: Tue, 10 May 2022 09:58:59 -0300 Subject: [PATCH] Removes the comprehension expression with := Prevents flake8 error on Focal. --- subiquity/server/controllers/identity.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/subiquity/server/controllers/identity.py b/subiquity/server/controllers/identity.py index d08eec8d..017c2084 100644 --- a/subiquity/server/controllers/identity.py +++ b/subiquity/server/controllers/identity.py @@ -35,14 +35,16 @@ USERNAME_REGEX = r'[a-z_][a-z0-9_-]*' def _reserved_names_from_file(path: str) -> Set[str]: + names = set() if os.path.exists(path): with open(path, "r") as f: - return { - s.split()[0] for line in f.readlines() - if (s := line.strip()) and not s.startswith("#") - } - else: - return set() + for line in f: + line = line.strip() + if not line or line.startswith('#'): + continue + names.add(line.split()[0]) + + return names class IdentityController(SubiquityController):