From 9ff8e10ef5cc3fe6409a4092d1cd658203fc0932 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lallement Date: Thu, 7 Apr 2022 10:54:18 +0200 Subject: [PATCH] Do not run apt update in dry-run mode update requires root access to the machine and there is no --simulate option so skip it in dry-run mode. Co-authored-by: Didier Roche --- system_setup/server/controllers/configure.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/system_setup/server/controllers/configure.py b/system_setup/server/controllers/configure.py index 6bc85ba5..80d4f60d 100644 --- a/system_setup/server/controllers/configure.py +++ b/system_setup/server/controllers/configure.py @@ -186,9 +186,10 @@ class ConfigureController(SubiquityController): log.error('Failed to detect recommended language packs.') return False - cp = await arun_command([aptCommand, "update"], env=env) - if cp.returncode != 0: - log.debug("Failed to update apt cache.\n%s", cp.stderr) + if not self.app.opts.dry_run: + cp = await arun_command([aptCommand, "update"], env=env) + if cp.returncode != 0: + log.debug("Failed to update apt cache.\n%s", cp.stderr) if self.app.opts.dry_run: # only empty in dry-run on failure. if len(packages) == 0: