Merge pull request #801 from mwhudson/lp-1887997

fix some simple crashes seen in the error tracker

subiquity/models/filesystem.py

@@ -1199,6 +1199,10 @@ class LVM_LogicalVolume(_Formattable):
     def flag(self):
         return None  # hack!
 
+    @property
+    def is_esp(self):
+        return False  # another hack!
+
     def desc(self):
         return _("LVM logical volume")
 

subiquity/ui/views/help.py

@@ -290,6 +290,8 @@ class OpenHelpMenu(WidgetWrap):
             rich = menu_item(
                 _("Toggle rich mode"), on_press=self.parent.toggle_rich)
             buttons.add(rich)
+        local_title = None
+        if hasattr(parent.app.ui.body, 'local_help'):
             local_title, local_doc = parent.app.ui.body.local_help()
         if local_title is not None:
             local = menu_item(

subiquity/ui/views/refresh.py

@@ -185,7 +185,7 @@ class RefreshView(BaseView):
             ])
         buttons.base_widget.focus_position = 1
 
-        self.title = self.failed_title
+        self.title = self.check_failed_title
         self._w = screen(rows, buttons, excerpt=_(self.failed_excerpt))
 
     def try_check_again(self, sender=None):

subiquitycore/ui/views/network_configure_manual_interface.py

@@ -112,7 +112,7 @@ class NetworkConfigForm(Form):
         if address not in subnet:
             raise ValueError(
                 _("'{address}' is not contained in '{subnet}'").format(
-                    address, subnet)
+                    address=address, subnet=subnet)
                 )
         return address