From 6e991433968104e9e0eafa7f4bde947949903084 Mon Sep 17 00:00:00 2001 From: lambda-propaganda <79592049+lambda-propaganda@users.noreply.github.com> Date: Mon, 6 Sep 2021 14:27:54 +0100 Subject: [PATCH 1/2] Update snaplist.py fix: done() is called before the snap has loaded causing Attribute error --- subiquity/ui/views/snaplist.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/subiquity/ui/views/snaplist.py b/subiquity/ui/views/snaplist.py index efa96dc5..2efd0711 100644 --- a/subiquity/ui/views/snaplist.py +++ b/subiquity/ui/views/snaplist.py @@ -462,6 +462,10 @@ class SnapListView(BaseView): "package, publisher and versions available.")) def done(self, sender=None): + if not hasattr(self, 'selections_by_name'): + log.warning('failed to obtain a snaps selection') + return self.offer_retry() + log.debug("snaps to install %s", self.selections_by_name) self.controller.done(sorted( self.selections_by_name.values(), From 2181b15a87763aa4abacc48ec98f82c259d612ca Mon Sep 17 00:00:00 2001 From: Dan Bungert Date: Sun, 3 Oct 2021 18:26:08 -0600 Subject: [PATCH 2/2] views/snaplist: set a default selected list --- subiquity/ui/views/snaplist.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/subiquity/ui/views/snaplist.py b/subiquity/ui/views/snaplist.py index 2efd0711..9ced374e 100644 --- a/subiquity/ui/views/snaplist.py +++ b/subiquity/ui/views/snaplist.py @@ -116,6 +116,7 @@ class SnapInfoView(WidgetWrap): self.parent = parent self.snap = snap self.needs_focus = True + self.selections_by_name = {} self.description = Text(snap.description.replace('\r', '').strip()) self.lb_description = ListBox([self.description]) @@ -462,10 +463,6 @@ class SnapListView(BaseView): "package, publisher and versions available.")) def done(self, sender=None): - if not hasattr(self, 'selections_by_name'): - log.warning('failed to obtain a snaps selection') - return self.offer_retry() - log.debug("snaps to install %s", self.selections_by_name) self.controller.done(sorted( self.selections_by_name.values(),