StealthOS/subiquity
StealthOS
/
subiquity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1913 from Chris-Peterson444/netplan-comment 

update rationale for netplan config permissions
This commit is contained in:
Chris Peterson 2024-02-16 15:26:54 -08:00 committed by GitHub
parent c8501d81db 7f388aded2
commit 477fef9590
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
subiquity/models/network.py
View File

@ -38,11 +38,12 @@ class NetworkModel(CoreNetworkModel):
def render(self): def render(self):
netplan = self.render_config() netplan = self.render_config()
# We write wifi config -- which almost certainly contains secrets -- to # We write the wifi config -- which almost certainly contains secrets --
# a separate file with more restrictive permissions. This isn't a # to a separate file since it's possible the default file may
# perfect solution because in principle there could be wired 802.1x # be shared (e.g., via apport for a bug report) and we don't want to
# stuff that has secrets too but the subiquity UI does not support any # leak them. This isn't a perfect solution because in principle there
# of that yet so this will do for now. # could be wired 802.1x stuff that has secrets too, but the subiquity
# UI does not support any of that yet so this will do for now.
# If host cloud-init version has no readable combined-cloud-config, # If host cloud-init version has no readable combined-cloud-config,
# default to False. # default to False.
@ -63,7 +64,6 @@ class NetworkModel(CoreNetworkModel):
} }
else: else:
# Separate sensitive wifi config from potentially shared config # Separate sensitive wifi config from potentially shared config
# e.g. via apport
wifis = netplan["network"].pop("wifis", None) wifis = netplan["network"].pop("wifis", None)
r = { r = {
"write_files": { "write_files": {