From 3e9de290be8295da5a4735260b90502c045a21e3 Mon Sep 17 00:00:00 2001 From: Dan Bungert Date: Tue, 29 Aug 2023 23:22:27 -0600 Subject: [PATCH] refresh: fix crash during autoinstall Controllers have started, but we have decided that no refresh check is needed, so no check_task was started (or assigned). GET /refresh is called, resulting in: DEBUG subiquity.server.server:446 request to /refresh?wait=true crashed Traceback (most recent call last): File "subiquity/server/controllers/refresh.py", line 233, in GET await self.check_task.wait() AttributeError: 'NoneType' object has no attribute 'wait' --- subiquity/server/controllers/refresh.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subiquity/server/controllers/refresh.py b/subiquity/server/controllers/refresh.py index c37d8529..283f28c2 100644 --- a/subiquity/server/controllers/refresh.py +++ b/subiquity/server/controllers/refresh.py @@ -229,7 +229,7 @@ class RefreshController(SubiquityController): return change async def GET(self, wait: bool = False) -> RefreshStatus: - if wait: + if self.active and wait: await self.check_task.wait() return self.status