move async_helpers to subiquitycore

DESIGN.md

@@ -148,7 +148,7 @@ controllers don't have a corresponding model class.
 If the UI does not block, as promised above, then there needs to be a way of
 running things in the background and subiquity uses
 [asyncio](https://docs.python.org/3/library/asyncio.html) for this.
-`subiquity.async_helpers` defines two useful helper functions:
+`subiquitycore.async_helpers` defines two useful helper functions:
 
  * `run_in_thread` (just a nicer wrapper around `run_in_executor`)
  * `schedule_task` (a wrapper around `create_task` / `ensure_future`)

subiquity/controllers/error.py

@@ -31,13 +31,12 @@ import requests
 
 import urwid
 
-from subiquitycore.controller import BaseController
-from subiquitycore.core import Skip
-
-from subiquity.async_helpers import (
+from subiquitycore.async_helpers import (
     run_in_thread,
     schedule_task,
     )
+from subiquitycore.controller import BaseController
+from subiquitycore.core import Skip
 
 
 log = logging.getLogger('subiquity.controllers.error')

subiquity/controllers/installprogress.py

@@ -32,18 +32,17 @@ from curtin.commands.install import (
 from systemd import journal
 
 import yaml
-
+from subiquitycore.async_helpers import (
+    run_in_thread,
+    schedule_task,
+    )
+from subiquitycore.controller import BaseController
 from subiquitycore.utils import (
     arun_command,
     astart_command,
     run_command,
     )
-from subiquitycore.controller import BaseController
 
-from subiquity.async_helpers import (
-    run_in_thread,
-    schedule_task,
-    )
 from subiquity.controllers.error import ErrorReportKind
 from subiquity.ui.views.installprogress import ProgressView
 

subiquity/controllers/keyboard.py

@@ -15,9 +15,9 @@
 
 import logging
 
+from subiquitycore.async_helpers import schedule_task
 from subiquitycore.controller import BaseController
 
-from subiquity.async_helpers import schedule_task
 from subiquity.models.keyboard import KeyboardSetting
 from subiquity.ui.views import KeyboardView
 

subiquity/controllers/mirror.py

@@ -18,12 +18,12 @@ import logging
 import requests
 from xml.etree import ElementTree
 
-from subiquitycore.controller import BaseController
-
-from subiquity.async_helpers import (
+from subiquitycore.async_helpers import (
     run_in_thread,
     schedule_task,
     )
+from subiquitycore.controller import BaseController
+
 from subiquity.ui.views.mirror import MirrorView
 
 log = logging.getLogger('subiquity.controllers.mirror')

subiquity/controllers/refresh.py

@@ -19,12 +19,12 @@ import os
 
 import requests.exceptions
 
+from subiquitycore.async_helpers import (
+    schedule_task,
+    )
 from subiquitycore.controller import BaseController
 from subiquitycore.core import Skip
 
-from subiquity.async_helpers import (
-    schedule_task,
-    )
 
 log = logging.getLogger('subiquity.controllers.refresh')
 

subiquity/controllers/snaplist.py

@@ -17,12 +17,12 @@ import logging
 
 import requests.exceptions
 
+from subiquitycore.async_helpers import (
+    schedule_task,
+    )
 from subiquitycore.controller import BaseController
 from subiquitycore.core import Skip
 
-from subiquity.async_helpers import (
-    schedule_task,
-    )
 from subiquity.models.snaplist import SnapSelection
 from subiquity.ui.views.snaplist import SnapListView
 

subiquity/snapd.py

@@ -25,7 +25,7 @@ from urllib.parse import (
     urlencode,
     )
 
-from subiquity.async_helpers import run_in_thread
+from subiquitycore.async_helpers import run_in_thread
 from subiquitycore.utils import run_command
 
 import requests_unixsocket

subiquitycore/controllers/network.py

@@ -22,19 +22,18 @@ import yaml
 
 from probert.network import IFF_UP, NetworkEventReceiver
 
+from subiquitycore.async_helpers import SingleInstanceTask
+from subiquitycore.controller import BaseController
+from subiquitycore.file_util import write_file
 from subiquitycore.models.network import BondParameters, sanitize_config
+from subiquitycore import netplan
 from subiquitycore.ui.views.network import (
     NetworkView,
     )
-from subiquitycore.controller import BaseController
 from subiquitycore.utils import (
     arun_command,
     run_command,
     )
-from subiquitycore.file_util import write_file
-from subiquitycore import netplan
-
-from subiquity.async_helpers import SingleInstanceTask
 
 
 log = logging.getLogger("subiquitycore.controller.network")