From 069f0c76a7ea8511016897d966d47a245bf598f7 Mon Sep 17 00:00:00 2001
From: Chad Smith <chad.smith@canonical.com>
Date: Mon, 1 Aug 2022 23:15:11 +0000
Subject: [PATCH] subiquity.controllers.userdata: validate
 autoinstall.user-data schema

Raise SchemaValidationError when any autoinstall.user-data config
is invalid cloud-init cloud-config schema.

If any deprecated config keys or values are provided under
autoinstall.user-data, log warnings about those deprecations.
---
 .../server/controllers/tests/test_userdata.py | 63 +++++++++++++++++++
 subiquity/server/controllers/userdata.py      |  8 +++
 2 files changed, 71 insertions(+)
 create mode 100644 subiquity/server/controllers/tests/test_userdata.py

diff --git a/subiquity/server/controllers/tests/test_userdata.py b/subiquity/server/controllers/tests/test_userdata.py
new file mode 100644
index 00000000..4900f7d9
--- /dev/null
+++ b/subiquity/server/controllers/tests/test_userdata.py
@@ -0,0 +1,63 @@
+# Copyright 2022 Canonical, Ltd.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as
+# published by the Free Software Foundation, either version 3 of the
+# License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import unittest
+
+from subiquity.server.controllers.userdata import (
+    UserdataController,
+)
+from subiquitycore.tests.mocks import make_app
+
+from cloudinit.config.schema import SchemaValidationError
+try:
+    from cloudinit.config.schema import SchemaProblem
+except ImportError:
+    def SchemaProblem(x, y): return (x, y)  # TODO(drop on cloud-init 22.3 SRU)
+
+
+class TestUserdataController(unittest.TestCase):
+    def setUp(self):
+        self.controller = UserdataController(make_app())
+
+    def test_load_autoinstall_data(self):
+        with self.subTest('Valid user-data resets userdata model'):
+            valid_schema = {"ssh_import_id": ["you"]}
+            self.controller.model = {"some": "old userdata"}
+            self.controller.load_autoinstall_data(valid_schema)
+            self.assertEqual(self.controller.model, valid_schema)
+
+        fake_error = SchemaValidationError(
+            schema_errors=(
+                SchemaProblem(
+                    "ssh_import_id",
+                    "'wrong' is not of type 'array'"
+                ),
+            ),
+        )
+        invalid_schema = {"ssh_import_id": "wrong"}
+        validate = self.controller.app.base_model.validate_cloudconfig_schema
+        validate.side_effect = fake_error
+        with self.subTest('Invalid user-data raises error'):
+            with self.assertRaises(SchemaValidationError) as ctx:
+                self.controller.load_autoinstall_data(invalid_schema)
+            expected_error = (
+                "Cloud config schema errors: ssh_import_id: 'wrong' is not of"
+                " type 'array'"
+            )
+            self.assertEqual(expected_error, str(ctx.exception))
+            validate.assert_called_with(
+                data=invalid_schema,
+                data_source="autoinstall.user-data"
+            )
diff --git a/subiquity/server/controllers/userdata.py b/subiquity/server/controllers/userdata.py
index 77e743e0..c74dda23 100644
--- a/subiquity/server/controllers/userdata.py
+++ b/subiquity/server/controllers/userdata.py
@@ -13,8 +13,12 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import logging
+
 from subiquity.server.controller import NonInteractiveController
 
+log = logging.getLogger("subiquity.server.controllers.userdata")
+
 
 class UserdataController(NonInteractiveController):
 
@@ -27,6 +31,10 @@ class UserdataController(NonInteractiveController):
 
     def load_autoinstall_data(self, data):
         self.model.clear()
+        if data:
+            self.app.base_model.validate_cloudconfig_schema(
+                data=data, data_source="autoinstall.user-data",
+            )
         self.model.update(data)
 
     def make_autoinstall(self):