StealthOS/subiquity
StealthOS
/
subiquity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
subiquity/subiquitycore/controllers/tests/test_network.py

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

138 lines
3.9 KiB
Python
Raw Normal View History

network: use pyroute2 to manage default routes The existing event based method of watching for has_network has a flaw. The incoming route_change events from probert do not distinguish routes on the same interface but a different metric, so if 2 routes on one interface appear, we only get one event. Then if one of those routes is removed, we will inappropriately remove this route from the default_routes list. Aside from the code watching the event stream, the set of default routes is an elaborate boolean value. Simplify the code by passing around a boolean, and when we get a route_change event, use that to go looking again at the list of default routes. LP: #2004659
2023-02-15 01:17:33 +00:00
# Copyright 2023 Canonical, Ltd.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License as
# published by the Free Software Foundation, either version 3 of the
# License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Affero General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import unittest
from unittest.mock import Mock
from subiquitycore.controllers.network import SubiquityNetworkEventReceiver
class TestRoutes(unittest.IsolatedAsyncioTestCase):
def setUp(self):
self.er = SubiquityNetworkEventReceiver(Mock())
def test_empty(self):
self.assertFalse(self.er._default_route_exists([]))
def test_one_good(self):
routes = [
{
"target": "localhost",
"tflags": 0,
"table": 254,
"ifname": "ens3",
"dst": "",
"dst_len": 0,
network: do not accept route metric > 20000 Network manager can create routes at metric aka priority above 20000. These can stick around if they are not the best choice, or they may disappear quickly. Do not consider one of these routes as a valid default route for has_network purposes.
2023-02-21 17:56:54 +00:00
"priority": 100,
network: use pyroute2 to manage default routes The existing event based method of watching for has_network has a flaw. The incoming route_change events from probert do not distinguish routes on the same interface but a different metric, so if 2 routes on one interface appear, we only get one event. Then if one of those routes is removed, we will inappropriately remove this route from the default_routes list. Aside from the code watching the event stream, the set of default routes is an elaborate boolean value. Simplify the code by passing around a boolean, and when we get a route_change event, use that to go looking again at the list of default routes. LP: #2004659
2023-02-15 01:17:33 +00:00
"gateway": "10.0.2.2",
}
]
self.assertTrue(self.er._default_route_exists(routes))
network: do not accept route metric > 20000 Network manager can create routes at metric aka priority above 20000. These can stick around if they are not the best choice, or they may disappear quickly. Do not consider one of these routes as a valid default route for has_network purposes.
2023-02-21 17:56:54 +00:00
def test_mix(self):
network: use pyroute2 to manage default routes The existing event based method of watching for has_network has a flaw. The incoming route_change events from probert do not distinguish routes on the same interface but a different metric, so if 2 routes on one interface appear, we only get one event. Then if one of those routes is removed, we will inappropriately remove this route from the default_routes list. Aside from the code watching the event stream, the set of default routes is an elaborate boolean value. Simplify the code by passing around a boolean, and when we get a route_change event, use that to go looking again at the list of default routes. LP: #2004659
2023-02-15 01:17:33 +00:00
routes = [
{
"target": "localhost",
"tflags": 0,
"table": 254,
"ifname": "ens3",
"dst": "",
"dst_len": 0,
network: do not accept route metric > 20000 Network manager can create routes at metric aka priority above 20000. These can stick around if they are not the best choice, or they may disappear quickly. Do not consider one of these routes as a valid default route for has_network purposes.
2023-02-21 17:56:54 +00:00
"priority": 100,
network: use pyroute2 to manage default routes The existing event based method of watching for has_network has a flaw. The incoming route_change events from probert do not distinguish routes on the same interface but a different metric, so if 2 routes on one interface appear, we only get one event. Then if one of those routes is removed, we will inappropriately remove this route from the default_routes list. Aside from the code watching the event stream, the set of default routes is an elaborate boolean value. Simplify the code by passing around a boolean, and when we get a route_change event, use that to go looking again at the list of default routes. LP: #2004659
2023-02-15 01:17:33 +00:00
"gateway": "10.0.2.2",
},
{
"target": "localhost",
"tflags": 0,
"table": 254,
"ifname": "ens3",
"dst": "10.0.2.0",
"dst_len": 24,
network: do not accept route metric > 20000 Network manager can create routes at metric aka priority above 20000. These can stick around if they are not the best choice, or they may disappear quickly. Do not consider one of these routes as a valid default route for has_network purposes.
2023-02-21 17:56:54 +00:00
"priority": 100,
"gateway": None,
},
{
"target": "localhost",
"tflags": 0,
"table": 255,
"ifname": "ens3",
"dst": "10.0.2.0",
"dst_len": 24,
"priority": 100,
"gateway": None,
},
{
"target": "localhost",
"tflags": 0,
"table": 254,
"ifname": "ens3",
"dst": "10.0.2.0",
"dst_len": 24,
"priority": 20100,
network: use pyroute2 to manage default routes The existing event based method of watching for has_network has a flaw. The incoming route_change events from probert do not distinguish routes on the same interface but a different metric, so if 2 routes on one interface appear, we only get one event. Then if one of those routes is removed, we will inappropriately remove this route from the default_routes list. Aside from the code watching the event stream, the set of default routes is an elaborate boolean value. Simplify the code by passing around a boolean, and when we get a route_change event, use that to go looking again at the list of default routes. LP: #2004659
2023-02-15 01:17:33 +00:00
"gateway": None,
},
]
self.assertTrue(self.er._default_route_exists(routes))
def test_one_other(self):
routes = [
{
"target": "localhost",
"tflags": 0,
"table": 254,
"ifname": "ens3",
"dst": "10.0.2.0",
"dst_len": 24,
network: do not accept route metric > 20000 Network manager can create routes at metric aka priority above 20000. These can stick around if they are not the best choice, or they may disappear quickly. Do not consider one of these routes as a valid default route for has_network purposes.
2023-02-21 17:56:54 +00:00
"priority": 100,
network: use pyroute2 to manage default routes The existing event based method of watching for has_network has a flaw. The incoming route_change events from probert do not distinguish routes on the same interface but a different metric, so if 2 routes on one interface appear, we only get one event. Then if one of those routes is removed, we will inappropriately remove this route from the default_routes list. Aside from the code watching the event stream, the set of default routes is an elaborate boolean value. Simplify the code by passing around a boolean, and when we get a route_change event, use that to go looking again at the list of default routes. LP: #2004659
2023-02-15 01:17:33 +00:00
"gateway": None,
}
]
self.assertFalse(self.er._default_route_exists(routes))
def test_wrong_table(self):
routes = [
{
"target": "localhost",
"tflags": 0,
"table": 255,
"ifname": "ens3",
"dst": "",
"dst_len": 0,
network: do not accept route metric > 20000 Network manager can create routes at metric aka priority above 20000. These can stick around if they are not the best choice, or they may disappear quickly. Do not consider one of these routes as a valid default route for has_network purposes.
2023-02-21 17:56:54 +00:00
"priority": 100,
"gateway": "10.0.2.2",
}
]
self.assertFalse(self.er._default_route_exists(routes))
def test_wrong_priority(self):
routes = [
{
"target": "localhost",
"tflags": 0,
"table": 254,
"ifname": "ens3",
"dst": "",
"dst_len": 0,
"priority": 20100,
network: use pyroute2 to manage default routes The existing event based method of watching for has_network has a flaw. The incoming route_change events from probert do not distinguish routes on the same interface but a different metric, so if 2 routes on one interface appear, we only get one event. Then if one of those routes is removed, we will inappropriately remove this route from the default_routes list. Aside from the code watching the event stream, the set of default routes is an elaborate boolean value. Simplify the code by passing around a boolean, and when we get a route_change event, use that to go looking again at the list of default routes. LP: #2004659
2023-02-15 01:17:33 +00:00
"gateway": "10.0.2.2",
}
]
self.assertFalse(self.er._default_route_exists(routes))